- 01 Jun, 2015 17 commits
-
-
Dan Carpenter authored
"index" needs to be signed for the error handling to work. Fixes: be9e6229 ('iio: light: Add support for Sensortek STK3310') Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Jonathan Cameron <jic23@kernel.org>
-
Dan Carpenter authored
The line before limits i to 0-3 so the existing code works fine but the check is still off by one and >= is intended instead of >. Signed-off-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
Lars-Peter Clausen authored
In hardware mode we can not use the software demuxer, this means that the selected scan mask needs to match one of the available scan masks exactly. It also means that all attached buffers need to use the same scan mask. Given that when operating in hardware mode there is typically only a single buffer attached to the device this not an issue. Add a sanity check to make sure that only a single buffer is attached in hardware mode nevertheless. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:
-
Lars-Peter Clausen authored
For each buffer type specify the supported device modes for this buffer. This allows us for devices which support multiple different operating modes to pick the correct operating mode based on the modes supported by the attached buffers. It also prevents that buffers with conflicting modes are attached to a device at the same time or that a buffer with a non-supported mode is attached to a device (e.g. in-kernel callback buffer to a device only supporting hardware mode). Signed-off-by:
-
Lars-Peter Clausen authored
Even if no userspace consumer buffer is attached to the IIO device at registration we still need to compute the masklength, since it is possible that a in-kernel consumer buffer is going to get attached to the device at a later point. Signed-off-by:
-
Vladimirs Ambrosovs authored
Fix the module_param "instances" type to uint, since the variable type holding the value is unsigned. Signed-off-by:
Vladimirs Ambrosovs <rodriguez.twister@gmail.com> Signed-off-by:
-
Vladimirs Ambrosovs authored
The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and iio_dummy_evgen_release_irq() were changed to return void instead of int. Signed-off-by:
-
Vladimirs Ambrosovs authored
This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and no devices being removed in case the probe function fails, running in a loop. Signed-off-by:
-
Laurent Navet authored
The same code is executed regardless ret value, so this test can be removed. Also fix coverity scan CID 1268786. Signed-off-by:
Laurent Navet <laurent.navet@gmail.com> Signed-off-by:
-
Hartmut Knaack authored
Mark strings, which are not supposed to be changed (basedir, filename, value), as const in function parameters. Signed-off-by:
Hartmut Knaack <knaack.h@gmx.de> Signed-off-by:
-
Hartmut Knaack authored
In generic_buffer.c: sort program parameters alphabetically and provide usage information In lsiio.c: drop unused parameters Signed-off-by:
-
Hartmut Knaack authored
In build_channel_array(), count can be initialized already during variable declaration. Signed-off-by:
-
Hartmut Knaack authored
In iioutils_get_type() it is logically better fitting to have sysfsfp assigned zero right after closing it. Signed-off-by:
-
Hartmut Knaack authored
Change the assignment of *is_signed in iioutils_get_type() to a one-liner, as already done with *be. Signed-off-by:
-
Hartmut Knaack authored
Refactor the code in print_event() to reduce code duplication and better reflect that the type is output unconditionally, as well as cascade the dependency of the diff-channel. Saves a few lines of code, as well. Signed-off-by:
-
Hartmut Knaack authored
Return directly, if no common cleanup is required. Signed-off-by:
-
Hartmut Knaack authored
Fully document public functions and elements. Signed-off-by:
-
- 31 May, 2015 20 commits
-
-
Hartmut Knaack authored
Add error handling to calls which can indicate a major problem by returning an error code. This also involves to change the type of dump_devices() from void to int. Signed-off-by:
-
Hartmut Knaack authored
Add error handling to calls which can indicate a major problem by returning an error code. This also sets ret to -ENOENT in iioutils_get_type() and iioutils_get_param_float() to indicate if no matching directory entry was found. Signed-off-by:
-
Hartmut Knaack authored
Add error handling to calls which can indicate a major problem by returning an error code. Signed-off-by:
-
Hartmut Knaack authored
Add error handling to calls which can indicate a major problem by returning an error code. Signed-off-by:
-
Hartmut Knaack authored
Add handler to catch errors on conversion of numerical arguments. Signed-off-by:
-
Hartmut Knaack authored
This patch catches errors in string allocation in generic_buffer.c, iio_event_monitor.c, iio_utils.c and lsiio.c. Signed-off-by:
-
Hartmut Knaack authored
Functions _write_sysfs_int() and _write_sysfs_string() are supposed to be called only by public wrappers, so make them static. Signed-off-by:
-
Hartmut Knaack authored
Previously, the return value of sscanf() was treated as an indication of the digits it would have read. Yet, sscanf() only returns the amount of valid matches. Therefore, introduce a function to calculate the decimal digits of the read number and use this one to commence a colon search, as originally intended. Signed-off-by:
-
Hartmut Knaack authored
fscanf() usually returns the number of input items successfully matched and assigned, which can be fewer than provided (or even zero). Add a check in iioutils_get_type() to make sure all items are matched. Signed-off-by:
-
Hartmut Knaack authored
Refactor process_scan() to handle signed and unsigned data, respect shifts and the data mask for 2, 4 and 8 byte sized scan elements. Signed-off-by:
-
Hartmut Knaack authored
find_type_by_name() returns a valid error code in case of an error. Pass this code up instead of an artificial one. Signed-off-by:
-
Hartmut Knaack authored
Since errno contains the value of any of the defined error names, a negation will not lead to the desired match. Signed-off-by:
-
Hartmut Knaack authored
Move up error handling code to preserve the errno coming from ioctl(), before it may be changed by close(). Signed-off-by:
-
Hartmut Knaack authored
The man-page of errno states, that errno should be saved before doing any library call, as that call may have changed the value of errno. So, when encountering any error, save errno first. This patch affects generic_buffer.c, iio_event_monitor.c and iio_utils.c. Signed-off-by:
-
Hartmut Knaack authored
In dump_channels() the DIR *dp was left open on exit. Close it and check for errors. Signed-off-by:
-
Hartmut Knaack authored
In build_channel_array(), count needs to be decreased in more places since current->name and current->generic_name would be freed on the error path, although they have not been allocated, yet. This also requires to free current->name, when it is allocated, but current->generic_name is not yet allocated. Signed-off-by:
-
Hartmut Knaack authored
In iio_utils.c build_channel_array() dynamically allocates the string generic_name in the current iio_channel_info, which doesn't got freed in case of an error. This dynamically allocated channel-array is used by generic_buffer, and needs to be freed on the error/exit path. Signed-off-by:
-
Hartmut Knaack authored
In the error path, the string scan_el_dir got freed, while it was missing when build_channel_array() finished without errors. Signed-off-by:
-
Hartmut Knaack authored
Make sure to free dev_dir_name in case of an error or regular exit. Signed-off-by:
-
Hartmut Knaack authored
data gets allocated before buffer_access, so it should be freed in reverse order. Otherwise, if allocating buffer_access fails, an attempt to free it would be taken, which should not happen. Signed-off-by:
-
- 23 May, 2015 3 commits
-
-
Tiberiu Breana authored
Minimal implementation of an IIO driver for the Sensortek STK8BA50 3-axis accelerometer. Datasheet: http://szgsensor.com/uploads/soft/141229/STK8BA50%D2%E5%BC%CE.pdf Includes: - ACPI support; - read_raw for x,y,z axes; - reading and setting the scale (range) parameter. - power management Signed-off-by:
Tiberiu Breana <tiberiu.a.breana@intel.com> Signed-off-by:
-
Lars-Peter Clausen authored
Currently when something goes wrong at some step when disabling the buffers we immediately abort. This has the effect that the enable/disable calls are no longer balanced. So make sure that even if one step in the disable sequence fails the other steps are still executed. The other issue is that when either enable or disable fails buffers that were active at that time stay active while the device itself is disabled. This leaves things in a inconsistent state and can cause unbalanced enable/disable calls. Furthermore when enable fails we restore the old scan mask, but still keeps things disabled. Given that verification of the configuration was performed earlier and it is valid at the point where we try to enable/disable the most likely reason of failure is a communication failure with the device or maybe a out-of-memory situation. There is not really a good recovery strategy in such a case, so it makes sense to leave the device disabled, but we should still leave it in a consistent state. What the patch does if disable/enable fails is to deactivate all buffers and make sure that the device will be in the same state as if all buffers had been manually disabled. Signed-off-by:
-
Lars-Peter Clausen authored
__iio_update_buffers is already a rather large function with many different error paths and it is going to get even larger. This patch factors out the device enable and device disable paths into separate helper functions. The patch also re-implements iio_disable_all_buffers() using the new iio_disable_buffers() function removing a fair bit of redundant code. Signed-off-by:
-
