Commits · ee264346fa08395aa6e846b72e7b3987e959f053 · Kirill Smelkov / linux

18 Jun, 2014 40 commits

staging: rtl8723au: Add compiler check for -Wtype-limits · ee264346

Geert Uytterhoeven authored Jun 11, 2014

Gcc versions before 4.3 do not support -Wtype-limits:

cc1: error: unrecognized command line option "-Wtype-limits"
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ee264346

staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Avoid pointless memcpy · 7579a7e4

Jes Sorensen authored Jun 09, 2014

There is no point copying a buffer, just to scan it and then free it
again.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7579a7e4

staging: rtl8723au: Move FillH2CCmd() prototype to rtl8723a_cmd.h where it really belongs · 37987866

Jes Sorensen authored Jun 09, 2014

As an added bonus, remove the now obsolete rtw_ioctl_set.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

37987866

staging: rtl8723au: Quiet unused variable warning when building with CONFIG_8723AU_AP_MODE=n · da23732c
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
da23732c
staging: rtl8723au: Don't run regular scans in the driver, the stack handles that · 073c9d47
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
073c9d47
staging: rtl8723au: rtw_set_802_11_bssid23a_list_scan(): Use __func__ to print function name · e9bb5ad4
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
e9bb5ad4

staging: rtl8723au: Move rtw_get_cur_max_rate23a() to ioctl_cfg80211.c · 27fd731e

Jes Sorensen authored Jun 09, 2014

This function has only one caller, so move it home and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

27fd731e

staging: rtl8723au: rtw_get_cur_max_rate23a(): We are in N mode if... · 023b40d8

Jes Sorensen authored Jun 09, 2014

staging: rtl8723au: rtw_get_cur_max_rate23a(): We are in N mode if WLAN_EID_HT_CAPABILITY is present
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

023b40d8

staging: rtl8723au: rtw_get_cur_max_rate23a(): Remove duplicate fwstate checks · 8f9558b9
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8f9558b9
staging: rtl8723au: Move rtw_do_join23a() to rtw_mlme.c and declare it static · e007b4c7
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
e007b4c7

staging: rtl8723au: rtw_do_join23a(): Don't start scanning if network isn't found · e89c0550

Jes Sorensen authored Jun 09, 2014

Don't start running network scans if trying to connect to a network
not in our cache. Let the 802.11 stack do it's job instead.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e89c0550

staging: rtl8723au: rtw_set_ssid(): Use rtw_do_join_network() · 72795e9d

Jes Sorensen authored Jun 09, 2014

We already have the wlan_network we wish to join, hence it's pointless
to go back to the scanned_queue and pull it out of there, before
running the join logic.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

72795e9d

staging: rtl8723au: rtw_select_and_join_from_scanned_queue23a() never returns 2 · 85b3c5e4
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
85b3c5e4
staging: rtl8723au: rtw_surveydone_event_callback23a(): We always set _FW_UNDER_LINKING · 66ed1bc9
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
66ed1bc9

staging: rtl8723au: to_join will no be true if _FW_LINKED is set · e5c4db09

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e5c4db09

staging: rtl8723au: Remove no-op rtw_get_encrypt_decrypt_from_registrypriv23a() · 3221bb53
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
3221bb53
staging: rtl8723au: Consolidate duplicate adhoc joining code into rtw_do_join_adhoc() · fcc6020a
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
fcc6020a
staging: rtl8723au: rtw_surveydone_event_callback23a(): Remove superfluous memset() · ca3504be
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
ca3504be
staging: rtl8723au: rtw_do_join23a(): Use __func__ to get function name in debug messages · 557f9a45
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
557f9a45

staging: rtl8723au: Introduce rtw_do_join_network() · b66dad2d

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

b66dad2d

staging: rtl8723au: Introduce rtw_select_candidate_from_queue() · 0e634a02

Jes Sorensen authored Jun 09, 2014

This splits a portion of rtw_select_and_join_from_scanned_queue23a()
into rtw_select_candidate_from_queue()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

0e634a02

staging: rtl8723au: Don't prepend debug console messages with 'ERROR ' · fa862a7f

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fa862a7f

staging: rtl8723au: Minor debug message fixup · 2febc867

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2febc867

staging: rtl8723au: rtw_do_join23a(): Use correct error return values · be82728e

Jes Sorensen authored Jun 09, 2014

Don't mix true/fail with _SUCCESS/_FAIL as return value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

be82728e

staging: rtl8723au: rtw_cfg80211_add_wep(): Use WLAN_KEY_LEN_* · 4d9c63bb

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

4d9c63bb

staging: rtl8723au: rtw_set_ssid(): This is never called with _FW_UNDER_LINKING · 70fbc1a8
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
70fbc1a8

staging: rtl8723au: Pass a struct wlan_network to rtw_set_ssid() · e73d82ef

Jes Sorensen authored Jun 09, 2014

There is no point copying the ssid out of struct wlan_network when we
can just pass on the whole struct.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

e73d82ef

staging: rtl8723au: cfg80211_rtw_connect(): Simplify ssid preparation · 9cb08ff3

Jes Sorensen authored Jun 09, 2014

Since we just matched sme->{ssid,ssid_len} to
pnetwork->network.Ssid.{ssid,ssid_len} we can simplify the copy and
move it to just before the call to rtw_set_ssid().
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9cb08ff3

staging: rtl8723au: cfg80211_rtw_connect(): Remove obfuscating pointers · 9ab98d42

Jes Sorensen authored Jun 09, 2014

dst_ssid and dst_bssid were just obfuscating that we were in fact
looking at pnetwork.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

9ab98d42

staging: rtl8723au: cfg80211_rtw_connect(): Clean up various bits · c5178b0b

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

c5178b0b

staging: rtl8723au: Move rtw_set_802_11_ssid23a() to ioctl_cfg80211.c · 97c4361d

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

97c4361d

staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect() · 39dbc446
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
39dbc446

staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from... · 7c0e0636

Jes Sorensen authored Jun 09, 2014

staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7c0e0636

staging: rtl8723au: Make rtw_is_same_ibss23a() return bool · ec36ce29

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ec36ce29

staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE · 7b2e06a1

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

7b2e06a1

staging: rtl8723au: OnAuth23a(): Use ether_addr_copy() · ded7a20f

Jes Sorensen authored Jun 09, 2014

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

ded7a20f

staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset() · 1ae17bf1
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
1ae17bf1

staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a() · 46805acb

Jes Sorensen authored Jun 09, 2014

Use _rtw_free_network23() so elements are freed in one place.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

46805acb

staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d · 8d7fb1b8
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
8d7fb1b8
staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info() · 1bebe756
Jes Sorensen authored Jun 09, 2014
```
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
```
1bebe756