- 21 Sep, 2021 1 commit
-
-
Konstantin Komarov authored
Do not try to insert attribute if there is no room in record. Reviewed-by:
Kari Argillander <kari.argillander@gmail.com> Signed-off-by:
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
-
- 20 Sep, 2021 13 commits
-
-
Colin Ian King authored
Currently a failed allocation on sbi->upcase will cause an exit via the label free_sbi causing a memory leak on object opts. Fix this by re-ordering the exit paths free_opts and free_sbi so that kfree's occur in the reverse allocation order. Addresses-Coverity: ("Resource leak") Fixes: 27fac777 ("fs/ntfs3: Init spi more in init_fs_context than fill_super") Signed-off-by:Colin Ian King <colin.king@canonical.com> Reviewed-by:
-
Kari Argillander authored
Current ntfs3 rst documentation is broken. I turn table to list table as this is current Linux documentation quide line. Simple table also did not quite work in our situation as we need to span rows together. It still look quite good as text so we did not loss anything. This will also make diffing quite bit more pleasure. Signed-off-by:
-
Kari Argillander authored
Right now sb blocksize first get initiliazed in fill_super but in can be changed in helper function. It makes more sense to that this happened only in one place. Because we move this to helper function it makes more sense that s_maxbytes will also be there. I rather have every sb releted thing in fill_super, but because there is already sb releted stuff in this helper. This will have to do for now. Signed-off-by:
-
Kari Argillander authored
Initializing should be as close as possible when we use it so that we do not need to scroll up to see what is happening. Also bdev_get_queue() can never return NULL so we do not need to check for !rq. Signed-off-by:
-
Kari Argillander authored
We can survive without this tmp point upcase. So remove it we don't have so many tmp pointer in this function. Signed-off-by:
-
Kari Argillander authored
Drop tmp pointer bd_inode because this is only used ones in fill_super. Also we have so many initializing happening at the beginning that it is already way too much to follow. Signed-off-by:
-
Kari Argillander authored
We only use this in two places so we do not really need it. Also wrapper sb_rdonly() is pretty self explanatory. This will make little bit easier to read this super long variable list in the beginning of ntfs_fill_super(). Signed-off-by:
-
Kari Argillander authored
Use sb instead of sbi->sb in fill_super. We have sb so why not use it. Also makes code more readable. Signed-off-by:
-
Kari Argillander authored
Remove some unnecessary variable loading. These look like copy paste work and they are not used to anything. Signed-off-by:
-
Kari Argillander authored
In many places it is not needed to use goto out. We can just return right away. This will make code little bit more cleaner as we won't need to check error path. Signed-off-by:
-
Kari Argillander authored
Remove root drop when we fault out. This can never happened because when we allocate root we eather fault when no root or success. Signed-off-by:
-
Kari Argillander authored
Change EINVAL to ENOMEM when d_make_root fails because that is right errno. Signed-off-by:
-
Kari Argillander authored
Fix wrong error message $Logfile -> $UpCase. Probably copy paste. Fixes: 203c2b3a406a ("fs/ntfs3: Add initialization of super block") Signed-off-by:
-
- 16 Sep, 2021 8 commits
-
-
Kari Argillander authored
We can make code little bit more readable by using min/max macros. These were found with Coccinelle. Signed-off-by:
-
Kari Argillander authored
We can make code little more readable by using kernel macros clamp/max. This were found with kernel included Coccinelle minmax script. Signed-off-by:
-
Kari Argillander authored
We do not need this check as this is same thing as NTFS_MIN_MFT_ZONE > zlen. We already check NTFS_MIN_MFT_ZONE <= zlen and exit because is too big request. Remove it so code is cleaner. Signed-off-by:
-
Kari Argillander authored
If ntfs_refresh_zone() returns error it will be changed to -ENOSPC. It is not right. Also caller of this functions also check other errors. Fixes: 78ab59fe ("fs/ntfs3: Rework file operations") Signed-off-by:
-
Kari Argillander authored
Remove tabs before spaces from comment as recommended by kernel coding style. Checkpatch also warn about these. Signed-off-by:
-
Kari Argillander authored
Remove braces from single statment block as they are not needed. Also Linux kernel coding style guide recommend this and checkpatch warn about this. Signed-off-by:
-
Kari Argillander authored
For better code readability place constant always right side of the test. This will also address checkpatch warning. Signed-off-by:
-
Kari Argillander authored
No need for plus sign here. So remove it. Checkpatch will also be happy. Signed-off-by:
-
- 13 Sep, 2021 12 commits
-
-
Kari Argillander authored
We do not have any reason to keep old linear search in. Before this was used for error path or if table was so big that it cannot be allocated. Current binary search implementation won't need error path. Remove old references to linear entry search. Signed-off-by:
-
Kari Argillander authored
We could try to optimize algorithm to first fill just small table and after that use bigger table all the way up to ARRAY_SIZE(offs). This way we can use bigger search array, but not lose benefits with entry count smaller < ARRAY_SIZE(offs). Signed-off-by:
-
Kari Argillander authored
Current binary search allocates memory for table and fill whole table before we start actual binary search. This is quite inefficient because table fill will always be O(n). Also if table is huge we need to reallocate memory which is costly. This implementation use just stack memory and always when table is full we will check if last element is <= and if not start table fill again. The idea was that it would be same cost as table reallocation. Signed-off-by:
-
Kari Argillander authored
We have lot of unnecessary headers in these files. Remove them so that we help compiler a little bit. Signed-off-by:
-
Kari Argillander authored
There is lot of headers which we do not need in this file. Delete them and add what we really need. Here is list which identify why we need this header. <linux/kernel.h> // min() <linux/slab.h> // kzalloc() <linux/stddef.h> // offsetof() <linux/string.h> // memcpy(), memset() <linux/types.h> // u8, size_t, etc. "debug.h" // PtrOffset() Signed-off-by:
-
Kari Argillander authored
There is no headers. They will be included through ntfs_fs.c, but that is not right thing to do. Let's include headers what this file need straight away. types.h is needed for __le16, u8 etc. kernel.h is needed for le16_to_cpu() Signed-off-by:
-
Kari Argillander authored
We only need linux/types.h for types like u8 etc. So we can remove rest and help compiler a little bit. Signed-off-by:
-
Kari Argillander authored
size_t needs header. Add missing header guards so that compiler will only include these ones. Signed-off-by:
-
Kari Argillander authored
We do not have headers at all in this file. We should have them so that not every .c file needs to include all of the stuff which this file need for building. This way we can remove some headers from other files and get better picture what is needed. This can save some compilation time. And this can help if we sometimes want to separate this one big header. Also use forward declarations for structs and enums when it not included straight with include and it is used in function declarations input. This will prevent possible compiler warning: xxx declared inside parameter list will not be visible outside of this definition or declaration Here is list which I made when parsing this. There is not necessarily all example from this header file, but this just proofs we need it. <linux/blkdev.h> SECTOR_SHIFT <linux/buffer_head.h> sb_bread(), put_bh <linux/cleancache.h> put_page() <linux/fs.h> struct inode (Just struct ntfs_inode need it) <linux/highmem.h> kunmap(), kmap() <linux/kernel.h> cpu_to_leXX() ALIGN <linux/mm.h> kvfree() <linux/mutex.h> struct mutex, mutex_(un/try)lock() <linux/page-flags.h> PageError() <linux/pagemap.h> read_mapping_page() <linux/rbtree.h> struct rb_root <linux/rwsem.h> struct rw_semaphore <linux/slab.h> krfree(), kzalloc() <linux/string.h> memset() <linux/time64.h> struct timespec64 <linux/types.h> uXX, __leXX <linux/uidgid.h> kuid_t, kgid_t <asm/div64.h> do_div() <asm/page.h> PAGE_SIZE "debug.h" ntfs_err() (Just one entry. Maybe we can drop this) "ntfs.h" Do you even ask? Signed-off-by:
-
Kari Argillander authored
We do not have header files at all in this file. Add following headers and there is also explanation which for it was added. Note that explanation might not be complete, but it just proofs it is needed. <linux/blkdev.h> // SECTOR_SHIFT <linux/build_bug.h> // static_assert() <linux/kernel.h> // cpu_to_le64, cpu_to_le32, ALIGN <linux/stddef.h> // offsetof() <linux/string.h> // memcmp() <linux/types.h> //__le32, __le16 "debug.h" // PtrOffset(), Add2Ptr() Signed-off-by:
-
Kari Argillander authored
Add forward declarations for structs so that we can include this file without warnings even without linux/fs.h Signed-off-by:
-
Colin Ian King authored
The variable err is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by:
-
- 09 Sep, 2021 6 commits
-
-
Kari Argillander authored
Show options should show option according documentation when some value is not default or when ever coder wants. Uid/gid are problematic because it is hard to know which are defaults. In file system there is many different implementation for this problem. Some file systems show uid/gid when they are different than root, some when user has set them and some show them always. There is also problem that what if root uid/gid change. This code just choose to show them always. This way we do not need to think this any more. Signed-off-by:
-
Kari Argillander authored
Rename mount option no_acs_rules to (no)acsrules. This allow us to use possibility to mount with options noaclrules or aclrules. Acked-by:
Christian Brauner <christian.brauner@ubuntu.com> Reviewed-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
-
Kari Argillander authored
Other fs drivers are using iocharset= mount option for specifying charset. So add it also for ntfs3 and mark old nls= mount option as deprecated. Reviewed-by:
Pali Rohár <pali@kernel.org> Signed-off-by:
-
Kari Argillander authored
If we call Opt_nohidden with just keyword hidden, then we can use hidden/nohidden when mounting. We already use this method for almoust all other parameters so it is just logical that this will use same method. Acked-by:
-
Kari Argillander authored
init_fs_context() is meant to initialize s_fs_info (spi). Move spi initializing code there which we can initialize before fill_super(). Signed-off-by:
-
Kari Argillander authored
We have now new mount api as described in Documentation/filesystems. We should use it as it gives us some benefits which are desribed here lore.kernel.org/linux-fsdevel/159646178122.1784947.11705396571718464082.stgit@warthog.procyon.org.uk/ Nls loading is changed a to load with string. This did make code also little cleaner. Also try to use fsparam_flag_no as much as possible. This is just nice little touch and is not mandatory but it should not make any harm. It is just convenient that we can use example acl/noacl mount options. Signed-off-by:
-
