- 17 Feb, 2017 28 commits
-
-
David Sterba authored
write_all_supers and write_ctree_super are almost equal, the parameter 'trans' is unused so we can drop it and have just one helper. Reviewed-by:
Liu Bo <bo.li.liu@oracle.com> Signed-off-by:
David Sterba <dsterba@suse.com>
-
David Sterba authored
The barriers are handled by the caller. Reviewed-by:
-
David Sterba authored
Never used. Reviewed-by:
-
David Sterba authored
Added but never needed. Reviewed-by:
-
David Sterba authored
Added but never used. Reviewed-by:
-
David Sterba authored
Never used in that function. Reviewed-by:
-
David Sterba authored
Change the name so it matches the naming we already use eg. for btrfs_path. Suggested-by:
Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by:
-
David Sterba authored
There was never need for RCU protection around reading nodesize or other fairly constant filesystem data. Signed-off-by: -
David Sterba authored
The helper name is not too helpful and is just wrapping a simple call. Signed-off-by: -
David Sterba authored
The quota status used to be tracked as a variable, so the mutex was needed (until "Btrfs: add a flags field to btrfs_fs_info" afcdd129). Since the status is a bit modified atomically and we don't hold the mutex beyond the check, we can drop it. Signed-off-by:
-
David Sterba authored
Status of quotas should be the first check in btrfs_qgroup_account_extent and we can return immediatelly, no need to do no-op ulist frees. Signed-off-by: -
David Sterba authored
We can embed range_changed to the extent changeset to address following problems: - no need to allocate ulist dynamically, we also get rid of the GFP_NOFS for free - fix lack of allocation failure checking in btrfs_qgroup_reserve_data The stack consuption where extent_changeset is used slightly increases: before: 16 after: 16 - 8 (for pointer) + 32 (sizeof ulist) = 40 Which is bearable. Reviewed-by:
-
David Sterba authored
Make ulist_fini externally visible so the ulist API is complete. Signed-off-by: -
David Sterba authored
Internal helper. Signed-off-by: -
David Sterba authored
We do a readahead of the free space cache inode to speed things up but the failure is not fatal, like in other readahead cases. Proper reads would need to happen anyway and any errors would be caught there. Reviewed-by:
-
David Sterba authored
Qgroup relations are added/deleted from ioctl, we hold the high level qgroup lock, no deadlocks or recursion from the allocation possible here. Signed-off-by: -
David Sterba authored
We don't need to use GFP_NOFS here as this is called from ioctls an the only lock held is the subvol_sem, which is of a high level and protects creation/renames/deletion and is never held in the writeout paths. Signed-off-by: -
David Sterba authored
The qgroup config is read during mount, we do not have to use NOFS. Signed-off-by: -
David Sterba authored
We don't need to use GFP_NOFS here as this is called from ioctls an the only lock held is the subvol_sem, which is of a high level and protects creation/renames/deletion and is never held in the writeout paths. Signed-off-by: -
Liu Bo authored
As 0 refers to an existing type BTRFS_ORDERED_IO_DONE, this specifies a new type 'REGULAR' for regular IO. Signed-off-by:
-
Liu Bo authored
We have similar codes to create and insert extent mapping around IO path, this merges them into a single helper. Signed-off-by:
-
Liu Bo authored
This uses a helper instead of open code around used byte of space_info everywhere. Signed-off-by:
-
Liu Bo authored
We don't need to take the lock if the block group has not been cached. Signed-off-by:
-
Qu Wenruo authored
The original csum error message only outputs inode number, offset, check sum and expected check sum. However no root objectid is outputted, which sometimes makes debugging quite painful under multi-subvolume case (including relocation). Also the checksum output is decimal, which seldom makes sense for users/developers and is hard to read in most time. This patch will add root objectid, which will be %lld for rootid larger than LAST_FREE_OBJECTID, and hex csum output for better readability. Signed-off-by:
-
Takafumi Kubota authored
If btrfs_bio_alloc fails in submit_extent_page, submit_extent_page returns without clearing the writeback bit of the failed page. __extent_writepage_io, that is a caller of submit_extent_page, does not clear the remaining writeback bit anywhere. As a result, this will cause the hang at filemap_fdatawait_range, because it waits the writeback bit to be cleared from the failed page. So, we have to call end_page_writeback to clear the writeback bit. For reproducing the hang, we inject a fault like if (should_failtest()) { // I define should_failtest() bio = NULL; } else { bio = btrfs_bio_alloc(...); } in submit_extent_page. We should also check whether page has the bit before end_page_writeback, to avoid the conflict against the other end_page_writeback in bio_endio. Thus, we add PageWriteback checks not only in __extent_writepage_io, but also in write_one_eb too, because it misses the check. Signed-off-by:Takafumi Kubota <takafumi.kubota1012@sslab.ics.keio.ac.jp> Reviewed-by:
-
David Sterba authored
Commit "btrfs: ulist: Add ulist_del() function" (d4b80404) removed some debugging code but left the structure defintions. Reviewed-by:
-
Liu Bo authored
Since we have a helper to set page bits, let lock_delalloc_pages and __unlock_for_delalloc use it. Signed-off-by:
-
Liu Bo authored
Signed-off-by:
-
- 14 Feb, 2017 12 commits
-
-
Liu Bo authored
This introduces a new helper which can be used to process pages bits. Signed-off-by:
-
Liu Bo authored
run_delalloc_nocow has used trans in two places where they don't actually need @trans. For btrfs_lookup_file_extent, we search for file extents without COWing anything, and for btrfs_cross_ref_exist, the only place where we need @trans is deferencing it in order to get running_transaction which we could easily get from the global fs_info. Signed-off-by:
-
Liu Bo authored
All we need is @delayed_refs, all callers have get it ahead of calling btrfs_find_delayed_ref_head since lock needs to be acquired firstly, there is no reason to deference it again inside the function. Signed-off-by:
-
Liu Bo authored
@trans is not used at all, this removes it. Signed-off-by:
-
Liu Bo authored
@cached_state is no more required in __extent_writepage_io, also remove the goto label. Signed-off-by:
-
Jeff Mahoney authored
Once a qgroup limit is exceeded, it's impossible to restore normal operation to the subvolume without modifying the limit or removing the subvolume. This is a surprising situation for many users used to the typical workflow with quotas on other file systems where it's possible to remove files until the used space is back under the limit. When we go to unlink a file and start the transaction, we'll hit the qgroup limit while trying to reserve space for the items we'll modify while removing the file. We discussed last month how best to handle this situation and agreed that there is no perfect solution. The best principle-of-least-surprise solution is to handle it similarly to how we already handle ENOSPC when unlinking, which is to allow the operation to succeed with the expectation that it will ultimately release space under most circumstances. This patch modifies the transaction start path to select whether to honor the qgroups limits. btrfs_start_transaction_fallback_global_rsv is the only caller that skips enforcement. The reservation and tracking still happens normally -- it just skips the enforcement step. Signed-off-by:
Jeff Mahoney <jeffm@suse.com> Reviewed-by:
-
Liu Bo authored
Commit Btrfs: btrfs_page_mkwrite: Reserve space in sectorsized units" (d0b7da88) did this, but btrfs_lookup_ordered_range expects a 'length' rather than a 'page_end'. Signed-off-by:
Chandan Rajendra <chandan@linux.vnet.ibm.com> Signed-off-by:
-
Qu Wenruo authored
Variable 'walk' in lock_stripe_add() is not used. Remove it. Signed-off-by:
-
Omar Sandoval authored
This was originally a prep patch for changing the behavior on len=0, but we went another direction with that. This still makes the function slightly easier to follow. Reviewed-by:
Omar Sandoval <osandov@fb.com> Reviewed-by:
-
Omar Sandoval authored
In a lot of places, it's unclear when it's safe to reuse a struct btrfs_key after it has been passed to a helper function. Constify these arguments wherever possible to make it obvious. Signed-off-by:
-
Liu Bo authored
Dio writes can update i_size in btrfs_get_blocks_direct when it writes to offset beyond EOF so that endio can update disk_i_size correctly (because we don't udpate disk_i_size beyond i_size). However, when truncating down a file, we firstly update i_size and then wait for in-flight lockless dio reads/writes, according to the above, i_size may have been changed in dio writes, and file extents don't get truncated. For lockless dio writes are always overwrites, i_size is not supposed to be changed, so this adds a check to filter out this case. The race could be reproduced by fstests/generic/299 with patch "Btrfs: fix btrfs_ordered_update_i_size to update disk_i_size properly" applied. Signed-off-by:
-
Liu Bo authored
Since we have a good helper entry_end, use it for ordered extent. Signed-off-by:
-
