1. 02 Feb, 2021 14 commits
  2. 29 Jan, 2021 4 commits
    • Wang ShaoBo's avatar
      kretprobe: Avoid re-registration of the same kretprobe earlier · 0188b878
      Wang ShaoBo authored
      Our system encountered a re-init error when re-registering same kretprobe,
      where the kretprobe_instance in rp->free_instances is illegally accessed
      after re-init.
      
      Implementation to avoid re-registration has been introduced for kprobe
      before, but lags for register_kretprobe(). We must check if kprobe has
      been re-registered before re-initializing kretprobe, otherwise it will
      destroy the data struct of kretprobe registered, which can lead to memory
      leak, system crash, also some unexpected behaviors.
      
      We use check_kprobe_rereg() to check if kprobe has been re-registered
      before running register_kretprobe()'s body, for giving a warning message
      and terminate registration process.
      
      Link: https://lkml.kernel.org/r/20210128124427.2031088-1-bobo.shaobowang@huawei.com
      
      Cc: stable@vger.kernel.org
      Fixes: 1f0ab409 ("kprobes: Prevent re-registration of the same kprobe")
      [ The above commit should have been done for kretprobes too ]
      Acked-by: default avatarNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
      Acked-by: default avatarAnanth N Mavinakayanahalli <ananth@linux.ibm.com>
      Acked-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
      Signed-off-by: default avatarWang ShaoBo <bobo.shaobowang@huawei.com>
      Signed-off-by: default avatarCheng Jian <cj.chengjian@huawei.com>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      0188b878
    • Masami Hiramatsu's avatar
      tracing/kprobe: Fix to support kretprobe events on unloaded modules · 97c753e6
      Masami Hiramatsu authored
      Fix kprobe_on_func_entry() returns error code instead of false so that
      register_kretprobe() can return an appropriate error code.
      
      append_trace_kprobe() expects the kprobe registration returns -ENOENT
      when the target symbol is not found, and it checks whether the target
      module is unloaded or not. If the target module doesn't exist, it
      defers to probe the target symbol until the module is loaded.
      
      However, since register_kretprobe() returns -EINVAL instead of -ENOENT
      in that case, it always fail on putting the kretprobe event on unloaded
      modules. e.g.
      
      Kprobe event:
      /sys/kernel/debug/tracing # echo p xfs:xfs_end_io >> kprobe_events
      [   16.515574] trace_kprobe: This probe might be able to register after target module is loaded. Continue.
      
      Kretprobe event: (p -> r)
      /sys/kernel/debug/tracing # echo r xfs:xfs_end_io >> kprobe_events
      sh: write error: Invalid argument
      /sys/kernel/debug/tracing # cat error_log
      [   41.122514] trace_kprobe: error: Failed to register probe event
        Command: r xfs:xfs_end_io
                   ^
      
      To fix this bug, change kprobe_on_func_entry() to detect symbol lookup
      failure and return -ENOENT in that case. Otherwise it returns -EINVAL
      or 0 (succeeded, given address is on the entry).
      
      Link: https://lkml.kernel.org/r/161176187132.1067016.8118042342894378981.stgit@devnote2
      
      Cc: stable@vger.kernel.org
      Fixes: 59158ec4 ("tracing/kprobes: Check the probe on unloaded module correctly")
      Reported-by: default avatarJianlin Lv <Jianlin.Lv@arm.com>
      Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      97c753e6
    • Viktor Rosendahl's avatar
      tracing: Use pause-on-trace with the latency tracers · da7f84cd
      Viktor Rosendahl authored
      Eaerlier, tracing was disabled when reading the trace file. This behavior
      was changed with:
      
      commit 06e0a548 ("tracing: Do not disable tracing when reading the
      trace file").
      
      This doesn't seem to work with the latency tracers.
      
      The above mentioned commit dit not only change the behavior but also added
      an option to emulate the old behavior. The idea with this patch is to
      enable this pause-on-trace option when the latency tracers are used.
      
      Link: https://lkml.kernel.org/r/20210119164344.37500-2-Viktor.Rosendahl@bmw.de
      
      Cc: stable@vger.kernel.org
      Fixes: 06e0a548 ("tracing: Do not disable tracing when reading the trace file")
      Signed-off-by: default avatarViktor Rosendahl <Viktor.Rosendahl@bmw.de>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      da7f84cd
    • Steven Rostedt (VMware)'s avatar
      fgraph: Initialize tracing_graph_pause at task creation · 7e0a9220
      Steven Rostedt (VMware) authored
      On some archs, the idle task can call into cpu_suspend(). The cpu_suspend()
      will disable or pause function graph tracing, as there's some paths in
      bringing down the CPU that can have issues with its return address being
      modified. The task_struct structure has a "tracing_graph_pause" atomic
      counter, that when set to something other than zero, the function graph
      tracer will not modify the return address.
      
      The problem is that the tracing_graph_pause counter is initialized when the
      function graph tracer is enabled. This can corrupt the counter for the idle
      task if it is suspended in these architectures.
      
         CPU 1				CPU 2
         -----				-----
        do_idle()
          cpu_suspend()
            pause_graph_tracing()
                task_struct->tracing_graph_pause++ (0 -> 1)
      
      				start_graph_tracing()
      				  for_each_online_cpu(cpu) {
      				    ftrace_graph_init_idle_task(cpu)
      				      task-struct->tracing_graph_pause = 0 (1 -> 0)
      
            unpause_graph_tracing()
                task_struct->tracing_graph_pause-- (0 -> -1)
      
      The above should have gone from 1 to zero, and enabled function graph
      tracing again. But instead, it is set to -1, which keeps it disabled.
      
      There's no reason that the field tracing_graph_pause on the task_struct can
      not be initialized at boot up.
      
      Cc: stable@vger.kernel.org
      Fixes: 380c4b14 ("tracing/function-graph-tracer: append the tracing_graph_flag")
      Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=211339
      Reported-by: pierre.gondois@arm.com
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      7e0a9220
  3. 25 Jan, 2021 1 commit
  4. 24 Jan, 2021 21 commits