1. 20 Dec, 2006 1 commit
    • Venkatesh Pallipadi's avatar
      kref refcnt and false positives · f334b60b
      Venkatesh Pallipadi authored
      With WARN_ON addition to kobject_init()
      [ http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/dont-use/broken-out/gregkh-driver-kobject-warn.patch ]
      
      I started seeing following WARNING on CPU offline followed by online on my
      x86_64 system.
      
      WARNING at lib/kobject.c:172 kobject_init()
      
      Call Trace:
       [<ffffffff8020ab45>] dump_trace+0xaa/0x3ef
       [<ffffffff8020aec4>] show_trace+0x3a/0x50
       [<ffffffff8020b0f6>] dump_stack+0x15/0x17
       [<ffffffff80350abc>] kobject_init+0x3f/0x8a
       [<ffffffff80350be1>] kobject_register+0x1a/0x3e
       [<ffffffff803bbd89>] sysdev_register+0x5b/0xf9
       [<ffffffff80211d0b>] mce_create_device+0x77/0xf4
       [<ffffffff80211dc2>] mce_cpu_callback+0x3a/0xe5
       [<ffffffff805632fd>] notifier_call_chain+0x26/0x3b
       [<ffffffff8023f6f3>] raw_notifier_call_chain+0x9/0xb
       [<ffffffff802519bf>] _cpu_up+0xb4/0xdc
       [<ffffffff80251a12>] cpu_up+0x2b/0x42
       [<ffffffff803bef00>] store_online+0x4a/0x72
       [<ffffffff803bb6ce>] sysdev_store+0x24/0x26
       [<ffffffff802baaa2>] sysfs_write_file+0xcf/0xfc
       [<ffffffff8027fc6f>] vfs_write+0xae/0x154
       [<ffffffff80280418>] sys_write+0x47/0x6f
       [<ffffffff8020963e>] system_call+0x7e/0x83
      DWARF2 unwinder stuck at system_call+0x7e/0x83
      Leftover inexact backtrace:
      
      This is a false positive as mce.c is unregistering/registering sysfs
      interfaces cleanly on hotplug.
      
      kref_put() and conditional decrement of refcnt seems to be the root cause
      for this and the patch below resolves the issue for me.
      Signed-off-by: default avatarVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      
      f334b60b
  2. 19 Dec, 2006 1 commit
  3. 18 Dec, 2006 26 commits
  4. 17 Dec, 2006 10 commits
  5. 16 Dec, 2006 2 commits
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband · c7ef259b
      Linus Torvalds authored
      * 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband:
        IB/mthca: Use DEFINE_MUTEX() instead of mutex_init()
        IB/mthca: Add HCA profile module parameters
        IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G
        IB: Fix ib_dma_alloc_coherent() wrapper
      c7ef259b
    • Linus Torvalds's avatar
      Merge branch 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev · 99f5e971
      Linus Torvalds authored
      * 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev:
        [PATCH] pata_via: Cable detect error
        [PATCH] Fix help text for CONFIG_ATA_PIIX
        [PATCH] initializer entry defined twice in pata_rz1000
        [PATCH] ata: fix platform_device_register_simple() error check
        [PATCH] ahci: do not mangle saved HOST_CAP while resetting controller
        [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE (take #2)
        [libata] sata_svw: Disable ATAPI DMA on current boards (errata workaround)
        [libata] use kmap_atomic(KM_IRQ0) in SCSI simulator
        [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
        [PATCH] ata_piix: IDE mode SATA patch for Intel ICH9
      99f5e971