Skip to content

L
linux
Switch branch/tag
  1. 01 Aug, 2013 1 commit
    • Julius Werner's avatar
      usb: core: don't try to reset_device() a port that got just disconnected · f3e94aa1
      Julius Werner authored 
      The USB hub driver's event handler contains a check to catch SuperSpeed
devices that transitioned into the SS.Inactive state and tries to fix
them with a reset. It decides whether to do a plain hub port reset or
call the usb_reset_device() function based on whether there was a device
attached to the port.

However, there are device/hub combinations (found with a JetFlash
Transcend mass storage stick (8564:1000) on the root hub of an Intel
LynxPoint PCH) which can transition to the SS.Inactive state on
disconnect (and stay there long enough for the host to notice). In this
case, above-mentioned reset check will call usb_reset_device() on the
stale device data structure. The kernel will send pointless LPM control
messages to the no longer connected device address and can even cause
several 5 second khubd stalls on some (buggy?) host controllers, before
finally accepting the device's fate amongst a flurry of error messages.

This patch makes the choice of reset dependent on the port status that
has just been read from the hub in addition to the existence of an
in-kernel data structure for the device, and only proceeds with the more
extensive reset if both are valid.
Signed-off-by: default avatarJulius Werner <jwerner@chromium.org>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f3e94aa1
  3. 29 Jul, 2013 7 commits
  5. 26 Jul, 2013 28 commits
  7. 25 Jul, 2013 4 commits
    • Olof Johansson's avatar
      mfd: max8925: fix dt code for backlight · 515c0967
      Olof Johansson authored 
      The device-tree enablement for max8925 has several problems, but besides
the bindings being wrong (and not having seen review) there's also some
bad coding practices on how to fill in the platform_data from device tree.

I came across this since it causes a warning when compiling
mmp2_defconfig, and instead of doing the minimal fix to silence the
warning, I restructured the code a bit.

This silences the warning:
drivers/video/backlight/max8925_bl.c: In function 'max8925_backlight_probe':
drivers/video/backlight/max8925_bl.c:177:3: warning: statement with no effect [-Wunused-value]

Note that the bindings themselves need to be revisited too, but that will
affect more than just the backlight driver and is best done separately;
this just fixes the bad code for the backlight driver.
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
      515c0967
    • Alex Deucher's avatar
      drm/radeon/dpm: fix displaygap programming on rv6xx · 2333a003
      Alex Deucher authored 
      Need to use the driver state rather than the register
state since the displays may not be enabled when the
power state is programmed.
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      2333a003
    • Alex Deucher's avatar
      drm/radeon/dpm: fix a typo in the rv6xx mclk setup · e3c736fe
      Alex Deucher authored 
      Need to set high for the last two entries.  Looks
like a copy and paste typo.
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      e3c736fe
    • Chen Wang's avatar
      USB: usb-skeleton.c: add retry for nonblocking read · 140983c2
      Chen Wang authored 
      Updated skel_read() in usb-skeleton.c. When there is no data in the
buffer, we would allow retry for both blocking and nonblocking cases.
Original logic give retry only for blocking case. Actually we can also
allow retry for nonblocking case. This will reuse the existing retry
logic and handle the return of -EAGAIN in one place. Also if the data to
be read is short and can be retrieved in quick time, we can also give a
chance for nonblocking case and may catch the data and copy it back to
userspace in one read() call too.
Signed-off-by: default avatarChen Wang <unicornxx.wang@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      140983c2
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7