- 20 Aug, 2014 5 commits
-
-
Namhyung Kim authored
Factor out duplicate callchain printing code into the hist_browser__ show_callchain_entry(). Signed-off-by:
Namhyung Kim <namhyung@kernel.org> Cc: Andi Kleen <andi@firstfloor.org> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung.kim@lge.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1408522080-26556-3-git-send-email-namhyung@kernel.orgSigned-off-by:
Arnaldo Carvalho de Melo <acme@redhat.com>
-
Namhyung Kim authored
When perf report runs on TUI, 'P' key dumps current screen to a file but it incorrectly displayed children overhead (as same of self overhead). This was because it fetched the value from self stats. Signed-off-by:
-
Namhyung Kim authored
It seems that the 'remaining' variable is not used by any real code. Signed-off-by:
-
Sukadev Bhattiprolu authored
Looks like util/debug.h was indirectly included before and is no longer included now. pr_debug is left undefined and the build of perf tool fails on Powerpc. Explicitly include util/debug.h. Signed-off-by:
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> Acked-by:
Jiri Olsa <jolsa@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Michael Ellerman <michaele@au1.ibm.com> Link: http://lkml.kernel.org/r/20140807072700.GA17623@us.ibm.comSigned-off-by:
-
Don Zickus authored
We are seeing a lot of the following with regards to SYSV memory Failed to open /SYSV0000279c, continuing without symbols We don't believe this memory will have DSO info, so treat it like the heap and stack for now and skip it to prevent the warning. Signed-off-by:
Don Zickus <dzickus@redhat.com> Signed-off-by:
Joe Mario <jmario@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Joe Mario <jmario@redhat.com> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1408501874-244377-1-git-send-email-dzickus@redhat.comSigned-off-by:
-
- 18 Aug, 2014 1 commit
-
-
Ingo Molnar authored
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo: User visible changes: * Warn user to rebuild target with debuginfo in 'perf probe' (Masami Hiramatsu) * Don't truncate Intel style addresses in 'annotate'. (Alex Converse) Infrastructure changes: * Annotate PMU related list_head members with type info. (Cody P Schafer) * Add the triplet used for arm64 by Android (Elliott Hughes) * Replace thread unsafe strerror() with strerror_r() accross the whole tools/perf/ tree (Masami Hiramatsu) Signed-off-by:
Ingo Molnar <mingo@kernel.org>
-
- 15 Aug, 2014 18 commits
-
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error message for thread-safety. Signed-off-by:
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Naohiro Aota <naota@elisp.net> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20140814022255.3545.81549.stgit@kbuild-fedora.novalocalSigned-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error messages for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error messages for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error messages for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error message for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error messages for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error messages for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error message for thead-safety. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error message for thread-safety. Signed-off-by:
-
Masami Hiramatsu authored
Replaces all strerror with strerror_r in util for making the perf lib thread-safe. Signed-off-by:
-
Masami Hiramatsu authored
To make error messages thread-safe, this replaces strerror with strerror_r for warnings, and just shows the return value instead of using strerror for debug messages. Signed-off-by:
-
Masami Hiramatsu authored
Use strerror_r instead of strerror in error messages for thread-safety. This also introduce STRERR_BUFSIZE macro for the default size of message buffer for strerror_r. Signed-off-by:
-
Masami Hiramatsu authored
Since the strlist__add doesn't involves any IO, the failure reason must be ENOMEM or EINVAL, moreover this is just a debug message, we don't need to show the error string. And also, if get_probe_trace_command_rawlist() returns NULL, it doesn't mean the rawlist is empty, there is an error. So caller must use -ENOMEM for the error. Signed-off-by:
-
Namhyung Kim authored
Current perf report -g/--call-graph option parser requires for option argument having following order: type,min_percent[,print_limit],order,key But sometimes it's annoying to type all even if one just wants to change the "order" or "key" setting. This patch fixes it to remove the ordering restriction so that one can use just "-g caller", for instance. The only remaining restriction is that the "print_limit" always comes after the "min_percent". Signed-off-by:
-
Cody P Schafer authored
So that we can more readily understand in which list heads structs are stored into. Signed-off-by:
Cody P Schafer <cody@linux.vnet.ibm.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com> Cc: Cody P Schafer <dev@codyps.com> Cc: Haren Myneni <hbabu@us.ibm.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Michael Ellerman <michaele@au1.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: linuxppc-dev@lists.ozlabs.org Link: http://lkml.kernel.org/r/1408087583-32239-6-git-send-email-sukadev@linux.vnet.ibm.comSigned-off-by:
-
Elliott Hughes authored
Adds the triplet used for arm64 by Android. Others will want to add their own later. Signed-off-by:
Elliott Hughes <enh@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20140814193920.A7D2D20572@enh.mtv.corp.google.comSigned-off-by:
-
Alex Converse authored
Instructions like "mov r9,QWORD PTR [rdx+0x8]" were being truncated to "mov r9,QWORD" by code that assuemd operands cannot have spaces. Signed-off-by:
Alex Converse <aconverse@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1408050180-14088-1-git-send-email-aconverse@google.comSigned-off-by:
-
Masami Hiramatsu authored
Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports the failure, but it's no hint for users. This gives more hint for users. Without this: $ strip perf $ ./perf probe -x perf -L argv_split Failed to open debuginfo file. Error: Failed to show lines. With this: $ strip perf $ ./perf probe -x perf -L argv_split The /home/fedora/ksrc/linux-3/tools/perf/perf file has no debug information. Rebuild with -g, or install an appropriate debuginfo package. Error: Failed to show lines. The "rebuild with ..." part changes to "rebuild with CONFIG_DEBUG_INFO" if the target is the kernel or a kernel module. Suggested-by:Arnaldo Carvalho de Melo <acme@kernel.org> Signed-off-by:
-
- 14 Aug, 2014 1 commit
-
-
Ingo Molnar authored
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core Pull perf/probe fixes and improvements from Arnaldo Carvalho de Melo: User visible changes: * Do not show +/- callchain expansion when there are no childs (top/report) (Namhyung Kim) * Fix -z and add respective 'z' hotkey to zero samples before refresh in 'perf top' (Namhyung Kim) * Capability probing fixes, improving the detection of kernel features for non-priviledged users (Adrian Hunter) * Add beautifier for mremap flags param in 'trace' (Alex Snast) * Fix --list and --del options to show events when just uprobes is enabled (Masami Hiramatsu) * perf script: Allow callchains if any event samples them * Don't look for kernel idle symbols in all DSOs in 'perf top' (Arnaldo Carvalho de Melo) * Add cpu_startup_entry to the list of kernel idle symbols (Arnaldo Carvalho de Melo) * 'perf top' terminal output fixes (Jiri Olsa) * Fix stdin handling for 'perf kvm stat live' (Jiri Olsa) * Fix missing label symbols (Adrian Hunter) * Don't demangle C++ parameters and such by default, only in --verbose mode (Namhyung Kim) * Set proper sort__mode for the branch option (Naohiro Aota) * Check recorded kernel version when finding vmlinux (Namhyung Kim) Infrastructure changes: * More prep work for intel PT (Adrian Hunter) * Fix possible memory leaks (Namhyung Kim) * Fix a memory leak in vmlinux_path__init() (Namhyung Kim) Signed-off-by:
-
- 13 Aug, 2014 15 commits
-
-
Adrian Hunter authored
Add a function to enable a specific event within a specific perf event buffer. Signed-off-by:
Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1406786474-9306-14-git-send-email-adrian.hunter@intel.comSigned-off-by:
-
Adrian Hunter authored
The flags will be used to export branch type and transaction status. insn_len is preparation for pairing calls and returns because the return address equals the call address plus the instruction length (insn_len). Signed-off-by:
-
Adrian Hunter authored
Add machine__thread_exec_comm() to return the comm that matches the last exec, if the comm_exec flag is present, or the last comm otherwise. Signed-off-by:
-
Adrian Hunter authored
For grouping together all the data from a single execution, which is needed for pairing calls and returns e.g. any outstanding calls when a process exec's will never return. Signed-off-by:
-
Adrian Hunter authored
The Python script API repeatedly uses the same lines of code to get and call objects. Make that into helper functions instead. A side-effect is that some reference counting bugs disappear because the new call_object() function always decrements the reference count of 'retval'. Signed-off-by:
-
Adrian Hunter authored
perf script was not displaying callchains if any selected event did not have PERF_SAMPLE_CALLCHAIN. Change this to disable callchains only if all selected events do not have PERF_SAMPLE_CALLCHAIN. Signed-off-by:
-
Adrian Hunter authored
Add a function to peek at other events in the event stream. Signed-off-by:
-
Adrian Hunter authored
Add a function to change which event is used to track mmap, comm and task events. This is needed with Instruction Tracing because the Instruction Tracing event must come first but cannot be used for tracking because it will be disabled under some circumstances. Signed-off-by:
-
Adrian Hunter authored
Add an option to cause a selected event to be opened always without a pid when configured by perf_evsel__config(). This is needed when using the sched_switch tracepoint to follow object code execution. sched_switch occurs before the task switch and so it cannot record it in a context limited to that task. Note that also means that sched_switch is useless when capturing data per-thread, as is the 'context-switches' software event for the same reason. Signed-off-by:
-
Adrian Hunter authored
Label symbols are missing because elf_sec__is_a() fails to find the section because the section strings do not match the section headers because the sections headers are from the 'runtime' object and the sections strings are from the 'symbol source' object. Fix by getting the section strings from the 'runtime' object so that they match the section headers. Signed-off-by:
-
Namhyung Kim authored
Some C++ symbols have very long name and they make column length longer. Most of them are about parameters including templates and we can ignore such info most of time IMHO. This patch passes DMGL_NO_OPTS by default when calling bfd_demangle(). One can still see full symbols with -v/--verbose option. before: JS_CallFunctionValue(JSContext*, JSObject*, JS::Value, unsigned int, JS::Value*, JS::Value*) after: JS_CallFunctionValue Signed-off-by:
-
Namhyung Kim authored
The perf top TUI lacks 'z' key support to toggle sample zeroing. Add it. Reported-by:
Stephane Eranian <eranian@google.com> Tested-by:
-
Namhyung Kim authored
The current -z option does almost nothing. It doesn't zero the existing samples so that we can see profiles of exited process after last refresh. It seems it only affects annotation. This patch clears existing entries before processing if -z option is given. For this original decaying logic also moved before processing. Reported-by:
-
naota@elisp.net authored
When you specify "--branch-stack"("-b" for short) or "--no-branch-stack", "branch_mode" variable is set to 1 or 0 respectively. However, the code is just checking if the variable is -1 or not, ignoring "branch_mode == 1" case. Thus "perf report -b" dose not show its result with the branch sorted mode. This patch fix the problem. Signed-off-by:Naohiro Aota <naota@elisp.net> Acked-by:
-
Namhyung Kim authored
The currently when perf TUI report shows callchain, the first level chains have bogus '+' sign even though only the last one has children. Since they are on a single line of the chain, toggling intermediate entries has no effect. Fix it to show '+' sign at the last entry only. Note that non-first level callchain entries don't have this problem. Before: --------------------------------------------------------------------------- Children Self Command Shared Object Symbols - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter + cpuidle_wrap_enter + cpuidle_enter_tk + cpuidle_idle_call + cpu_idle After: --------------------------------------------------------------------------- Children Self Command Shared Object Symbols - 40.70% 0.00% swapper [kernel.kallsyms] [k] cpuidle_wrap_enter cpuidle_wrap_enter cpuidle_enter_tk cpuidle_idle_call + cpu_idle Signed-off-by:
-
