- 16 Feb, 2023 23 commits
-
-
Jonathan Gray authored
When building on OpenBSD/arm64 with clang 15, unaligned access warnings are seen when a union is embedded inside a packed struct. drm/amd/pm/powerplay/hwmgr/vega20_pptable.h:136:17: error: field smcPPTable within 'struct _ATOM_VEGA20_POWERPLAYTABLE' is less aligned than 'PPTable_t' and is usually due to 'struct _ATOM_VEGA20_POWERPLAYTABLE' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] PPTable_t smcPPTable; ^ Make PPTable_t packed to avoid this. Signed-off-by:Jonathan Gray <jsg@jsg.id.au> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Jonathan Gray authored
When building on OpenBSD/arm64 with clang 15, unaligned access warnings are seen when a union is embedded inside a packed struct. drm/amd/display/dmub/inc/dmub_cmd.h:941:18: error: field cursor_copy_src within 'struct dmub_rb_cmd_mall' is less aligned than 'union dmub_addr' and is usually due to 'struct dmub_rb_cmd_mall' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] union dmub_addr cursor_copy_src; /**< Cursor copy address */ ^ drm/amd/display/dmub/inc/dmub_cmd.h:942:18: error: field cursor_copy_dst within 'struct dmub_rb_cmd_mall' is less aligned than 'union dmub_addr' and is usually due to 'struct dmub_rb_cmd_mall' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] union dmub_addr cursor_copy_dst; /**< Cursor copy destination */ ^ Add pragma pack around dmub_addr to avoid this. Signed-off-by: -
Deepak R Varma authored
Remove duplicate or repeating expressions in the if condition evaluation. Issue identified using doubletest.cocci Coccinelle semantic patch. Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
Deepak R Varma <drv@mailo.com> Signed-off-by:
-
Deepak R Varma authored
Remove duplicate or repeating expressions in the if condition evaluation. Issue identified using doubletest.cocci Coccinelle semantic patch. Reviewed-by:
-
Arthur Grillo authored
Make variables declaration inside ifdef guard, as they are only used inside the same ifdef guard. This remove some of the -Wunused-but-set-variable warning. Signed-off-by:
Arthur Grillo <arthurgrillo@riseup.net> Signed-off-by:
-
Arthur Grillo authored
Remove arguments present on kernel-doc that are not present on the function declaration and add the new ones if present. Signed-off-by:
-
Arthur Grillo authored
Add includes that were previously missing to reduce the number of -Wmissing-prototypes warnings. Signed-off-by:
-
Arthur Grillo authored
Add function prototypes to headers to reduce the number of -Wmissing-prototypes warnings. Signed-off-by:
-
Arthur Grillo authored
Add function prototypes to headers to reduce the number of -Wmissing-prototypes warnings. Signed-off-by:
-
Arthur Grillo authored
Turn global functions that are only used locally into static ones. This reduces the number of -Wmissing-prototypes warnings. Signed-off-by:
-
Melissa Wen authored
We don't use this function anywhere, therefore, remove it. Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Melissa Wen <mwen@igalia.com> Signed-off-by:
-
Melissa Wen authored
The function resource_validate_ctx_update_pointer_after_copy() is declared in resource.h but never defined, therefore, remove its declaration from headers. Reviewed-by:
-
Melissa Wen authored
In mod_color_calculate_{degamma/regamma}_params(), a tf variable is initialized as TRANSFER_FUNCTION_SRGB but tf is only used after tf = input->tf, therefore, better to just remove this initial value and avoid misleading interpretations. Reviewed-by: -
Melissa Wen authored
Rename mapUserRamp to map_user_ramp and doClamping to do_clamping Reviewed-by:
-
Lijo Lazar authored
Only Navi1x requires dummy read workaround. Allocate the table in VRAM only for Navi1x. Signed-off-by:
Lijo Lazar <lijo.lazar@amd.com> Acked-by:
-
Qingqing Zhuo authored
This reverts commit d47d2f93. regression detected by the change. Revert until fix is available. Signed-off-by:
Qingqing Zhuo <qingqing.zhuo@amd.com> Reviewed-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
-
Aric Cyr authored
This version brings along the following: - Move domain power control to DMCUB for DCN314 - Enable P-state validation check for DCN314 - Add support for multiple overlay planes - Fixes in prefetch, k1 k2 divider programming and more - Code cleanup Acked-by:
Aric Cyr <aric.cyr@amd.com> Tested-by:
Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by:
-
Ayush Gupta authored
This reverts a part of the commit 826e7ffa ("drm/amd/display: [FW Promotion] Release 0.0.153.0") Reviewed-by:
Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com> Acked-by:
-
Mustapha Ghaddar authored
[WHY & HOW] - make link_dp_dpia_bw.c available for linux. - add the verify link peak bw - clean up code and comment format. Reviewed-by:
Jun Lei <Jun.Lei@amd.com> Acked-by:
Mustapha Ghaddar <mghaddar@amd.com> Tested-by:
-
Nicholas Kazlauskas authored
[Why] The DMCUB implementation required to workaround corruption is not currently stable and may cause intermittent corruption or hangs. [How] Disable PG until the sequence is stable. Reviewed-by:
Hansen Dsouza <hansen.dsouza@amd.com> Acked-by:
-
Melissa Wen authored
This function has many conditions and all code style issues (identation, missing braces, etc.) make reading it really annoying. Reviewed-by:
-
Melissa Wen authored
Reviewed-by:
-
Jack Xiao authored
Freeing memory was warned during suspend. Move the self test out of suspend. Link: https://bugzilla.redhat.com/show_bug.cgi?id=2151825 Cc: jfalempe@redhat.com Signed-off-by:
Jack Xiao <Jack.Xiao@amd.com> Reviewed-by:
Feifei Xu <Feifei.Xu@amd.com> Reviewed-and-tested-by:
Evan Quan <evan.quan@amd.com> Tested-by:
Jocelyn Falempe <jfalempe@redhat.com> Signed-off-by:
-
- 14 Feb, 2023 17 commits
-
-
Bhawanpreet Lakha authored
[Why] We only allowed 1 overlay plane. But now some ASICS can support multiple overlay planes. [How] Use max_slave_planes as the number of overlays we can support. Also since we cannot draw cursor over a video plane, we need to make sure that we reject commits where the topmost plane is a video plane (overlay only). Reviewed-by:
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Tested-by:
-
Wenjing Liu authored
[why] Link is a subcomponent in dc. DM should be aware of dc link structure as one of the abstracted objects maintained by dc. However it should have no idea of the existence of a link component in dc dedicated to maintain the states of dc link structure. As such we are moving link interfaces out of dc_link.h and directly added to dc.h. We are grandually fading out the explicit inclusion of dc_link header and eventually delete it. On dc side, since link is a subcomponent behind dc interfaces, it is not a good idea to implement dc interfaces in each individual subcomponent of link which is already a subcomponent of dc. So we are decoupling it by implementing a dc_link_exports in dc. This file will be a thin translation layer that breaks the dependency so link is able to make interface changes without breaking DM. Reviewed-by:
Wenjing Liu <wenjing.liu@amd.com> Tested-by:
-
Nicholas Kazlauskas authored
[Why] Request from HW team to update the latencies to the new measured values. [How] Update the values in the bounding box. Reviewed-by:
Charlene Liu <Charlene.Liu@amd.com> Acked-by:
-
Leo (Hanghong) Ma authored
[Why] The FreeSync active bit unconditionally set in HDMI VSIF. [How] Set this bit to true when FAMS is enable on desktop. Reviewed-by:
Felipe Clark <felipe.clark@amd.com> Acked-by:
Leo (Hanghong) Ma <hanghong.ma@amd.com> Tested-by:
-
Nasir Osman authored
[why] HUBP_UNBOUNDED_REQ_MODE being enabled while the display is rotated (eg. going from Portrait mode to Landscape mode) appears to be causing a p-state hang, specifically during full screen mode on the Tiktok PC app. Unbounded request mode doesn't appear to be supported with rotation configs, hence disabling it. [how] Within DML, modified unbounded request mode to be configured only when the rotation angle of the plane is 0. Reviewed-by:
-
Yifan Zha authored
[Why] Regression of commit 72fef498 ("drm/amdgpu: Remove writing GRBM_GFX_CNTL in RLCG interface under SRIOV") on GFX9. According to GFX9 VF using different method to access GC registers including MMIO(direct) and RLCG(indirect), removing GRBM_GFX_* writing would make PIPE/ME/VM/QUEUE selection chaos leading to some OCL benchmark failure. For example, using RLCG interface to program GRBM_GFX_CNTL/INDEX for selecting MEC(actually the value is only in scratch2/3), then using MMIO directly program a MEC register in VF driver. The register programming are invalid due to GC switched to incorrect ME. [How] With checking RLCG accessing flag, keep writing GRBM_GFX_* as a legacy way. But it is still skipped on GFX10+ to avoid violation occurrence. Signed-off-by:
Yifan Zha <Yifan.Zha@amd.com> Reviewed-by:
Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by:
-
Jiapeng Chong authored
Variable pre_connection_type is not effectively used, so delete it. Reported-by:
Abaci Robot <abaci@linux.alibaba.com> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4031Signed-off-by:
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Signed-off-by:
-
Jiapeng Chong authored
Variable ds_port is not effectively used, so delete it. drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:280:35: warning: variable ‘ds_port’ set but not used. Reported-by:
-
Nasir Osman authored
[why] Newer ASICs such as DCN314 needs to allow for both self refresh and mem clk switching rather than just self refresh only. Otherwise, we can see some p-state hangs on ASICs that do support mem clk switching. [how] Added an allow_self_refresh_only flag for dcn30_internal_validate_bw and created a validate_bw method for DCN314 with the allow_self_refresh_only flag set to false (to support mem clk switching). Reviewed-by:
Nasir Osman <nasir.osman@amd.com> Tested-by:
-
Tom Chung authored
[Why] Dmub will cache the video position data during PSR-SU enable. The dmub will use an outdated MPO video position if user try to drag the video window and it will cause video glitch. [How] Disable the PSR-SU temporarily while user drag the video window. The PSR-SU will be re-enabled after the video window is stable. Reviewed-by:
Sun peng Li <Sunpeng.Li@amd.com> Acked-by:
Tom Chung <chiahsuan.chung@amd.com> Tested-by:
-
Yang Li authored
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:145 get_ddc_line() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:201 dc_link_construct_phy() warn: inconsistent indenting Reported-by:
Yang Li <yang.lee@linux.alibaba.com> Signed-off-by:
-
Yang Li authored
./drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c:1610:68-73: WARNING: conversion to bool not needed here Reported-by:
-
Charlene Liu authored
[Why] In virtual link use case, link->ddc could be NULL. [How] Add null pointer check to avoid undefined behavior. Reviewed-by:
Martin Leung <Martin.Leung@amd.com> Reviewed-by:
-
Wenjing Liu authored
[why] We mistakenly toggle dpms state for non master pipe when handling link lost. A non master pipe doesn't connect to a backend. So it is toggling dpms for non master is undefined and caused NULL pointer dereference. [how] Add helper functions to find an array of active master pipes for current link and only toggle DPMS for active master pipes connected to the link. Add assert in case we get called to program dpms with non master pipe. Reviewed-by:
Alvin Lee <Alvin.Lee2@amd.com> Acked-by:
-
Wenjing Liu authored
[why] A recent change was made to implement temporary workaround due DRM update in MST interfaces. The workaround is added into our generic deallocation MST sequence. This ticket is to extract this temporary workaround into its own function so it is differentiated from our generic sequence. Reviewed-by:
Jerry Zuo <Jerry.Zuo@amd.com> Acked-by:
-
Samson Tam authored
[Why] In disable_dangling_plane, for phantom pipes, we enable OTG so disable programming gets the double buffer update. But this causes an underflow to occur. [How] Enable DPG prior to enabling OTG. Reviewed-by:
Samson Tam <samson.tam@amd.com> Tested-by:
-
Daniel Miess authored
This reverts commit f5df7725 [Why] This commit causes corruption when viewing a P010 video clip on a 300Hz eDP Reviewed-by:
Daniel Miess <Daniel.Miess@amd.com> Tested-by:
-
