1. 03 Sep, 2014 40 commits
    • Hans Verkuil's avatar
      [media] s2255drv: fix sparse warning · ff3ec57d
      Hans Verkuil authored
      drivers/media/usb/s2255/s2255drv.c:2248:20: warning: cast to restricted __le16
      
      At the USB structs there are two different idProduct:
      	usb_device_id::idProduct - already on CPU endiannes
      	usb_device::descriptor.idProduct - with is LE16
      
      In this specific case, the driver checks for the one at usb_device_id
      struct, with already have CPU endianness. So, no conversion is required.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      ff3ec57d
    • Hans Verkuil's avatar
      [media] bcm3510: fix sparse warnings · fba16a1e
      Hans Verkuil authored
      drivers/media/dvb-frontends/bcm3510.c:646:24: warning: cast to restricted __le16
      drivers/media/dvb-frontends/bcm3510.c:647:24: warning: cast to restricted __le16
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      fba16a1e
    • Hans Verkuil's avatar
      [media] wl128x: fix sparse warnings · 2a8b7e58
      Hans Verkuil authored
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:598:32: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:767:38: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:992:21: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:443:41: warning: incorrect type in assignment (different base types)
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1359:39: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:25: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_common.c:1368:47: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:119:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:192:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:288:28: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:534:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_rx.c:625:17: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      drivers/media/radio/wl128x/fmdrv_tx.c:377:20: warning: cast to restricted __be16
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      2a8b7e58
    • Hans Verkuil's avatar
      [media] mantis: fix sparse warnings · 967a3783
      Hans Verkuil authored
      drivers/media/pci/mantis/hopper_vp3028.c:37:23: warning: symbol 'hopper_vp3028_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1033.c:38:4: warning: symbol 'lgtdqcs001f_inittab' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1033.c:153:23: warning: symbol 'lgtdqcs001f_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1034.c:39:23: warning: symbol 'vp1034_mb86a16_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1041.c:266:23: warning: symbol 'vp1041_stb0899_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp1041.c:303:23: warning: symbol 'vp1041_stb6100_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2033.c:40:24: warning: symbol 'vp2033_tda1002x_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2033.c:45:24: warning: symbol 'vp2033_tda10023_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2040.c:40:24: warning: symbol 'vp2040_tda1002x_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp2040.c:45:24: warning: symbol 'vp2040_tda10023_cu1216_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp3030.c:38:23: warning: symbol 'mantis_vp3030_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_vp3030.c:42:23: warning: symbol 'env57h12d5_config' was not declared. Should it be static?
      drivers/media/pci/mantis/mantis_dma.c:167:33: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:172:33: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:174:25: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:178:9: warning: incorrect type in assignment (different base types)
      drivers/media/pci/mantis/mantis_dma.c:179:9: warning: incorrect type in assignment (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      967a3783
    • Hans Verkuil's avatar
      [media] mb86a16/mb86a20s: fix sparse warnings · ce08131c
      Hans Verkuil authored
      drivers/media/dvb-frontends/mb86a16.c:31:14: warning: symbol 'verbose' was not declared. Should it be static?
      drivers/media/dvb-frontends/mb86a20s.c:36:4: warning: symbol 'mb86a20s_subchannel' was not declared. Should it be static?
      drivers/media/dvb-frontends/mb86a20s.c:1333:24: warning: symbol 'cnr_qpsk_table' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      ce08131c
    • Hans Verkuil's avatar
      [media] usbtv: fix sparse warnings · 6fbf4d04
      Hans Verkuil authored
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:285:14: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:287:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:288:15: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      drivers/media/usb/usbtv/usbtv-video.c:289:20: warning: cast to restricted __be32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      6fbf4d04
    • Hans Verkuil's avatar
      [media] uvc: fix sparse warning · d71b0b34
      Hans Verkuil authored
      drivers/media/usb/uvc/uvc_video.c:1466:38: warning: incorrect type in return expression (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      d71b0b34
    • Hans Verkuil's avatar
      [media] drxj: fix sparse warnings · 4182438e
      Hans Verkuil authored
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11768:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11770:25: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11794:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11796:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11798:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11800:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11605:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11632:29: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11650:34: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11652:34: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11654:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11656:33: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11670:35: warning: cast to restricted __be16
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11678:47: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11680:46: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      drivers/media/dvb-frontends/drx39xyj/drxj.c:11682:51: warning: cast to restricted __be32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      4182438e
    • Hans Verkuil's avatar
      [media] ngene: fix sparse warnings · c463c979
      Hans Verkuil authored
      drivers/media/pci/ngene/ngene-core.c:188:27: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:190:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:199:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:260:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:263:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:282:32: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:283:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:284:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:285:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:286:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:287:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:288:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:292:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:293:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:294:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:295:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:296:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:297:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:303:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:316:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:368:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:372:9: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1160:28: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1199:20: warning: incorrect type in assignment (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1213:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1214:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1223:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1225:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1227:31: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1296:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1297:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1298:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1299:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1300:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1301:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1302:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1363:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1365:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1376:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1391:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-core.c:1596:18: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-core.c:1615:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-cards.c:699:29: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-cards.c:699:32: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-cards.c:699:35: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-cards.c:699:38: warning: Using plain integer as NULL pointer
      drivers/media/pci/ngene/ngene-dvb.c:84:59: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ngene/ngene-dvb.c:93:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ngene/ngene-dvb.c:94:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ngene/ngene-dvb.c:100:20: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      c463c979
    • Hans Verkuil's avatar
      [media] ddbridge: fix sparse warnings · b5c00cc5
      Hans Verkuil authored
      drivers/media/pci/ddbridge/ddbridge-core.c:88:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:93:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:95:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:99:15: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:117:58: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:119:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:123:68: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:130:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:131:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:136:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:138:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:152:22: warning: symbol 'ddb_i2c_algo' was not declared. Should it be static?
      drivers/media/pci/ddbridge/ddbridge-core.c:183:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:184:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:246:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:247:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:255:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:256:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:269:35: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:358:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:359:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:360:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:362:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:366:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:368:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:369:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:370:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:380:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:381:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:393:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:394:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:395:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:396:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:397:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:401:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:403:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:404:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:406:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:416:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:417:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:475:36: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:484:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:494:20: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:501:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:524:36: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:534:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:852:21: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:973:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ddbridge/ddbridge-core.c:974:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
      drivers/media/pci/ddbridge/ddbridge-core.c:978:20: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:982:20: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:1003:23: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1006:23: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1009:30: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1015:25: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1017:39: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1035:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1041:20: warning: symbol 'cxd_cfg' was not declared. Should it be static?
      drivers/media/pci/ddbridge/ddbridge-core.c:1130:44: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:1183:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1188:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1193:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1198:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1213:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1214:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1215:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1216:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1231:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1232:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1233:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1289:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1333:23: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1295:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1347:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1353:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1354:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1359:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1361:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1373:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1374:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1378:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1382:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1385:17: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1386:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1388:24: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1393:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1394:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1395:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1398:16: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1399:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1451:42: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1462:45: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1467:37: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1538:28: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1550:9: warning: incorrect type in argument 2 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1561:31: warning: Using plain integer as NULL pointer
      drivers/media/pci/ddbridge/ddbridge-core.c:1585:19: warning: incorrect type in assignment (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1591:47: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1591:60: warning: incorrect type in argument 1 (different address spaces)
      drivers/media/pci/ddbridge/ddbridge-core.c:1607:9: warning: too many warnings
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      b5c00cc5
    • Hans Verkuil's avatar
      [media] kinect: fix sparse warnings · 6cde2904
      Hans Verkuil authored
      drivers/media/usb/gspca/kinect.c:151:19: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:152:19: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:153:19: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:191:13: warning: restricted __le16 degrades to integer
      drivers/media/usb/gspca/kinect.c:217:16: warning: incorrect type in assignment (different base types)
      drivers/media/usb/gspca/kinect.c:218:16: warning: incorrect type in assignment (different base types)
      
      Note that this fixes a real bug where cpu_to_le16 was used instead of the correct
      le16_to_cpu.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Acked-by: default avatarAntonio Ospite <ao2@ao2.it>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      6cde2904
    • Hans Verkuil's avatar
      [media] dib7000p: fix sparse warning · 18ef20da
      Hans Verkuil authored
      drivers/media/dvb-frontends/dib7000p.c:2562:5: warning: symbol 'dib7090_set_diversity_in' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      18ef20da
    • Hans Verkuil's avatar
      [media] go7007: fix sparse warnings · 616e3506
      Hans Verkuil authored
      drivers/media/usb/go7007/go7007-usb.c:699:30: warning: cast to restricted __le16
      drivers/media/usb/go7007/go7007-usb.c:769:38: warning: cast to restricted __le16
      drivers/media/usb/go7007/go7007-usb.c:770:39: warning: cast to restricted __le16
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      616e3506
    • Hans Verkuil's avatar
      [media] pctv452e: fix sparse warnings · ee40d32f
      Hans Verkuil authored
      drivers/media/usb/dvb-usb/pctv452e.c:886:64: warning: Using plain integer as NULL pointer
      drivers/media/usb/dvb-usb/pctv452e.c:903:63: warning: Using plain integer as NULL pointer
      drivers/media/usb/dvb-usb/pctv452e.c:968:19: warning: Using plain integer as NULL pointer
      drivers/media/usb/dvb-usb/pctv452e.c:1026:19: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      ee40d32f
    • Hans Verkuil's avatar
      [media] opera1: fix sparse warnings · 18d6a28a
      Hans Verkuil authored
      drivers/media/usb/dvb-usb/opera1.c:557:29: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/opera1.c:558:33: warning: restricted __le16 degrades to integer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      18d6a28a
    • Hans Verkuil's avatar
      [media] mxl111sf: fix sparse warnings · ed267165
      Hans Verkuil authored
      drivers/media/usb/dvb-usb-v2/mxl111sf.c:34:5: warning: symbol 'dvb_usb_mxl111sf_isoc' was not declared. Should it be static?
      drivers/media/usb/dvb-usb-v2/mxl111sf.c:38:5: warning: symbol 'dvb_usb_mxl111sf_spi' was not declared. Should it be static?
      drivers/media/usb/dvb-usb-v2/mxl111sf.c:46:5: warning: symbol 'dvb_usb_mxl111sf_rfswitch' was not declared. Should it be static?
      drivers/media/usb/dvb-usb-v2/mxl111sf.c:890:22: warning: symbol 'mxl111sf_i2c_algo' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      ed267165
    • Hans Verkuil's avatar
      [media] dw2102: fix sparse warnings · 1ad5d064
      Hans Verkuil authored
      drivers/media/usb/dvb-usb/dw2102.c:670:65: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1601:32: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1644:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1644:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1644:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1644:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1644:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1644:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dw2102.c:1904:34: warning: symbol 'p1100' was not declared. Should it be static?
      drivers/media/usb/dvb-usb/dw2102.c:1911:34: warning: symbol 's660' was not declared. Should it be static?
      drivers/media/usb/dvb-usb/dw2102.c:1930:34: warning: symbol 'p7500' was not declared. Should it be static?
      drivers/media/usb/dvb-usb/dw2102.c:1937:34: warning: symbol 's421' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      1ad5d064
    • Hans Verkuil's avatar
      [media] radio-tea5764: fix sparse warnings · 7754622b
      Hans Verkuil authored
      drivers/media/radio/radio-tea5764.c:168:24: warning: cast to restricted __be16
      drivers/media/radio/radio-tea5764.c:168:24: warning: cast to restricted __be16
      drivers/media/radio/radio-tea5764.c:168:24: warning: cast to restricted __be16
      drivers/media/radio/radio-tea5764.c:168:24: warning: cast to restricted __be16
      drivers/media/radio/radio-tea5764.c:185:20: warning: incorrect type in assignment (different base types)
      drivers/media/radio/radio-tea5764.c:186:20: warning: incorrect type in assignment (different base types)
      drivers/media/radio/radio-tea5764.c:187:20: warning: incorrect type in assignment (different base types)
      drivers/media/radio/radio-tea5764.c:188:20: warning: incorrect type in assignment (different base types)
      drivers/media/radio/radio-tea5764.c:189:20: warning: incorrect type in assignment (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      7754622b
    • Hans Verkuil's avatar
      [media] af9015: fix sparse warning · 74426324
      Hans Verkuil authored
      drivers/media/usb/dvb-usb-v2/af9015.c:422:38: warning: cast to restricted __le32
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      74426324
    • Hans Verkuil's avatar
      [media] dibusb: fix sparse warnings · b565e71d
      Hans Verkuil authored
      drivers/media/usb/dvb-usb/dibusb-common.c:261:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dibusb-common.c:262:52: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dibusb-common.c:300:40: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dibusb-common.c:301:44: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dibusb-common.c:313:47: warning: restricted __le16 degrades to integer
      drivers/media/usb/dvb-usb/dibusb-common.c:314:47: warning: restricted __le16 degrades to integer
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      b565e71d
    • Bartlomiej Zolnierkiewicz's avatar
      [media] v4l: vsp1: fix driver dependencies · 4bf167a3
      Bartlomiej Zolnierkiewicz authored
      Renesas VSP1 Video Processing Engine support should be available
      only on Renesas ARM SoCs.
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
      Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
      Cc: Simon Horman <horms@verge.net.au>
      Cc: Magnus Damm <magnus.damm@gmail.com>
      Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      4bf167a3
    • Jacek Anaszewski's avatar
      [media] s5p-jpeg: fix HUF_TBL_EN bit clearing path · 5da74fc6
      Jacek Anaszewski authored
      Use proper bitwise operator while clearing HUF_TBL_EN bit.
      Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      5da74fc6
    • Jacek Anaszewski's avatar
      [media] s5p-jpeg: avoid overwriting JPEG_CNTL register settings · d727ff42
      Jacek Anaszewski authored
      Take into account the JPEG_CNTL register value read before
      setting SYS_INT_EN bit field.
      Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      d727ff42
    • Jacek Anaszewski's avatar
      [media] s5p-jpeg: remove stray call to readl · 37a4bd75
      Jacek Anaszewski authored
      There is no need to read INT_EN_REG before enabling interrupts.
      Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      37a4bd75
    • Jacek Anaszewski's avatar
      [media] s5p-jpeg: Avoid assigning readl result · 0cd9b21e
      Jacek Anaszewski authored
      Avoid gcc warning when -Wunused-but-set-variable is enabled.
      The readl return value need not to be assigned to any variable
      as the reading itself is just a part of a sequence required
      for clearing the interrupt flag.
      Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      0cd9b21e
    • Marek Szyprowski's avatar
      [media] media: s5p-mfc: rename special clock to sclk_mfc · 0c227217
      Marek Szyprowski authored
      Commit d19f405a ("[media] s5p-mfc: Fix
      selective sclk_mfc init") added support for special clock handling
      (named "sclk-mfc"). However this clock is not defined yet on any
      platform, so before adding it to all Exynos platform, better rename it
      to "sclk_mfc" to match the scheme used for all other special clocks on
      Exynos platform.
      Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
      Acked-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      0c227217
    • Zhaowei Yuan's avatar
      [media] media: s5p-mfc: correct improper logs · e47ccb1d
      Zhaowei Yuan authored
      This patch corrects improper logs within the code initializing hardware.
      Signed-off-by: default avatarZhaowei Yuan <zhaowei.yuan@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      e47ccb1d
    • Zhaowei Yuan's avatar
      [media] media: s5p_mfc: Release ctx->ctx if failed to allocate ctx->shm · 6c5c680b
      Zhaowei Yuan authored
      ctx->ctx should be released if the following allocation for ctx->shm
      gets failed.
      Signed-off-by: default avatarZhaowei Yuan <zhaowei.yuan@samsung.com>
      Signed-off-by: default avatarKamil Debski <k.debski@samsung.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      6c5c680b
    • Hans Verkuil's avatar
      [media] solo6x10: fix sparse warnings · c44b6484
      Hans Verkuil authored
      drivers/media/pci/solo6x10/solo6x10-disp.c:184:24: warning: incorrect type in assignment (different base types)
      drivers/media/pci/solo6x10/solo6x10-disp.c:223:32: warning: incorrect type in assignment (different base types)
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      c44b6484
    • Hans Verkuil's avatar
      [media] img-ir: fix sparse warnings · 3ee733ea
      Hans Verkuil authored
      drivers/media/rc/img-ir/img-ir-nec.c:111:23: warning: symbol 'img_ir_nec' was not declared. Should it be static?
      drivers/media/rc/img-ir/img-ir-jvc.c:54:23: warning: symbol 'img_ir_jvc' was not declared. Should it be static?
      drivers/media/rc/img-ir/img-ir-sony.c:120:23: warning: symbol 'img_ir_sony' was not declared. Should it be static?
      drivers/media/rc/img-ir/img-ir-sharp.c:75:23: warning: symbol 'img_ir_sharp' was not declared. Should it be static?
      drivers/media/rc/img-ir/img-ir-sanyo.c:82:23: warning: symbol 'img_ir_sanyo' was not declared. Should it be static?
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      3ee733ea
    • Hans Verkuil's avatar
      [media] cx23885: remove FSF address as per checkpatch · 03105397
      Hans Verkuil authored
      These addresses are usually out-of-date and the top-level license will
      always have the right address. So drop it from these sources.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      03105397
    • Hans Verkuil's avatar
      [media] cx23885: use video_drvdata to get cx23885_dev pointer · 568f44a1
      Hans Verkuil authored
      Use video_drvdata(file) instead of fh->dev to get the cx23885_dev
      pointer. This prepares for the vb2 conversion where fh->dev (renamed
      to fh->q_dev in this patch) will be removed completely.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      568f44a1
    • Hans Verkuil's avatar
      [media] cx23885: drop videobuf abuse in cx23885-alsa · 9529a4b0
      Hans Verkuil authored
      The alsa driver uses videobuf low-level functions that are not
      available in vb2, so replace them by driver-specific functions.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      9529a4b0
    • Hans Verkuil's avatar
      [media] cx23885: fmt, width and height are global, not per-fh · 91d2d674
      Hans Verkuil authored
      Move these fields from cx23885_fh to cx23885_dev.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      91d2d674
    • Hans Verkuil's avatar
      [media] cx23885: drop unused clip fields from struct cx23885_fh · e749c6e6
      Hans Verkuil authored
      There is no overlay support, so drop these unused fields.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      e749c6e6
    • Hans Verkuil's avatar
      [media] cx23885: drop type field from struct cx23885_fh · 1f159c77
      Hans Verkuil authored
      This information is available elsewhere as well.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      1f159c77
    • Hans Verkuil's avatar
      [media] cx23885: drop radio-related dead code · 86961933
      Hans Verkuil authored
      Currently no radio device nodes are ever created, so remove the dead radio
      code.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      86961933
    • Hans Verkuil's avatar
      [media] cx23885: map invalid fields to a valid field · 200e0841
      Hans Verkuil authored
      If field format is not valid, map it as V4L2_FIELD_INTERLACED,
      instead of pretending to support an invalid format.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      200e0841
    • Hans Verkuil's avatar
      [media] cx23885: fix format colorspace compliance error · 1af2ddd8
      Hans Verkuil authored
      Fix v4l2-compliance failure relating to formatting.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      1af2ddd8
    • Hans Verkuil's avatar
      [media] cx23885: convert 417 to the control framework · 5150392c
      Hans Verkuil authored
      Convert the -417 source to the control framework as well.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
      5150392c