1. 26 Feb, 2016 5 commits
  2. 18 Feb, 2016 13 commits
  3. 16 Feb, 2016 4 commits
    • Zhao Lei's avatar
      btrfs: reada: Avoid many times of empty loop · 97d5f0e6
      Zhao Lei authored
      We can see following loop(10000 times) in trace_log:
       [   75.416137] ZL_DEBUG: reada_start_machine_dev:730: pid=771 comm=kworker/u2:3 re->ref_cnt ffff88003741e0c0 1 -> 2
       [   75.417413] ZL_DEBUG: reada_extent_put:524: pid=771 comm=kworker/u2:3 re = ffff88003741e0c0, refcnt = 2 -> 1
       [   75.418611] ZL_DEBUG: __readahead_hook:129: pid=771 comm=kworker/u2:3 re->ref_cnt ffff88003741e0c0 1 -> 2
       [   75.419793] ZL_DEBUG: reada_extent_put:524: pid=771 comm=kworker/u2:3 re = ffff88003741e0c0, refcnt = 2 -> 1
      
       [   75.421016] ZL_DEBUG: reada_start_machine_dev:730: pid=771 comm=kworker/u2:3 re->ref_cnt ffff88003741e0c0 1 -> 2
       [   75.422324] ZL_DEBUG: reada_extent_put:524: pid=771 comm=kworker/u2:3 re = ffff88003741e0c0, refcnt = 2 -> 1
       [   75.423661] ZL_DEBUG: __readahead_hook:129: pid=771 comm=kworker/u2:3 re->ref_cnt ffff88003741e0c0 1 -> 2
       [   75.424882] ZL_DEBUG: reada_extent_put:524: pid=771 comm=kworker/u2:3 re = ffff88003741e0c0, refcnt = 2 -> 1
      
       ...(10000 times)
      
       [  124.101672] ZL_DEBUG: reada_start_machine_dev:730: pid=771 comm=kworker/u2:3 re->ref_cnt ffff88003741e0c0 1 -> 2
       [  124.102850] ZL_DEBUG: reada_extent_put:524: pid=771 comm=kworker/u2:3 re = ffff88003741e0c0, refcnt = 2 -> 1
       [  124.104008] ZL_DEBUG: __readahead_hook:129: pid=771 comm=kworker/u2:3 re->ref_cnt ffff88003741e0c0 1 -> 2
       [  124.105121] ZL_DEBUG: reada_extent_put:524: pid=771 comm=kworker/u2:3 re = ffff88003741e0c0, refcnt = 2 -> 1
      
      Reason:
       If more than one user trigger reada in same extent, the first task
       finished setting of reada data struct and call reada_start_machine()
       to start, and the second task only add a ref_count but have not
       add reada_extctl struct completely, the reada_extent can not finished
       all jobs, and will be selected in __reada_start_machine() for 10000
       times(total times in __reada_start_machine()).
      
      Fix:
       For a reada_extent without job, we don't need to run it, just return
       0 to let caller break.
      Signed-off-by: default avatarZhao Lei <zhaolei@cn.fujitsu.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      97d5f0e6
    • Zhao Lei's avatar
      btrfs: reada: Add missed segment checking in reada_find_zone · 8e9aa51f
      Zhao Lei authored
      In rechecking zone-in-tree, we still need to check zone include
      our logical address.
      Signed-off-by: default avatarZhao Lei <zhaolei@cn.fujitsu.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      8e9aa51f
    • Zhao Lei's avatar
      btrfs: reada: reduce additional fs_info->reada_lock in reada_find_zone · c37f49c7
      Zhao Lei authored
      We can avoid additional locking-acquirment and one pair of
      kref_get/put by combine two condition.
      Signed-off-by: default avatarZhao Lei <zhaolei@cn.fujitsu.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      c37f49c7
    • Zhao Lei's avatar
      btrfs: reada: Fix in-segment calculation for reada · 50378530
      Zhao Lei authored
      reada_zone->end is end pos of segment:
       end = start + cache->key.offset - 1;
      
      So we need to use "<=" in condition to judge is a pos in the
      segment.
      
      The problem happened rearly, because logical pos rarely pointed
      to last 4k of a blockgroup, but we need to fix it to make code
      right in logic.
      Signed-off-by: default avatarZhao Lei <zhaolei@cn.fujitsu.com>
      Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
      50378530
  4. 12 Feb, 2016 3 commits
  5. 11 Feb, 2016 15 commits