1. 09 Feb, 2023 2 commits
  2. 08 Feb, 2023 28 commits
  3. 07 Feb, 2023 5 commits
    • Devid Antonio Filoni's avatar
      can: j1939: do not wait 250 ms if the same addr was already claimed · 4ae5e1e9
      Devid Antonio Filoni authored
      The ISO 11783-5 standard, in "4.5.2 - Address claim requirements", states:
        d) No CF shall begin, or resume, transmission on the network until 250
           ms after it has successfully claimed an address except when
           responding to a request for address-claimed.
      
      But "Figure 6" and "Figure 7" in "4.5.4.2 - Address-claim
      prioritization" show that the CF begins the transmission after 250 ms
      from the first AC (address-claimed) message even if it sends another AC
      message during that time window to resolve the address contention with
      another CF.
      
      As stated in "4.4.2.3 - Address-claimed message":
        In order to successfully claim an address, the CF sending an address
        claimed message shall not receive a contending claim from another CF
        for at least 250 ms.
      
      As stated in "4.4.3.2 - NAME management (NM) message":
        1) A commanding CF can
           d) request that a CF with a specified NAME transmit the address-
              claimed message with its current NAME.
        2) A target CF shall
           d) send an address-claimed message in response to a request for a
              matching NAME
      
      Taking the above arguments into account, the 250 ms wait is requested
      only during network initialization.
      
      Do not restart the timer on AC message if both the NAME and the address
      match and so if the address has already been claimed (timer has expired)
      or the AC message has been sent to resolve the contention with another
      CF (timer is still running).
      Signed-off-by: default avatarDevid Antonio Filoni <devid.filoni@egluetechnologies.com>
      Acked-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
      Link: https://lore.kernel.org/all/20221125170418.34575-1-devid.filoni@egluetechnologies.com
      Fixes: 9d71dd0c ("can: add support of SAE J1939 protocol")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
      4ae5e1e9
    • Jiri Pirko's avatar
      devlink: change port event netdev notifier from per-net to global · 565b4824
      Jiri Pirko authored
      Currently only the network namespace of devlink instance is monitored
      for port events. If netdev is moved to a different namespace and then
      unregistered, NETDEV_PRE_UNINIT is missed which leads to trigger
      following WARN_ON in devl_port_unregister().
      WARN_ON(devlink_port->type != DEVLINK_PORT_TYPE_NOTSET);
      
      Fix this by changing the netdev notifier from per-net to global so no
      event is missed.
      
      Fixes: 02a68a47 ("net: devlink: track netdev with devlink_port assigned")
      Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
      Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
      Link: https://lore.kernel.org/r/20230206094151.2557264-1-jiri@resnulli.usSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      565b4824
    • Vladimir Oltean's avatar
      selftests: ocelot: tc_flower_chains: make test_vlan_ingress_modify() more comprehensive · bbb253b2
      Vladimir Oltean authored
      We have two IS1 filters of the OCELOT_VCAP_KEY_ANY key type (the one with
      "action vlan pop" and the one with "action vlan modify") and one of the
      OCELOT_VCAP_KEY_IPV4 key type (the one with "action skbedit priority").
      But we have no IS1 filter with the OCELOT_VCAP_KEY_ETYPE key type, and
      there was an uncaught breakage there.
      
      To increase test coverage, convert one of the OCELOT_VCAP_KEY_ANY
      filters to OCELOT_VCAP_KEY_ETYPE, by making the filter also match on the
      MAC SA of the traffic sent by mausezahn, $h1_mac.
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Link: https://lore.kernel.org/r/20230205192409.1796428-2-vladimir.oltean@nxp.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      bbb253b2
    • Vladimir Oltean's avatar
      net: mscc: ocelot: fix VCAP filters not matching on MAC with "protocol 802.1Q" · f964f839
      Vladimir Oltean authored
      Alternative short title: don't instruct the hardware to match on
      EtherType with "protocol 802.1Q" flower filters. It doesn't work for the
      reasons detailed below.
      
      With a command such as the following:
      
      tc filter add dev $swp1 ingress chain $(IS1 2) pref 3 \
      	protocol 802.1Q flower skip_sw vlan_id 200 src_mac $h1_mac \
      	action vlan modify id 300 \
      	action goto chain $(IS2 0 0)
      
      the created filter is set by ocelot_flower_parse_key() to be of type
      OCELOT_VCAP_KEY_ETYPE, and etype is set to {value=0x8100, mask=0xffff}.
      This gets propagated all the way to is1_entry_set() which commits it to
      hardware (the VCAP_IS1_HK_ETYPE field of the key). Compare this to the
      case where src_mac isn't specified - the key type is OCELOT_VCAP_KEY_ANY,
      and is1_entry_set() doesn't populate VCAP_IS1_HK_ETYPE.
      
      The problem is that for VLAN-tagged frames, the hardware interprets the
      ETYPE field as holding the encapsulated VLAN protocol. So the above
      filter will only match those packets which have an encapsulated protocol
      of 0x8100, rather than all packets with VLAN ID 200 and the given src_mac.
      
      The reason why this is allowed to occur is because, although we have a
      block of code in ocelot_flower_parse_key() which sets "match_protocol"
      to false when VLAN keys are present, that code executes too late.
      There is another block of code, which executes for Ethernet addresses,
      and has a "goto finished_key_parsing" and skips the VLAN header parsing.
      By skipping it, "match_protocol" remains with the value it was
      initialized with, i.e. "true", and "proto" is set to f->common.protocol,
      or 0x8100.
      
      The concept of ignoring some keys rather than erroring out when they are
      present but can't be offloaded is dubious in itself, but is present
      since the initial commit fe3490e6 ("net: mscc: ocelot: Hardware
      ofload for tc flower filter"), and it's outside of the scope of this
      patch to change that.
      
      The problem was introduced when the driver started to interpret the
      flower filter's protocol, and populate the VCAP filter's ETYPE field
      based on it.
      
      To fix this, it is sufficient to move the code that parses the VLAN keys
      earlier than the "goto finished_key_parsing" instruction. This will
      ensure that if we have a flower filter with both VLAN and Ethernet
      address keys, it won't match on ETYPE 0x8100, because the VLAN key
      parsing sets "match_protocol = false".
      
      Fixes: 86b956de ("net: mscc: ocelot: support matching on EtherType")
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
      Link: https://lore.kernel.org/r/20230205192409.1796428-1-vladimir.oltean@nxp.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      f964f839
    • Vladimir Oltean's avatar
      net: dsa: mt7530: don't change PVC_EG_TAG when CPU port becomes VLAN-aware · 0b6d6425
      Vladimir Oltean authored
      Frank reports that in a mt7530 setup where some ports are standalone and
      some are in a VLAN-aware bridge, 8021q uppers of the standalone ports
      lose their VLAN tag on xmit, as seen by the link partner.
      
      This seems to occur because once the other ports join the VLAN-aware
      bridge, mt7530_port_vlan_filtering() also calls
      mt7530_port_set_vlan_aware(ds, cpu_dp->index), and this affects the way
      that the switch processes the traffic of the standalone port.
      
      Relevant is the PVC_EG_TAG bit. The MT7530 documentation says about it:
      
      EG_TAG: Incoming Port Egress Tag VLAN Attribution
      0: disabled (system default)
      1: consistent (keep the original ingress tag attribute)
      
      My interpretation is that this setting applies on the ingress port, and
      "disabled" is basically the normal behavior, where the egress tag format
      of the packet (tagged or untagged) is decided by the VLAN table
      (MT7530_VLAN_EGRESS_UNTAG or MT7530_VLAN_EGRESS_TAG).
      
      But there is also an option of overriding the system default behavior,
      and for the egress tagging format of packets to be decided not by the
      VLAN table, but simply by copying the ingress tag format (if ingress was
      tagged, egress is tagged; if ingress was untagged, egress is untagged;
      aka "consistent). This is useful in 2 scenarios:
      
      - VLAN-unaware bridge ports will always encounter a miss in the VLAN
        table. They should forward a packet as-is, though. So we use
        "consistent" there. See commit e045124e ("net: dsa: mt7530: fix
        tagged frames pass-through in VLAN-unaware mode").
      
      - Traffic injected from the CPU port. The operating system is in god
        mode; if it wants a packet to exit as VLAN-tagged, it sends it as
        VLAN-tagged. Otherwise it sends it as VLAN-untagged*.
      
      *This is true only if we don't consider the bridge TX forwarding offload
      feature, which mt7530 doesn't support.
      
      So for now, make the CPU port always stay in "consistent" mode to allow
      software VLANs to be forwarded to their egress ports with the VLAN tag
      intact, and not stripped.
      
      Link: https://lore.kernel.org/netdev/trinity-e6294d28-636c-4c40-bb8b-b523521b00be-1674233135062@3c-app-gmx-bs36/
      Fixes: e045124e ("net: dsa: mt7530: fix tagged frames pass-through in VLAN-unaware mode")
      Reported-by: default avatarFrank Wunderlich <frank-w@public-files.de>
      Tested-by: default avatarFrank Wunderlich <frank-w@public-files.de>
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Tested-by: default avatarArınç ÜNAL <arinc.unal@arinc9.com>
      Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Link: https://lore.kernel.org/r/20230205140713.1609281-1-vladimir.oltean@nxp.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
      0b6d6425
  4. 06 Feb, 2023 5 commits
    • Zhang Changzhong's avatar
      ice: switch: fix potential memleak in ice_add_adv_recipe() · 4a606ce6
      Zhang Changzhong authored
      When ice_add_special_words() fails, the 'rm' is not released, which will
      lead to a memory leak. Fix this up by going to 'err_unroll' label.
      
      Compile tested only.
      
      Fixes: 8b032a55 ("ice: low level support for tunnels")
      Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
      Tested-by: default avatarSujai Buvaneswaran <sujai.buvaneswaran@intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      4a606ce6
    • Dan Carpenter's avatar
      ice: Fix off by one in ice_tc_forward_to_queue() · 3f4870df
      Dan Carpenter authored
      The > comparison should be >= to prevent reading one element beyond
      the end of the array.
      
      The "vsi->num_rxq" is not strictly speaking the number of elements in
      the vsi->rxq_map[] array.  The array has "vsi->alloc_rxq" elements and
      "vsi->num_rxq" is less than or equal to the number of elements in the
      array.  The array is allocated in ice_vsi_alloc_arrays().  It's still
      an off by one but it might not access outside the end of the array.
      
      Fixes: 143b86f3 ("ice: Enable RX queue selection using skbedit action")
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Acked-by: default avatarAmritha Nambiar <amritha.nambiar@intel.com>
      Tested-by: default avatarBharathi Sreenivas <bharathi.sreenivas@intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      3f4870df
    • Brett Creeley's avatar
      ice: Fix disabling Rx VLAN filtering with port VLAN enabled · c793f8ea
      Brett Creeley authored
      If the user turns on the vf-true-promiscuous-support flag, then Rx VLAN
      filtering will be disabled if the VF requests to enable promiscuous
      mode. When the VF is in a port VLAN, this is the incorrect behavior
      because it will allow the VF to receive traffic outside of its port VLAN
      domain. Fortunately this only resulted in the VF(s) receiving broadcast
      traffic outside of the VLAN domain because all of the VLAN promiscuous
      rules are based on the port VLAN ID. Fix this by setting the
      .disable_rx_filtering VLAN op to a no-op when a port VLAN is enabled on
      the VF.
      
      Also, make sure to make this fix for both Single VLAN Mode and Double
      VLAN Mode enabled devices.
      
      Fixes: c31af68a ("ice: Add outer_vlan_ops and VSI specific VLAN ops implementations")
      Signed-off-by: default avatarBrett Creeley <brett.creeley@intel.com>
      Signed-off-by: default avatarKaren Ostrowska <karen.ostrowska@intel.com>
      Tested-by: default avatarMarek Szlosek <marek.szlosek@intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      c793f8ea
    • Michal Swiatkowski's avatar
      ice: fix out-of-bounds KASAN warning in virtchnl · b2dbde3a
      Michal Swiatkowski authored
      KASAN reported:
      [ 9793.708867] BUG: KASAN: global-out-of-bounds in ice_get_link_speed+0x16/0x30 [ice]
      [ 9793.709205] Read of size 4 at addr ffffffffc1271b1c by task kworker/6:1/402
      
      [ 9793.709222] CPU: 6 PID: 402 Comm: kworker/6:1 Kdump: loaded Tainted: G    B      OE      6.1.0+ #3
      [ 9793.709235] Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS SE5C620.86B.00.01.0014.070920180847 07/09/2018
      [ 9793.709245] Workqueue: ice ice_service_task [ice]
      [ 9793.709575] Call Trace:
      [ 9793.709582]  <TASK>
      [ 9793.709588]  dump_stack_lvl+0x44/0x5c
      [ 9793.709613]  print_report+0x17f/0x47b
      [ 9793.709632]  ? __cpuidle_text_end+0x5/0x5
      [ 9793.709653]  ? ice_get_link_speed+0x16/0x30 [ice]
      [ 9793.709986]  ? ice_get_link_speed+0x16/0x30 [ice]
      [ 9793.710317]  kasan_report+0xb7/0x140
      [ 9793.710335]  ? ice_get_link_speed+0x16/0x30 [ice]
      [ 9793.710673]  ice_get_link_speed+0x16/0x30 [ice]
      [ 9793.711006]  ice_vc_notify_vf_link_state+0x14c/0x160 [ice]
      [ 9793.711351]  ? ice_vc_repr_cfg_promiscuous_mode+0x120/0x120 [ice]
      [ 9793.711698]  ice_vc_process_vf_msg+0x7a7/0xc00 [ice]
      [ 9793.712074]  __ice_clean_ctrlq+0x98f/0xd20 [ice]
      [ 9793.712534]  ? ice_bridge_setlink+0x410/0x410 [ice]
      [ 9793.712979]  ? __request_module+0x320/0x520
      [ 9793.713014]  ? ice_process_vflr_event+0x27/0x130 [ice]
      [ 9793.713489]  ice_service_task+0x11cf/0x1950 [ice]
      [ 9793.713948]  ? io_schedule_timeout+0xb0/0xb0
      [ 9793.713972]  process_one_work+0x3d0/0x6a0
      [ 9793.714003]  worker_thread+0x8a/0x610
      [ 9793.714031]  ? process_one_work+0x6a0/0x6a0
      [ 9793.714049]  kthread+0x164/0x1a0
      [ 9793.714071]  ? kthread_complete_and_exit+0x20/0x20
      [ 9793.714100]  ret_from_fork+0x1f/0x30
      [ 9793.714137]  </TASK>
      
      [ 9793.714151] The buggy address belongs to the variable:
      [ 9793.714158]  ice_aq_to_link_speed+0x3c/0xffffffffffff3520 [ice]
      
      [ 9793.714632] Memory state around the buggy address:
      [ 9793.714642]  ffffffffc1271a00: f9 f9 f9 f9 00 00 05 f9 f9 f9 f9 f9 00 00 02 f9
      [ 9793.714656]  ffffffffc1271a80: f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 00 00 00 00
      [ 9793.714670] >ffffffffc1271b00: 00 00 00 04 f9 f9 f9 f9 04 f9 f9 f9 f9 f9 f9 f9
      [ 9793.714680]                             ^
      [ 9793.714690]  ffffffffc1271b80: 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9 00 00 00 00
      [ 9793.714704]  ffffffffc1271c00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      
      The ICE_AQ_LINK_SPEED_UNKNOWN define is BIT(15). The value is bigger
      than both legacy and normal link speed tables. Add one element (0 -
      unknown) to both tables. There is no need to explicitly set table size,
      leave it empty.
      
      Fixes: 1d0e28a9 ("ice: Remove and replace ice speed defines with ethtool.h versions")
      Signed-off-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
      Reviewed-by: default avatarAlexander Lobakin <alexandr.lobakin@intel.com>
      Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      b2dbde3a
    • Anirudh Venkataramanan's avatar
      ice: Do not use WQ_MEM_RECLAIM flag for workqueue · 4d159f78
      Anirudh Venkataramanan authored
      When both ice and the irdma driver are loaded, a warning in
      check_flush_dependency is being triggered. This is due to ice driver
      workqueue being allocated with the WQ_MEM_RECLAIM flag and the irdma one
      is not.
      
      According to kernel documentation, this flag should be set if the
      workqueue will be involved in the kernel's memory reclamation flow.
      Since it is not, there is no need for the ice driver's WQ to have this
      flag set so remove it.
      
      Example trace:
      
      [  +0.000004] workqueue: WQ_MEM_RECLAIM ice:ice_service_task [ice] is flushing !WQ_MEM_RECLAIM infiniband:0x0
      [  +0.000139] WARNING: CPU: 0 PID: 728 at kernel/workqueue.c:2632 check_flush_dependency+0x178/0x1a0
      [  +0.000011] Modules linked in: bonding tls xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nf_reject_ipv4 nft_compat nft_cha
      in_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc rfkill vfat fat intel_rapl_msr intel
      _rapl_common isst_if_common skx_edac nfit libnvdimm x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct1
      0dif_pclmul crc32_pclmul ghash_clmulni_intel rapl intel_cstate rpcrdma sunrpc rdma_ucm ib_srpt ib_isert iscsi_target_mod target_
      core_mod ib_iser libiscsi scsi_transport_iscsi rdma_cm ib_cm iw_cm iTCO_wdt iTCO_vendor_support ipmi_ssif irdma mei_me ib_uverbs
      ib_core intel_uncore joydev pcspkr i2c_i801 acpi_ipmi mei lpc_ich i2c_smbus intel_pch_thermal ioatdma ipmi_si acpi_power_meter
      acpi_pad xfs libcrc32c sd_mod t10_pi crc64_rocksoft crc64 sg ahci ixgbe libahci ice i40e igb crc32c_intel mdio i2c_algo_bit liba
      ta dca wmi dm_mirror dm_region_hash dm_log dm_mod ipmi_devintf ipmi_msghandler fuse
      [  +0.000161]  [last unloaded: bonding]
      [  +0.000006] CPU: 0 PID: 728 Comm: kworker/0:2 Tainted: G S                 6.2.0-rc2_next-queue-13jan-00458-gc20aabd57164 #1
      [  +0.000006] Hardware name: Intel Corporation S2600WFT/S2600WFT, BIOS SE5C620.86B.02.01.0010.010620200716 01/06/2020
      [  +0.000003] Workqueue: ice ice_service_task [ice]
      [  +0.000127] RIP: 0010:check_flush_dependency+0x178/0x1a0
      [  +0.000005] Code: 89 8e 02 01 e8 49 3d 40 00 49 8b 55 18 48 8d 8d d0 00 00 00 48 8d b3 d0 00 00 00 4d 89 e0 48 c7 c7 e0 3b 08
      9f e8 bb d3 07 01 <0f> 0b e9 be fe ff ff 80 3d 24 89 8e 02 00 0f 85 6b ff ff ff e9 06
      [  +0.000004] RSP: 0018:ffff88810a39f990 EFLAGS: 00010282
      [  +0.000005] RAX: 0000000000000000 RBX: ffff888141bc2400 RCX: 0000000000000000
      [  +0.000004] RDX: 0000000000000001 RSI: dffffc0000000000 RDI: ffffffffa1213a80
      [  +0.000003] RBP: ffff888194bf3400 R08: ffffed117b306112 R09: ffffed117b306112
      [  +0.000003] R10: ffff888bd983088b R11: ffffed117b306111 R12: 0000000000000000
      [  +0.000003] R13: ffff888111f84d00 R14: ffff88810a3943ac R15: ffff888194bf3400
      [  +0.000004] FS:  0000000000000000(0000) GS:ffff888bd9800000(0000) knlGS:0000000000000000
      [  +0.000003] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  +0.000003] CR2: 000056035b208b60 CR3: 000000017795e005 CR4: 00000000007706f0
      [  +0.000003] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [  +0.000003] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
      [  +0.000002] PKRU: 55555554
      [  +0.000003] Call Trace:
      [  +0.000002]  <TASK>
      [  +0.000003]  __flush_workqueue+0x203/0x840
      [  +0.000006]  ? mutex_unlock+0x84/0xd0
      [  +0.000008]  ? __pfx_mutex_unlock+0x10/0x10
      [  +0.000004]  ? __pfx___flush_workqueue+0x10/0x10
      [  +0.000006]  ? mutex_lock+0xa3/0xf0
      [  +0.000005]  ib_cache_cleanup_one+0x39/0x190 [ib_core]
      [  +0.000174]  __ib_unregister_device+0x84/0xf0 [ib_core]
      [  +0.000094]  ib_unregister_device+0x25/0x30 [ib_core]
      [  +0.000093]  irdma_ib_unregister_device+0x97/0xc0 [irdma]
      [  +0.000064]  ? __pfx_irdma_ib_unregister_device+0x10/0x10 [irdma]
      [  +0.000059]  ? up_write+0x5c/0x90
      [  +0.000005]  irdma_remove+0x36/0x90 [irdma]
      [  +0.000062]  auxiliary_bus_remove+0x32/0x50
      [  +0.000007]  device_release_driver_internal+0xfa/0x1c0
      [  +0.000005]  bus_remove_device+0x18a/0x260
      [  +0.000007]  device_del+0x2e5/0x650
      [  +0.000005]  ? __pfx_device_del+0x10/0x10
      [  +0.000003]  ? mutex_unlock+0x84/0xd0
      [  +0.000004]  ? __pfx_mutex_unlock+0x10/0x10
      [  +0.000004]  ? _raw_spin_unlock+0x18/0x40
      [  +0.000005]  ice_unplug_aux_dev+0x52/0x70 [ice]
      [  +0.000160]  ice_service_task+0x1309/0x14f0 [ice]
      [  +0.000134]  ? __pfx___schedule+0x10/0x10
      [  +0.000006]  process_one_work+0x3b1/0x6c0
      [  +0.000008]  worker_thread+0x69/0x670
      [  +0.000005]  ? __kthread_parkme+0xec/0x110
      [  +0.000007]  ? __pfx_worker_thread+0x10/0x10
      [  +0.000005]  kthread+0x17f/0x1b0
      [  +0.000005]  ? __pfx_kthread+0x10/0x10
      [  +0.000004]  ret_from_fork+0x29/0x50
      [  +0.000009]  </TASK>
      
      Fixes: 940b61af ("ice: Initialize PF and setup miscellaneous interrupt")
      Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
      Signed-off-by: default avatarMarcin Szycik <marcin.szycik@linux.intel.com>
      Tested-by: default avatarJakub Andrysiak <jakub.andrysiak@intel.com>
      Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
      Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
      4d159f78