memmem(), which searches for one bytestring in a longer
bytestring is one of those functions that should be standard, but
isn't.  This patch adds a ccan configurator test for the function
so that modules can use or replace it as necessary.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Simplest fix is to use const where possible, and use a different var for
asprintf and string literals in login.c.

Tests don't compile otherwise, so fix that up (ccanlint now tests with
reduced features, so this became clear).

Add a license tag (though it's a weird BSD variant), remove whitespace, and
avoid void pointer arithmetic.

They expect to be linked against the module objects.

Just grab the tokens for the simple case: this allows the ccanlint
reduce_features test to work on eg. ccan/cast.

This means we change some minor tests to "never fail", eg. whitespace
or documentation tests.  Note that pass/fail is independent of the
score for a test.

Be a little more careful with const.

Shown up by -Wwrite-strings.

Wpointer-arith is useful for spotting GCC-isms which do arithmetic on
void pointers.  Wwrite-strings treats string constants as const char *,
which is sane (but bad for legacy code).

Same fix as we used for ccan/typesafe_cb.

No only does this give us one more ccanlint point, it clears the way
to see if we introduce a *real* memory leak later.

This need shows up most clearly with opt_usage_and_exit and gcc's
-Wwrite-strings, where string literals become "const char *".  Our
callbacks should take const void *: since we overload the arg field
already (to hold table size) it make sense to turn it into a proper
union.

Headers should stand alone; we use NULL, so we should make sure it's defined.

I thought using sizeof() comparison to compare the types was clever,
but it doesn't work on void pointers, as sizeof(void) is illegal.

In this case, "work" means "fail to compile cleanly".

Don't implicitly cast away const in the tests.

In particular, avoid doing arithmetic on NULL; decay the function to a
pointer using a trinary conditional instead.

It's common to want to create a struct tdb_data which contains a const
pointer, so add a helper to do so, and use it to clean up other -Wcast-qual
warnings.

Samba uses -Wcast-qual to warn about casting away const.  The kind of
coders who care about const correctness are likely to turn that option
on, so we should make sure it's compatible with cast_const().

The foreach garbage collection assumed that iterators were all on the
stack, but they could be on the heap or a global (or static) variable.
We can prevent the heap case by tricky use of macros to complain on
any iterator which isn't a single token, but we can't prevent
globals/statics.

So, if an iterator already seems to be "off" the stack, mark it as
such and simply never free it.

David Gibson noted that foreach requires more than one argument.
There's no particularly good reason for this, other than lack of
imagination on my part.

This makes transition from tdb1 much simpler.

As per TDB1, except that the sequence number is 63 bit.