- 10 Jan, 2020 13 commits
-
-
Romain Courteaud authored
-
Romain Courteaud authored
It will reduce the HTML size and prevent any browser parsing incompatibility.
-
Arnaud Fontaine authored
ZODB Components: erp5_banking_core: Fix testERP5Banking{AccountingCancellation,BankAccountInventory,CheckDeposit} failures. BankingOperation monkey patches several ERP5 basic classes to add getBaobab* methods. With ERP5Banking Product on FS, BankingOperation was imported at Zope startup when loading Products and monkey patches were applied.
-
Arnaud Fontaine authored
Moreover, since this was added and because of a bug in bt5 implementation of provide dependencies, it was not possible to install this bt5 from TemplateTool on a fresh instance: [...] File "product/ERP5Type/tests/runUnitTest.py", line 417, in _installBusinessTemplateList with_test_dependency_list=True)] File "product/ERP5/Tool/TemplateTool.py", line 1200, in resolveBusinessTemplateListDependency return self.sortBusinessTemplateList(list(bt5_set)) File "product/ERP5/Tool/TemplateTool.py", line 947, in sortBusinessTemplateList "Circular dependencies on %s" % reverse_dependency_dict.keys() NotImplementedError: Circular dependencies on ['erp5_mysql_innodb_catalog', 'erp5_banking_core', 'erp5_property_sheets', 'erp5_core', 'erp5_pdm', 'erp5_trade', 'erp5_accounting', 'erp5_core_proxy_field_legacy', 'erp5_simulation', 'erp5_base'] -> erp5_banking_core depends on erp5_trade. --> erp5_trade depends on erp5_base. ---> erp5_base depends on erp5_full_text_catalog meta bt5 resolved to erp5_banking_core (provision_list). This fixes testBanking* Unit Tests failures since ERP5Banking migration to ZODB Components (0d2bd4c0) not triggered with FS Unit Tests because it does not try to resolve dependencies and just install them in getBusinessTemplateList() order.
-
Arnaud Fontaine authored
ZODB Components: Cosmetic: Remove Unit Test FS-only getBusinessTemplateList() now that it has been migrated.
-
Arnaud Fontaine authored
ERP5Site: Do not override newContent() but use FolderMixIn implementation to have a consistent behavior. ERP5Site was raising error when ID or portal_type was not passed but there is no reason to do so (as it is done in FolderMixIn.newContent()). This allows calling ERP5Site.newContent(temp_object=True) without ID, likewise Folder.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
Folder: Allow to create temp_objects anywhere, without checking if it's in allowed types for that Portal Type. Until now, creating a temp_object with newContent() required for the temp_object to be in allowed types. However, this was inconsistent with (now deprecated) newTemp*() functions (calling directly constructInstance()) not having such limitations. Besides lifting such limitation being needed to properly replace newTemp*() calls, portal_trash.newContent() pattern is already commonly used used here meaning there is a real use case. This also fixes testBanking* failures: newTempCashDeliveryLine() created objects on 'Cash Inventory' and latter call Delivery.isAccountable() which does not exist on portal_trash. See also 04b49859. /reviewed-on !1025
-
Nicolas Wavrant authored
-
Nicolas Wavrant authored
-
Nicolas Wavrant authored
-
Nicolas Wavrant authored
Also hide seconds as it weights down the interface, and to follow the behavior of XML style
-
Nicolas Wavrant authored
-
- 09 Jan, 2020 4 commits
-
-
Xiaowu Zhang authored
-
Romain Courteaud authored
-
Xiaowu Zhang authored
-
Yusei Tahara authored
-
- 07 Jan, 2020 4 commits
-
-
Arnaud Fontaine authored
This is an empty modules whose names are dynamically inserted by AccessControl.Implementation.
-
Arnaud Fontaine authored
-
Arnaud Fontaine authored
-
Jérome Perrin authored
These constructors are not recognized by pylint and now we have no-name-in-module errors. Because since introduction of portal types as classes there was this idea of deprecating those in favor of using newContent(temp_object=True, switch to this new syntax. Since we still have to create documents in portal_trash, only change the minimal to get coding style tests passing again. /reviewed-on !1024
-
- 30 Dec, 2019 3 commits
-
-
Georgios Dagkakis authored
for Person_viewAssignment form
-
Roque authored
-
Roque authored
-
- 28 Dec, 2019 3 commits
-
-
Arnaud Fontaine authored
For example, ExtensionClass (such as ValidationFailed) need to have their AST properly generated. This fixes 'Use of super on an old style class (super-on-old-class)' error.
-
Arnaud Fontaine authored
Besides of being needed for bootstrap, this also makes more sense than ignoring completely ERP5Type as some modules should not be in there and should be migrated.
-
Arnaud Fontaine authored
ZODB Components: Preparation of erp5_base migration from FS: LoginAccountProviderMixin implements ILoginAccountProvider (otherwise unused).
-
- 27 Dec, 2019 2 commits
-
-
Georgios Dagkakis authored
this is not passed correctly in submission script anyway, so selection is not taken into account in this case
-
Arnaud Fontaine authored
-
- 26 Dec, 2019 11 commits
-
-
Vincent Pelletier authored
Especially important as the deleted document has an hard-coded ID which gets reused - as is the case here. It may not be a good idea to hardcode such ids in tests too, but I cannot judge at a glance. /cc @romain /reviewed-on nexedi/erp5!1020
-
Jérome Perrin authored
Assorted fixes for minor issues with ZODB History tab: 1. When viewing history of a website or websection in the "backoffice" interface, clicking on *View ZODB History* does not keep the `ignore_layout:int=1` request parameter that forces displaying the forms in the *View* skin selection. 2. Fix using ZODB history for documents with binary properties, such as `data` property on images and files. Instead of failing with unicode error, just display "(binary)". 3. Put the link field in center group, forms with only fields in left group and nothing in right group have a border only on the left side. ( this is https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#listbox-only-tabs-should-have-a-read-only-title-in-center-group ) see before: ![before__1_](/uploads/eaafe271228e960f58b7b928cb517ac9/before__1_.png) and after: ![Screenshot_2017-11-28_at_19.32.09](/uploads/bdd0adcc80b138dca7ddcb45b2ff184a/Screenshot_2017-11-28_at_19.32.09.png) /reviewed-on !512
-
Jérome Perrin authored
This is enabled for title and description only, because that's usually what we put on "external" documents such as invoices. By "resource" here it means products, services, components and their individual variations In short, change the translation configuration from ![Screenshot_2017-12-05_at_10.22.39](/uploads/2c72a0b35dbbde1ec6d7156f2e2f372a/Screenshot_2017-12-05_at_10.22.39.png) to ![Screenshot_2017-12-05_at_10.23.31](/uploads/d86c2fce6a9d134e17b5fddc983491a3/Screenshot_2017-12-05_at_10.23.31.png) /reviewed-on nexedi/erp5!515
-
Jérome Perrin authored
Fix broken tests after !1011 it was merged too fast. /reviewed-on !1018
-
Jérome Perrin authored
Some users have been using google chrome builtin translation system with ERP5 back office (xhtml style), but the way google translation changes the DOM sometimes break ERP5 interface. This also have data privacy issue as this translation is done on google servers. https://www.w3.org/International/questions/qa-translate-flag recommends using translate=no but the approach of the meta tag might be preferable for our case as it prevents sending the page content to translation service. /reviewed-on !879
-
Jérome Perrin authored
The field needs to be in center group to comply with https://www.erp5.com/documentation/developer/guideline/module/erp5-Guideline.Module.Creation/#listbox-only-tabs-should-have-a-read-only-title-in-center-group
-
Jérome Perrin authored
It was failing decoding unicode
-
Jérome Perrin authored
-
Jérome Perrin authored
Otherwise we cannot use this feature on a website/websection using a different skin selection.
-
Jérome Perrin authored
3d3ee5da had syntax error and test were not updated for new behavior
-
Jérome Perrin authored
content_type is a bit special, because CMF's PortalFolderBase also have a content_type method, so this was confusing ERP5Type dynamic properties system. When the property was never set, the default value was the method acquired from PortalFolderBase. Fixes this by defining conten_type class attribute where needed. This also fixes an old expected failure test, it's now possible to use edit(content_type=something) in document without content type property set. It works now, but thanks to what seems to be outdated code in _valid_property_id from product/ERP5Type/patches/PropertyManager.py, because we have stopped setting all properties to None in Base years ago. For now, this works, but because of an outdated condition in _valid_property_id. We may revisit later in the future.
-