Merge branch 'remove_api_activity_logging_feature_flag' into 'master'

Remove api_activity_logging feature flag

See merge request gitlab-org/gitlab!28755

changelogs/unreleased/remove_api_activity_logging_feature_flag.yml

+---
+title: Enable last user activity logging on the REST API
+merge_request: 28755
+author:
+type: added

lib/api/api.rb

@@ -105,7 +105,7 @@ module API
 
     namespace do
       after do
-        ::Users::ActivityService.new(@current_user).execute if Feature.enabled?(:api_activity_logging)
+        ::Users::ActivityService.new(@current_user).execute
       end
 
       # Keep in alphabetical order

spec/requests/api/api_spec.rb

@@ -13,13 +13,5 @@ describe API::API do
     it 'updates the users last_activity_on date' do
       expect { get api('/groups', user) }.to change { user.reload.last_activity_on }.to(Date.today)
     end
-
-    context 'when the the api_activity_logging feature is disabled' do
-      it 'does not touch last_activity_on' do
-        stub_feature_flags(api_activity_logging: false)
-
-        expect { get api('/groups', user) }.not_to change { user.reload.last_activity_on }
-      end
-    end
   end
 end