Merge branch '207869-git-request-specs-shared-examples' into 'master'

Refactor Git/LFS request specs into shared examples

See merge request gitlab-org/gitlab!49138

spec/controllers/repositories/git_http_controller_spec.rb

@@ -9,120 +9,6 @@ RSpec.describe Repositories::GitHttpController do
   let_it_be(:personal_snippet) { create(:personal_snippet, :public, :repository) }
   let_it_be(:project_snippet) { create(:project_snippet, :public, :repository, project: project) }
 
-  shared_examples Repositories::GitHttpController do
-    let(:repository_path) { "#{container.full_path}.git" }
-    let(:params) { { repository_path: repository_path } }
-
-    describe 'HEAD #info_refs' do
-      it 'returns 403' do
-        head :info_refs, params: params
-
-        expect(response).to have_gitlab_http_status(:forbidden)
-      end
-    end
-
-    describe 'GET #info_refs' do
-      let(:params) { super().merge(service: 'git-upload-pack') }
-
-      it 'returns 401 for unauthenticated requests to public repositories when http protocol is disabled' do
-        stub_application_setting(enabled_git_access_protocol: 'ssh')
-        allow(controller).to receive(:basic_auth_provided?).and_call_original
-
-        expect(controller).to receive(:http_download_allowed?).and_call_original
-
-        get :info_refs, params: params
-
-        expect(response).to have_gitlab_http_status(:unauthorized)
-      end
-
-      it 'calls the right access checker class with the right object' do
-        allow(controller).to receive(:verify_workhorse_api!).and_return(true)
-
-        access_double = double
-        options = {
-          authentication_abilities: [:download_code],
-          repository_path: repository_path,
-          redirected_path: nil,
-          auth_result_type: :none
-        }
-
-        expect(access_checker_class).to receive(:new)
-          .with(nil, container, 'http', hash_including(options))
-          .and_return(access_double)
-
-        allow(access_double).to receive(:check).and_return(false)
-
-        get :info_refs, params: params
-      end
-
-      context 'with authorized user' do
-        before do
-          request.headers.merge! auth_env(user.username, user.password, nil)
-        end
-
-        it 'returns 200' do
-          get :info_refs, params: params
-
-          expect(response).to have_gitlab_http_status(:ok)
-        end
-
-        it 'updates the user activity' do
-          expect_next_instance_of(Users::ActivityService) do |activity_service|
-            expect(activity_service).to receive(:execute)
-          end
-
-          get :info_refs, params: params
-        end
-
-        include_context 'parsed logs' do
-          it 'adds user info to the logs' do
-            get :info_refs, params: params
-
-            expect(log_data).to include('username' => user.username,
-                                        'user_id' => user.id,
-                                        'meta.user' => user.username)
-          end
-        end
-      end
-
-      context 'with exceptions' do
-        before do
-          allow(controller).to receive(:authenticate_user).and_return(true)
-          allow(controller).to receive(:verify_workhorse_api!).and_return(true)
-        end
-
-        it 'returns 503 with GRPC Unavailable' do
-          allow(controller).to receive(:access_check).and_raise(GRPC::Unavailable)
-
-          get :info_refs, params: params
-
-          expect(response).to have_gitlab_http_status(:service_unavailable)
-        end
-
-        it 'returns 503 with timeout error' do
-          allow(controller).to receive(:access_check).and_raise(Gitlab::GitAccess::TimeoutError)
-
-          get :info_refs, params: params
-
-          expect(response).to have_gitlab_http_status(:service_unavailable)
-          expect(response.body).to eq 'Gitlab::GitAccess::TimeoutError'
-        end
-      end
-    end
-
-    describe 'POST #git_upload_pack' do
-      before do
-        allow(controller).to receive(:verify_workhorse_api!).and_return(true)
-      end
-
-      it 'returns 200' do
-        post :git_upload_pack, params: params
-
-        expect(response).to have_gitlab_http_status(:ok)
-      end
-    end
-  end
-
   context 'when repository container is a project' do
     it_behaves_like Repositories::GitHttpController do
       let(:container) { project }

spec/support/shared_examples/controllers/repositories/git_http_controller_shared_examples.rb

+# frozen_string_literal: true
+
+RSpec.shared_examples Repositories::GitHttpController do
+  include GitHttpHelpers
+
+  let(:repository_path) { "#{container.full_path}.git" }
+  let(:params) { { repository_path: repository_path } }
+
+  describe 'HEAD #info_refs' do
+    it 'returns 403' do
+      head :info_refs, params: params
+
+      expect(response).to have_gitlab_http_status(:forbidden)
+    end
+  end
+
+  describe 'GET #info_refs' do
+    let(:params) { super().merge(service: 'git-upload-pack') }
+
+    it 'returns 401 for unauthenticated requests to public repositories when http protocol is disabled' do
+      stub_application_setting(enabled_git_access_protocol: 'ssh')
+      allow(controller).to receive(:basic_auth_provided?).and_call_original
+
+      expect(controller).to receive(:http_download_allowed?).and_call_original
+
+      get :info_refs, params: params
+
+      expect(response).to have_gitlab_http_status(:unauthorized)
+    end
+
+    it 'calls the right access checker class with the right object' do
+      allow(controller).to receive(:verify_workhorse_api!).and_return(true)
+
+      access_double = double
+      options = {
+        authentication_abilities: [:download_code],
+        repository_path: repository_path,
+        redirected_path: nil,
+        auth_result_type: :none
+      }
+
+      expect(access_checker_class).to receive(:new)
+        .with(nil, container, 'http', hash_including(options))
+        .and_return(access_double)
+
+      allow(access_double).to receive(:check).and_return(false)
+
+      get :info_refs, params: params
+    end
+
+    context 'with authorized user' do
+      before do
+        request.headers.merge! auth_env(user.username, user.password, nil)
+      end
+
+      it 'returns 200' do
+        get :info_refs, params: params
+
+        expect(response).to have_gitlab_http_status(:ok)
+      end
+
+      it 'updates the user activity' do
+        expect_next_instance_of(Users::ActivityService) do |activity_service|
+          expect(activity_service).to receive(:execute)
+        end
+
+        get :info_refs, params: params
+      end
+
+      include_context 'parsed logs' do
+        it 'adds user info to the logs' do
+          get :info_refs, params: params
+
+          expect(log_data).to include('username' => user.username,
+                                      'user_id' => user.id,
+                                      'meta.user' => user.username)
+        end
+      end
+    end
+
+    context 'with exceptions' do
+      before do
+        allow(controller).to receive(:authenticate_user).and_return(true)
+        allow(controller).to receive(:verify_workhorse_api!).and_return(true)
+      end
+
+      it 'returns 503 with GRPC Unavailable' do
+        allow(controller).to receive(:access_check).and_raise(GRPC::Unavailable)
+
+        get :info_refs, params: params
+
+        expect(response).to have_gitlab_http_status(:service_unavailable)
+      end
+
+      it 'returns 503 with timeout error' do
+        allow(controller).to receive(:access_check).and_raise(Gitlab::GitAccess::TimeoutError)
+
+        get :info_refs, params: params
+
+        expect(response).to have_gitlab_http_status(:service_unavailable)
+        expect(response.body).to eq 'Gitlab::GitAccess::TimeoutError'
+      end
+    end
+  end
+
+  describe 'POST #git_upload_pack' do
+    before do
+      allow(controller).to receive(:verify_workhorse_api!).and_return(true)
+    end
+
+    it 'returns 200' do
+      post :git_upload_pack, params: params
+
+      expect(response).to have_gitlab_http_status(:ok)
+    end
+  end
+end

spec/support/shared_examples/requests/lfs_http_shared_examples.rb

@@ -65,12 +65,19 @@ end
 RSpec.shared_examples 'LFS http requests' do
   include LfsHttpHelpers
 
+  let(:lfs_enabled) { true }
   let(:authorize_guest) {}
   let(:authorize_download) {}
   let(:authorize_upload) {}
 
   let(:lfs_object) { create(:lfs_object, :with_file) }
   let(:sample_oid) { lfs_object.oid }
+  let(:sample_size) { lfs_object.size }
+  let(:sample_object) { { 'oid' => sample_oid, 'size' => sample_size } }
+  let(:non_existing_object_oid) { '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897' }
+  let(:non_existing_object_size) { 1575078 }
+  let(:non_existing_object) { { 'oid' => non_existing_object_oid, 'size' => non_existing_object_size } }
+  let(:multiple_objects) { [sample_object, non_existing_object] }
 
   let(:authorization) { authorize_user }
   let(:headers) do
@@ -89,13 +96,11 @@ RSpec.shared_examples 'LFS http requests' do
   end
 
   before do
-    stub_lfs_setting(enabled: true)
+    stub_lfs_setting(enabled: lfs_enabled)
   end
 
   context 'when LFS is disabled globally' do
-    before do
-      stub_lfs_setting(enabled: false)
-    end
+    let(:lfs_enabled) { false }
 
     describe 'download request' do
       before do