Merge branch 'quarantine-flaky-tests' into 'master'

Quarantine flaky tests

See merge request gitlab-org/gitlab!34615

.gitlab/ci/rails.gitlab-ci.yml

@@ -369,10 +369,8 @@ db:rollback geo:
 # EE: Canonical MR pipelines
 rspec foss-impact:
   extends:
-    - .rspec-base
-    - .as-if-foss
+    - .rspec-base-pg11-as-if-foss
     - .rails:rules:ee-mr-only
-    - .use-pg11
   script:
     - install_gitlab_gem
     - run_timed_command "scripts/gitaly-test-build"

.gitlab/ci/rules.gitlab-ci.yml

@@ -322,11 +322,8 @@
   rules:
     - <<: *if-not-ee
       when: never
-    - <<: *if-security-merge-request
+    - <<: *if-merge-request  # Always run for MRs since `compile-test-assets as-if-foss` is either needed by `rspec foss-impact` or the `rspec * as-if-foss` jobs.
       changes: *code-backstage-qa-patterns
-    - <<: *if-merge-request-title-as-if-foss
-    - <<: *if-merge-request
-      changes: *ci-patterns
 
 .frontend:rules:default-frontend-jobs:
   rules:

ee/spec/features/epics/shortcuts_epic_spec.rb

@@ -41,7 +41,7 @@ RSpec.describe 'Epic shortcuts', :js do
       wait_for_requests
     end
 
-    it "quotes the selected text", :quarantine do
+    it "quotes the selected text", quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/11057' do
       select_element('.note-text')
       find('body').native.send_key('r')
 

ee/spec/features/issues/form_spec.rb

@@ -52,7 +52,7 @@ RSpec.describe 'New/edit issue', :js do
         wait_for_requests
       end
 
-      it 'displays selected users even if they are not part of the original API call', quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/28634' do
+      it 'displays selected users even if they are not part of the original API call', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/28634' do
         find('.dropdown-input-field').native.send_keys user2.name
 
         page.within '.dropdown-menu-user' do

ee/spec/features/projects/settings/protected_environments_spec.rb

@@ -65,7 +65,7 @@ RSpec.describe 'Protected Environments' do
       end
     end
 
-    it 'allows updating access to a protected environment', :js, :quarantine do
+    it 'allows updating access to a protected environment', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/11086' do
       within('.protected-branches-list tr', text: 'production') do
         set_allowed_to_deploy('Developers + Maintainers')
       end

ee/spec/features/projects_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe 'Project' do
+RSpec.describe 'Project', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/222234' do
   describe 'when creating from group template' do
     let(:user) { create(:user) }
     let(:group) { create(:group, name: 'parent-group') }
@@ -17,7 +17,7 @@ RSpec.describe 'Project' do
       sign_in user
     end
 
-    it "defaults to correct namespace", :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/223023' do
+    it "defaults to correct namespace" do
       visit new_project_path
       find('#create-from-template-tab').click
       find('.custom-group-project-templates-tab').click
@@ -26,7 +26,7 @@ RSpec.describe 'Project' do
       expect(find('.js-select-namespace')).to have_content group.name
     end
 
-    it "uses supplied namespace", :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/222234' do
+    it "uses supplied namespace" do
       visit new_project_path(namespace_id: other_subgroup.id)
       find('#create-from-template-tab').click
       find('.custom-group-project-templates-tab').click

ee/spec/requests/api/namespaces_spec.rb

@@ -343,7 +343,7 @@ RSpec.describe API::Namespaces do
 
     context 'when authenticated as an admin' do
       context 'when namespace is not found' do
-        it 'returns a 404 error', :quarantine do
+        it 'returns a 404 error', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/11298' do
           do_put(1111, admin, params)
 
           expect(response).to have_gitlab_http_status(:not_found)

ee/spec/support/protected_tags/access_control_shared_examples.rb

@@ -74,7 +74,7 @@ RSpec.shared_examples "protected tags > access control > EE" do
     expect(access_levels).to be_empty
   end
 
-  it "prepends selected users that can create", :quarantine do
+  it "prepends selected users that can create", quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/9205' do
     users = create_list(:user, 21)
     users.each { |user| project.add_developer(user) }
 

spec/features/admin/admin_users_spec.rb

@@ -38,7 +38,7 @@ RSpec.describe "Admin::Users" do
     end
 
     describe "view extra user information" do
-      it 'shows the user popover on hover', :js, :quarantine do
+      it 'shows the user popover on hover', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/11290' do
         expect(page).not_to have_selector('#__BV_popover_1__')
 
         first_user_link = page.first('.js-user-link')

spec/features/discussion_comments/commit_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe 'Thread Comments Commit', :js do
     expect(page).to have_css('.js-note-emoji')
   end
 
-  it 'adds award to the correct note', quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/207973' do
+  it 'adds award to the correct note', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/207973' do
     find("#note_#{commit_discussion_note2.id} .js-note-emoji").click
     first('.emoji-menu .js-emoji-btn').click
 

spec/features/issues/filtered_search/search_bar_spec.rb

@@ -88,7 +88,7 @@ RSpec.describe 'Search bar', :js do
       expect(find('#js-dropdown-hint')).to have_selector('.filter-dropdown .filter-dropdown-item', count: original_size)
     end
 
-    it 'resets the dropdown filters', :quarantine do
+    it 'resets the dropdown filters', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/9985' do
       filtered_search.click
 
       hint_offset = get_left_style(find('#js-dropdown-hint')['style'])

spec/features/issues/issue_detail_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe 'Issue Detail', :js do
       visit project_issue_path(project, issue)
     end
 
-    it 'encodes the description to prevent xss issues', quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/207951' do
+    it 'encodes the description to prevent xss issues', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/207951' do
       page.within('.issuable-details .detail-page-description') do
         image = find('img.js-lazy-loaded')
 

spec/features/issues/issue_sidebar_spec.rb

@@ -195,7 +195,7 @@ RSpec.describe 'Issue Sidebar' do
         end
       end
 
-      context 'creating a project label', :js, :quarantine do
+      context 'creating a project label', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27992' do
         before do
           page.within('.block.labels') do
             click_link 'Create project'

spec/features/issues/user_creates_branch_and_merge_request_spec.rb

@@ -31,7 +31,7 @@ RSpec.describe 'User creates branch and merge request on issue page', :js do
       end
 
       # In order to improve tests performance, all UI checks are placed in this test.
-      it 'shows elements', :quarantine do
+      it 'shows elements', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27993' do
         button_create_merge_request = find('.js-create-merge-request')
         button_toggle_dropdown = find('.create-mr-dropdown-wrap .dropdown-toggle')
 
@@ -141,7 +141,7 @@ RSpec.describe 'User creates branch and merge request on issue page', :js do
         visit project_issue_path(project, issue)
       end
 
-      it 'disables the create branch button', :quarantine do
+      it 'disables the create branch button', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27985' do
         expect(page).to have_css('.create-mr-dropdown-wrap .unavailable:not(.hidden)')
         expect(page).to have_css('.create-mr-dropdown-wrap .available.hidden', visible: false)
         expect(page).to have_content /Related merge requests/

spec/features/issues/user_interacts_with_awards_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe 'User interacts with awards' do
       visit(project_issue_path(project, issue))
     end
 
-    it 'toggles the thumbsup award emoji', :quarantine do
+    it 'toggles the thumbsup award emoji', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27959' do
       page.within('.awards') do
         thumbsup = page.first('.award-control')
         thumbsup.click
@@ -77,7 +77,7 @@ RSpec.describe 'User interacts with awards' do
       end
     end
 
-    it 'shows the list of award emoji categories', :quarantine do
+    it 'shows the list of award emoji categories', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27991' do
       page.within('.awards') do
         page.find('.js-add-award').click
       end

spec/features/labels_hierarchy_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe 'Labels Hierarchy', :js do
   end
 
   shared_examples 'assigning labels from sidebar' do
-    it 'can assign all ancestors labels', :quarantine do
+    it 'can assign all ancestors labels', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27952' do
       [grandparent_group_label, parent_group_label, project_label_1].each do |label|
         page.within('.block.labels') do
           find('.edit-link').click

spec/features/merge_request/user_creates_image_diff_notes_spec.rb

@@ -88,7 +88,7 @@ RSpec.describe 'Merge request > User creates image diff notes', :js do
           create_image_diff_note
         end
 
-        it 'shows indicator and avatar badges, and allows collapsing/expanding the discussion notes', :quarantine do
+        it 'shows indicator and avatar badges, and allows collapsing/expanding the discussion notes', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27950' do
           indicator = find('.js-image-badge', match: :first)
           badge = find('.user-avatar-link .badge', match: :first)
 

spec/features/merge_request/user_posts_diff_notes_spec.rb

@@ -46,7 +46,7 @@ RSpec.describe 'Merge request > User posts diff notes', :js do
     end
 
     context 'with an old line on the left and a new line on the right' do
-      it 'allows commenting on the left side', quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/199050' do
+      it 'allows commenting on the left side', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/199050' do
         should_allow_commenting(find('[id="2f6fcd96b88b36ce98c38da085c795a27d92a3dd_9_9"]').find(:xpath, '..'), 'left')
       end
 
@@ -56,7 +56,7 @@ RSpec.describe 'Merge request > User posts diff notes', :js do
     end
 
     context 'with an unchanged line on the left and an unchanged line on the right' do
-      it 'allows commenting on the left side', quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/196826' do
+      it 'allows commenting on the left side', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/196826' do
         should_allow_commenting(find('[id="2f6fcd96b88b36ce98c38da085c795a27d92a3dd_7_7"]', match: :first).find(:xpath, '..'), 'left')
       end
 

spec/features/merge_request/user_sees_diff_spec.rb

@@ -72,7 +72,7 @@ RSpec.describe 'Merge request > User sees diff', :js do
     end
 
     context 'as user who needs to fork' do
-      it 'shows fork/cancel confirmation', :sidekiq_might_not_need_inline, quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/196749' do
+      it 'shows fork/cancel confirmation', :sidekiq_might_not_need_inline, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/196749' do
         sign_in(user)
         visit diffs_project_merge_request_path(project, merge_request)
 

spec/features/merge_request/user_suggests_changes_on_diff_spec.rb

@@ -188,8 +188,7 @@ RSpec.describe 'User comments on a diff', :js do
   end
 
   context 'multiple suggestions in expanded lines' do
-    # https://gitlab.com/gitlab-org/gitlab/issues/38277
-    it 'suggestions are appliable', :quarantine do
+    it 'suggestions are appliable', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/38277' do
       diff_file = merge_request.diffs(paths: ['files/ruby/popen.rb']).diff_files.first
       hash = Digest::SHA1.hexdigest(diff_file.file_path)
 

spec/features/profiles/user_visits_profile_preferences_page_spec.rb

@@ -65,7 +65,7 @@ RSpec.describe 'User visits the profile preferences page' do
   end
 
   describe 'User changes their language', :js do
-    it 'creates a flash message', :quarantine do
+    it 'creates a flash message', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/31404' do
       select2('en', from: '#user_preferred_language')
       click_button 'Save'
 

spec/features/projects/members/member_leaves_project_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe 'Projects > Members > Member leaves project' do
     expect(project.users.exists?(user.id)).to be_falsey
   end
 
-  it 'user leaves project by url param', :js, :quarantine do
+  it 'user leaves project by url param', :js, quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/35925' do
     visit project_path(project, leave: 1)
 
     page.accept_confirm

spec/features/users/signup_spec.rb

@@ -98,7 +98,7 @@ RSpec.shared_examples 'Signup' do
       expect(page).to have_content("Invalid input, please avoid emojis")
     end
 
-    it 'shows a pending message if the username availability is being fetched', :quarantine do
+    it 'shows a pending message if the username availability is being fetched', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/31484' do
       fill_in 'new_user_username', with: 'new-user'
 
       expect(find('.username > .validation-pending')).not_to have_css '.hide'

spec/lib/gitlab/background_migration/migrate_build_stage_spec.rb

@@ -55,7 +55,7 @@ RSpec.describe Gitlab::BackgroundMigration::MigrateBuildStage do
                                                       statuses[:pending]]
   end
 
-  it 'recovers from unique constraint violation only twice', :quarantine do
+  it 'recovers from unique constraint violation only twice', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/28128' do
     allow(described_class::Migratable::Stage)
       .to receive(:find_by).and_return(nil)
 

spec/services/quick_actions/interpret_service_spec.rb

@@ -792,7 +792,7 @@ RSpec.describe QuickActions::InterpretService do
         let(:issuable) { issue }
       end
 
-      it_behaves_like 'assign command', :quarantine do
+      it_behaves_like 'assign command', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/27989' do
         let(:content) { "/assign @#{developer.username} @#{developer2.username}" }
         let(:issuable) { merge_request }
       end

spec/support/shared_examples/features/discussion_comments_shared_example.rb

@@ -266,7 +266,7 @@ RSpec.shared_examples 'thread comments' do |resource_name|
             end
           end
 
-          it 'has "Comment" selected when opening the menu', quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/196825' do
+          it 'has "Comment" selected when opening the menu', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/196825' do
             find(toggle_selector).click
 
             find("#{menu_selector} li", match: :first)