Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
2ec14175
Commit
2ec14175
authored
Apr 03, 2020
by
Rajendra Kadam
Committed by
Igor Drozdov
Apr 03, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove incomplete and duplicate spec from changelog specs
parent
994cb7e7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
14 deletions
+6
-14
.rubocop.yml
.rubocop.yml
+0
-1
changelogs/unreleased/changelog-spec.yml
changelogs/unreleased/changelog-spec.yml
+5
-0
spec/lib/gitlab/danger/changelog_spec.rb
spec/lib/gitlab/danger/changelog_spec.rb
+1
-13
No files found.
.rubocop.yml
View file @
2ec14175
...
...
@@ -398,7 +398,6 @@ RSpec/RepeatedExample:
-
'
spec/graphql/gitlab_schema_spec.rb'
-
'
spec/helpers/users_helper_spec.rb'
-
'
spec/lib/gitlab/closing_issue_extractor_spec.rb'
-
'
spec/lib/gitlab/danger/changelog_spec.rb'
-
'
spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
-
'
spec/routing/admin_routing_spec.rb'
-
'
spec/rubocop/cop/migration/update_large_table_spec.rb'
...
...
changelogs/unreleased/changelog-spec.yml
0 → 100644
View file @
2ec14175
---
title
:
Remove duplicate spec from changelog spec
merge_request
:
28801
author
:
Rajendra Kadam
type
:
added
spec/lib/gitlab/danger/changelog_spec.rb
View file @
2ec14175
...
...
@@ -28,18 +28,6 @@ describe Gitlab::Danger::Changelog do
describe
'#needed?'
do
subject
{
changelog
.
needed?
}
[
{
docs:
nil
},
{
none:
nil
},
{
docs:
nil
,
none:
nil
}
].
each
do
|
categories
|
let
(
:changes_by_category
)
{
categories
}
it
"is falsy when categories don't require a changelog"
do
is_expected
.
to
be_falsy
end
end
where
(
:categories
,
:labels
)
do
{
backend:
nil
}
|
%w[backend backstage]
{
frontend:
nil
,
docs:
nil
}
|
[
'ci-build'
]
...
...
@@ -50,7 +38,7 @@ describe Gitlab::Danger::Changelog do
let
(
:changes_by_category
)
{
categories
}
let
(
:mr_labels
)
{
labels
}
it
"is falsy when labels require no changelog"
do
it
"is falsy when
categories and
labels require no changelog"
do
is_expected
.
to
be_falsy
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment