Commit 2ec14175 authored by Rajendra Kadam's avatar Rajendra Kadam Committed by Igor Drozdov

Remove incomplete and duplicate spec from changelog specs

parent 994cb7e7
...@@ -398,7 +398,6 @@ RSpec/RepeatedExample: ...@@ -398,7 +398,6 @@ RSpec/RepeatedExample:
- 'spec/graphql/gitlab_schema_spec.rb' - 'spec/graphql/gitlab_schema_spec.rb'
- 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb'
- 'spec/lib/gitlab/closing_issue_extractor_spec.rb' - 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
- 'spec/lib/gitlab/danger/changelog_spec.rb'
- 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
- 'spec/routing/admin_routing_spec.rb' - 'spec/routing/admin_routing_spec.rb'
- 'spec/rubocop/cop/migration/update_large_table_spec.rb' - 'spec/rubocop/cop/migration/update_large_table_spec.rb'
......
---
title: Remove duplicate spec from changelog spec
merge_request: 28801
author: Rajendra Kadam
type: added
...@@ -28,18 +28,6 @@ describe Gitlab::Danger::Changelog do ...@@ -28,18 +28,6 @@ describe Gitlab::Danger::Changelog do
describe '#needed?' do describe '#needed?' do
subject { changelog.needed? } subject { changelog.needed? }
[
{ docs: nil },
{ none: nil },
{ docs: nil, none: nil }
].each do |categories|
let(:changes_by_category) { categories }
it "is falsy when categories don't require a changelog" do
is_expected.to be_falsy
end
end
where(:categories, :labels) do where(:categories, :labels) do
{ backend: nil } | %w[backend backstage] { backend: nil } | %w[backend backstage]
{ frontend: nil, docs: nil } | ['ci-build'] { frontend: nil, docs: nil } | ['ci-build']
...@@ -50,7 +38,7 @@ describe Gitlab::Danger::Changelog do ...@@ -50,7 +38,7 @@ describe Gitlab::Danger::Changelog do
let(:changes_by_category) { categories } let(:changes_by_category) { categories }
let(:mr_labels) { labels } let(:mr_labels) { labels }
it "is falsy when labels require no changelog" do it "is falsy when categories and labels require no changelog" do
is_expected.to be_falsy is_expected.to be_falsy
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment