Commit 445de9c5 authored by Simon Knox's avatar Simon Knox

Merge branch '293894-remove-font-awesome-from-fe-guidelines' into 'master'

Remove Font Awesome from FE guidelines

See merge request gitlab-org/gitlab!50085
parents cc60b39d d3bf38a3
...@@ -8,12 +8,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w ...@@ -8,12 +8,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w
## Package manager ## Package manager
We use [Yarn](https://yarnpkg.com/) to manage frontend dependencies. There are a few exceptions: We use [Yarn](https://yarnpkg.com/) to manage frontend dependencies. There are a few exceptions, stored in `vendor/assets/`.
- [FontAwesome](https://fontawesome.com/), installed via the `font-awesome-rails` gem: we are working to replace it with
[GitLab SVGs](https://gitlab-org.gitlab.io/gitlab-svgs/) icons library.
- [ACE](https://ace.c9.io/) editor, installed via the `ace-rails-ap` gem.
- Other dependencies found under `vendor/assets/`.
## Updating dependencies ## Updating dependencies
......
...@@ -18,8 +18,6 @@ We are using SVG Icons in GitLab with a SVG Sprite. ...@@ -18,8 +18,6 @@ We are using SVG Icons in GitLab with a SVG Sprite.
This means the icons are only loaded once, and are referenced through an ID. This means the icons are only loaded once, and are referenced through an ID.
The sprite SVG is located under `/assets/icons.svg`. The sprite SVG is located under `/assets/icons.svg`.
Our goal is to replace one by one all inline SVG Icons (as those currently bloat the HTML) and also all Font Awesome icons.
### Usage in HAML/Rails ### Usage in HAML/Rails
To use a sprite Icon in HAML or Rails we use a specific helper function: To use a sprite Icon in HAML or Rails we use a specific helper function:
...@@ -90,11 +88,6 @@ Please use the following function inside JS to render an icon: ...@@ -90,11 +88,6 @@ Please use the following function inside JS to render an icon:
### Usage in HAML/Rails ### Usage in HAML/Rails
WARNING:
Do not use the `spinner` or `icon('spinner spin')` rails helpers to insert
loading icons. These helpers rely on the Font Awesome icon library which is
deprecated.
To insert a loading spinner in HAML or Rails use the `loading_icon` helper: To insert a loading spinner in HAML or Rails use the `loading_icon` helper:
```haml ```haml
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment