Commit 680f4b18 authored by Peter Leitzen's avatar Peter Leitzen

Merge branch 'ali/require-pi-review-for-snowplow-events' into 'master'

Require Product Intelligence reviews for backend Snowplow events

See merge request gitlab-org/gitlab!53915
parents 5069bb02 7827b4d0
...@@ -45,9 +45,13 @@ usage_data_changed_files = all_changed_files.grep(%r{(usage_data)}) ...@@ -45,9 +45,13 @@ usage_data_changed_files = all_changed_files.grep(%r{(usage_data)})
metrics_changed_files = all_changed_files.grep(%r{((ee/)?config/metrics/.*\.yml)}) metrics_changed_files = all_changed_files.grep(%r{((ee/)?config/metrics/.*\.yml)})
dictionary_changed_file = all_changed_files.grep(%r{(doc/development/usage_ping/dictionary.md)}) dictionary_changed_file = all_changed_files.grep(%r{(doc/development/usage_ping/dictionary.md)})
usage_changed_files = usage_data_changed_files + tracking_changed_files + metrics_changed_files + dictionary_changed_file snowplow_changed_files = all_changed_files.select do |file|
helper.changed_lines(file).grep(%r{Gitlab::Tracking\.event}).any?
end
matching_changed_files = usage_data_changed_files + tracking_changed_files + metrics_changed_files + dictionary_changed_file + snowplow_changed_files
if usage_changed_files.any? if matching_changed_files.any?
mention = if helper.draft_mr? mention = if helper.draft_mr?
"`#{ENGINEERS_GROUP}`" "`#{ENGINEERS_GROUP}`"
...@@ -55,7 +59,7 @@ if usage_changed_files.any? ...@@ -55,7 +59,7 @@ if usage_changed_files.any?
ENGINEERS_GROUP ENGINEERS_GROUP
end end
warn format(CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(usage_changed_files), engineers_group: mention) warn format(CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(matching_changed_files), engineers_group: mention)
warn format(UPDATE_METRICS_DEFINITIONS_MESSAGE) if usage_data_changed_files.any? warn format(UPDATE_METRICS_DEFINITIONS_MESSAGE) if usage_data_changed_files.any?
fail format(UPDATE_DICTIONARY_MESSAGE) if metrics_changed_files.any? && dictionary_changed_file.empty? fail format(UPDATE_DICTIONARY_MESSAGE) if metrics_changed_files.any? && dictionary_changed_file.empty?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment