Merge branch 'jf_stop_overwriting_stdout' into 'master'

Add silence_stdout option to explicitly redirect stdout in rake task specs [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!62536

doc/development/testing_guide/testing_rake_tasks.md

@@ -11,19 +11,21 @@ in lieu of the standard Spec helper. Instead of `require 'spec_helper'`, use
 `require 'rake_helper'`. The helper includes `spec_helper` for you, and configures
 a few other things to make testing Rake tasks easier.
 
-At a minimum, requiring the Rake helper redirects `stdout`, include the
-runtime task helpers, and include the `RakeHelpers` Spec support module.
+At a minimum, requiring the Rake helper includes the runtime task helpers, and
+includes the `RakeHelpers` Spec support module.
 
 The `RakeHelpers` module exposes a `run_rake_task(<task>)` method to make
 executing tasks simple. See `spec/support/helpers/rake_helpers.rb` for all available
 methods.
 
+`$stdout` can be redirected by adding `:silence_stdout`.
+
 Example:
 
 ```ruby
 require 'rake_helper'
 
-describe 'gitlab:shell rake tasks' do
+describe 'gitlab:shell rake tasks', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/shell'
 

ee/spec/lib/system_check/geo/authorized_keys_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
 
-RSpec.describe SystemCheck::Geo::AuthorizedKeysCheck do
+RSpec.describe SystemCheck::Geo::AuthorizedKeysCheck, :silence_stdout do
   describe '#multi_check' do
     subject { described_class.new }
 

ee/spec/lib/system_check/geo/authorized_keys_flag_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
-
-RSpec.describe SystemCheck::Geo::AuthorizedKeysFlagCheck do
-  before do
-    silence_output
-  end
 
+RSpec.describe SystemCheck::Geo::AuthorizedKeysFlagCheck, :silence_stdout do
   describe '#check?' do
     it 'fails when write to authorized_keys still enabled' do
       stub_application_setting(authorized_keys_enabled: true)

ee/spec/lib/system_check/geo/current_node_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
 
-RSpec.describe SystemCheck::Geo::CurrentNodeCheck, :geo do
+RSpec.describe SystemCheck::Geo::CurrentNodeCheck, :geo, :silence_stdout do
   describe '#check?' do
     context 'when the current machine has a matching GeoNode' do
       it 'returns true' do

ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
-
-RSpec.describe SystemCheck::Geo::GeoDatabaseConfiguredCheck do
-  before do
-    silence_output
-  end
 
+RSpec.describe SystemCheck::Geo::GeoDatabaseConfiguredCheck, :silence_stdout do
   subject { described_class.new }
 
   describe '#multi_check' do

ee/spec/tasks/geo_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'geo rake tasks', :geo do
+RSpec.describe 'geo rake tasks', :geo, :silence_stdout do
   include ::EE::GeoHelpers
 
   before do

ee/spec/tasks/gitlab/check_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'EE check.rake' do
+RSpec.describe 'EE check.rake', :silence_stdout do
   before do
     Rake.application.rake_require 'ee/lib/tasks/gitlab/check', [Rails.root.to_s]
 

ee/spec/tasks/gitlab/elastic_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:elastic namespace rake tasks', :elastic do
+RSpec.describe 'gitlab:elastic namespace rake tasks', :elastic, :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/elastic'
   end

ee/spec/tasks/gitlab/geo_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:geo rake tasks', :geo do
+RSpec.describe 'gitlab:geo rake tasks', :geo, :silence_stdout do
   include ::EE::GeoHelpers
 
   before do

ee/spec/tasks/gitlab/license_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:license namespace rake tasks' do
+RSpec.describe 'gitlab:license namespace rake tasks', :silence_stdout do
   let(:default_license_path) { Settings.source.dirname + 'Gitlab.gitlab-license' }
 
   before do

ee/spec/tasks/gitlab/seed/group_seed_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:seed:group_seed rake task' do
+RSpec.describe 'gitlab:seed:group_seed rake task', :silence_stdout do
   let(:username) { 'group_seed' }
   let!(:user) { create(:user, username: username) }
   let(:task_params) { [2, username] }

ee/spec/tasks/gitlab/spdx_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:rake tasks' do
+RSpec.describe 'gitlab:rake tasks', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/spdx'
   end

ee/spec/tasks/gitlab/uploads/migrate_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:uploads:migrate and migrate_to_local rake tasks' do
+RSpec.describe 'gitlab:uploads:migrate and migrate_to_local rake tasks', :silence_stdout do
   let(:model_class) { nil }
   let(:uploader_class) { nil }
   let(:mounted_as) { nil }

spec/generator_helper.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.configure do |config|
-  # Redirect stdout so specs don't have so much noise
-  config.before(:all) do
-    $stdout = StringIO.new
-  end
-
-  # Reset stdout
-  config.after(:all) do
-    $stdout = STDOUT
-  end
-end

spec/lib/generators/gitlab/snowplow_event_definition_generator_spec.rb

 # frozen_string_literal: true
 
-require 'generator_helper'
+require 'spec_helper'
 
-RSpec.describe Gitlab::SnowplowEventDefinitionGenerator do
+RSpec.describe Gitlab::SnowplowEventDefinitionGenerator, :silence_stdout do
   let(:ce_temp_dir) { Dir.mktmpdir }
   let(:ee_temp_dir) { Dir.mktmpdir }
   let(:generator_options) { { 'category' => 'Groups::EmailCampaignsController', 'action' => 'click' } }

spec/lib/generators/gitlab/usage_metric_definition/redis_hll_generator_spec.rb

 # frozen_string_literal: true
 
-require 'generator_helper'
+require 'spec_helper'
 
-RSpec.describe Gitlab::UsageMetricDefinition::RedisHllGenerator do
+RSpec.describe Gitlab::UsageMetricDefinition::RedisHllGenerator, :silence_stdout do
   include UsageDataHelpers
 
   let(:category) { 'test_category' }

spec/lib/generators/gitlab/usage_metric_definition_generator_spec.rb

 # frozen_string_literal: true
 
-require 'generator_helper'
+require 'spec_helper'
 
-RSpec.describe Gitlab::UsageMetricDefinitionGenerator do
+RSpec.describe Gitlab::UsageMetricDefinitionGenerator, :silence_stdout do
   include UsageDataHelpers
 
   let(:key_path) { 'counts_weekly.test_metric' }

spec/lib/gitlab/import_export/project/export_task_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe Gitlab::ImportExport::Project::ExportTask do
+RSpec.describe Gitlab::ImportExport::Project::ExportTask, :silence_stdout do
   let_it_be(:username) { 'root' }
   let(:namespace_path) { username }
   let_it_be(:user) { create(:user, username: username) }

spec/lib/gitlab/import_export/project/import_task_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe Gitlab::ImportExport::Project::ImportTask, :request_store do
+RSpec.describe Gitlab::ImportExport::Project::ImportTask, :request_store, :silence_stdout do
   let(:username) { 'root' }
   let(:namespace_path) { username }
   let!(:user) { create(:user, username: username) }

spec/lib/system_check/app/hashed_storage_all_projects_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
-
-RSpec.describe SystemCheck::App::HashedStorageAllProjectsCheck do
-  before do
-    silence_output
-  end
 
+RSpec.describe SystemCheck::App::HashedStorageAllProjectsCheck, :silence_stdout do
   describe '#check?' do
     it 'fails when at least one project is in legacy storage' do
       create(:project, :legacy_storage)

spec/lib/system_check/app/hashed_storage_enabled_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
-
-RSpec.describe SystemCheck::App::HashedStorageEnabledCheck do
-  before do
-    silence_output
-  end
 
+RSpec.describe SystemCheck::App::HashedStorageEnabledCheck, :silence_stdout do
   describe '#check?' do
     it 'fails when hashed storage is disabled' do
       stub_application_setting(hashed_storage_enabled: false)

spec/lib/system_check/orphans/namespace_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
 
-RSpec.describe SystemCheck::Orphans::NamespaceCheck do
+RSpec.describe SystemCheck::Orphans::NamespaceCheck, :silence_stdout do
   let(:storages) { Gitlab.config.repositories.storages.reject { |key, _| key.eql? 'broken' } }
 
   before do
     allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
     allow(subject).to receive(:fetch_disk_namespaces).and_return(disk_namespaces)
-    silence_output
   end
 
   describe '#multi_check' do

spec/lib/system_check/orphans/repository_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
 
-RSpec.describe SystemCheck::Orphans::RepositoryCheck do
+RSpec.describe SystemCheck::Orphans::RepositoryCheck, :silence_stdout do
   let(:storages) { Gitlab.config.repositories.storages.reject { |key, _| key.eql? 'broken' } }
 
   before do
     allow(Gitlab.config.repositories).to receive(:storages).and_return(storages)
     allow(subject).to receive(:fetch_disk_namespaces).and_return(disk_namespaces)
     allow(subject).to receive(:fetch_disk_repositories).and_return(disk_repositories)
-    # silence_output
   end
 
   describe '#multi_check' do

spec/lib/system_check/simple_executor_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
 
-RSpec.describe SystemCheck::SimpleExecutor do
+RSpec.describe SystemCheck::SimpleExecutor, :silence_stdout do
   before do
     stub_const('SimpleCheck', Class.new(SystemCheck::BaseCheck))
     stub_const('OtherCheck', Class.new(SystemCheck::BaseCheck))
@@ -154,8 +153,6 @@ RSpec.describe SystemCheck::SimpleExecutor do
 
   describe '#execute' do
     before do
-      silence_output
-
       subject << SimpleCheck
       subject << OtherCheck
     end

spec/lib/system_check_spec.rb

 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'rake_helper'
 
-RSpec.describe SystemCheck do
+RSpec.describe SystemCheck, :silence_stdout do
   before do
     stub_const('SimpleCheck', Class.new(SystemCheck::BaseCheck))
     stub_const('OtherCheck', Class.new(SystemCheck::BaseCheck))
@@ -19,8 +18,6 @@ RSpec.describe SystemCheck do
         false
       end
     end
-
-    silence_output
   end
 
   describe '.run' do

spec/rake_helper.rb

@@ -6,18 +6,12 @@ require 'rake'
 RSpec.configure do |config|
   config.include RakeHelpers
 
-  # Redirect stdout so specs don't have so much noise
   config.before(:all) do
-    $stdout = StringIO.new
-
     Rake.application.rake_require 'tasks/gitlab/helpers'
     Rake::Task.define_task :environment
   end
 
-  # Reset stdout
   config.after(:all) do
-    $stdout = STDOUT
-
     delete_from_all_tables!
   end
 end

spec/spec_helper.rb

@@ -403,6 +403,15 @@ RSpec.configure do |config|
     end
   end
 
+  # Allows stdout to be redirected to reduce noise
+  config.before(:each, :silence_stdout) do
+    $stdout = StringIO.new
+  end
+
+  config.after(:each, :silence_stdout) do
+    $stdout = STDOUT
+  end
+
   config.disable_monkey_patching!
 end
 

spec/support/helpers/rake_helpers.rb

@@ -10,11 +10,6 @@ module RakeHelpers
     allow(main_object).to receive(:warn_user_is_not_gitlab)
   end
 
-  def silence_output
-    allow(main_object).to receive(:puts)
-    allow(main_object).to receive(:print)
-  end
-
   def silence_progress_bar
     allow_any_instance_of(ProgressBar::Output).to receive(:stream).and_return(double.as_null_object)
   end

spec/tasks/admin_mode_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'admin mode on tasks' do
+RSpec.describe 'admin mode on tasks', :silence_stdout do
   before do
     allow(::Gitlab::Runtime).to receive(:test_suite?).and_return(false)
     allow(::Gitlab::Runtime).to receive(:rake?).and_return(true)

spec/tasks/cache/clear/redis_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'clearing redis cache', :clean_gitlab_redis_cache do
+RSpec.describe 'clearing redis cache', :clean_gitlab_redis_cache, :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/cache'
   end

spec/tasks/config_lint_spec.rb

@@ -3,7 +3,7 @@
 require 'rake_helper'
 Rake.application.rake_require 'tasks/config_lint'
 
-RSpec.describe ConfigLint do
+RSpec.describe ConfigLint, :silence_stdout do
   let(:files) { ['lib/support/fake.sh'] }
 
   it 'errors out if any bash scripts have errors' do
@@ -15,7 +15,7 @@ RSpec.describe ConfigLint do
   end
 end
 
-RSpec.describe 'config_lint rake task' do
+RSpec.describe 'config_lint rake task', :silence_stdout do
   before do
     # Prevent `system` from actually being called
     allow(Kernel).to receive(:system).and_return(true)

spec/tasks/gettext_rake_spec.rb

 # frozen_string_literal: true
 
-require "rake_helper"
+require 'rake_helper'
 
-RSpec.describe 'gettext' do
+RSpec.describe 'gettext', :silence_stdout do
   let(:locale_path) { Rails.root.join('tmp/gettext_spec') }
   let(:pot_file_path) { File.join(locale_path, 'gitlab.pot') }
 

spec/tasks/gitlab/artifacts/check_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:artifacts rake tasks' do
+RSpec.describe 'gitlab:artifacts rake tasks', :silence_stdout do
   describe 'check' do
     let!(:artifact) { create(:ci_job_artifact, :archive, :correct_checksum) }
 

spec/tasks/gitlab/artifacts/migrate_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:artifacts namespace rake task' do
+RSpec.describe 'gitlab:artifacts namespace rake task', :silence_stdout do
   before(:context) do
     Rake.application.rake_require 'tasks/gitlab/artifacts/migrate'
   end

spec/tasks/gitlab/check_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'check.rake' do
+RSpec.describe 'check.rake', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/check'
 

spec/tasks/gitlab/cleanup_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:cleanup rake tasks' do
+RSpec.describe 'gitlab:cleanup rake tasks', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/cleanup'
   end

spec/tasks/gitlab/container_registry_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:container_registry namespace rake tasks' do
+RSpec.describe 'gitlab:container_registry namespace rake tasks', :silence_stdout do
   let_it_be(:api_url) { 'http://registry.gitlab' }
 
   before :all do

spec/tasks/gitlab/db_rake_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require 'rake'
 
-RSpec.describe 'gitlab:db namespace rake task' do
+RSpec.describe 'gitlab:db namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'active_record/railties/databases'
     Rake.application.rake_require 'tasks/seed_fu'

spec/tasks/gitlab/external_diffs_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:external_diffs rake tasks' do
+RSpec.describe 'gitlab:external_diffs rake tasks', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/external_diffs'
   end

spec/tasks/gitlab/generate_sample_prometheus_data_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:generate_sample_prometheus_data rake task' do
+RSpec.describe 'gitlab:generate_sample_prometheus_data rake task', :silence_stdout do
   let(:cluster) { create(:cluster, :provided_by_user, :project) }
   let(:environment) { create(:environment, project: cluster.project) }
   let(:sample_query_file) { File.join(Rails.root, Metrics::SampleMetricsService::DIRECTORY, 'test_query_result.yml') }

spec/tasks/gitlab/git_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:git rake tasks' do
+RSpec.describe 'gitlab:git rake tasks', :silence_stdout do
   let(:base_path) { 'tmp/tests/default_storage' }
   let!(:project) { create(:project, :repository) }
 

spec/tasks/gitlab/gitaly_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:gitaly namespace rake task' do
+RSpec.describe 'gitlab:gitaly namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'tasks/gitlab/gitaly'
   end

spec/tasks/gitlab/info_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:env:info' do
+RSpec.describe 'gitlab:env:info', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/info'
 

spec/tasks/gitlab/ldap_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:ldap:rename_provider rake task' do
+RSpec.describe 'gitlab:ldap:rename_provider rake task', :silence_stdout do
   it 'completes without error' do
     Rake.application.rake_require 'tasks/gitlab/ldap'
     stub_warn_user_is_not_gitlab

spec/tasks/gitlab/lfs/check_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:lfs rake tasks' do
+RSpec.describe 'gitlab:lfs rake tasks', :silence_stdout do
   describe 'check' do
     let!(:lfs_object) { create(:lfs_object, :with_file, :correct_oid) }
 

spec/tasks/gitlab/lfs/migrate_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:lfs namespace rake task' do
+RSpec.describe 'gitlab:lfs namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'tasks/gitlab/lfs/migrate'
   end

spec/tasks/gitlab/packages/composer_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:packages:build_composer_cache namespace rake task' do
+RSpec.describe 'gitlab:packages:build_composer_cache namespace rake task', :silence_stdout do
   let_it_be(:package_name) { 'sample-project' }
   let_it_be(:package_name2) { 'sample-project2' }
   let_it_be(:json) { { 'name' => package_name } }

spec/tasks/gitlab/packages/events_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:packages:events namespace rake task' do
+RSpec.describe 'gitlab:packages:events namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'tasks/gitlab/packages/events'
   end

spec/tasks/gitlab/packages/migrate_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:packages namespace rake task' do
+RSpec.describe 'gitlab:packages namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'tasks/gitlab/packages/migrate'
   end

spec/tasks/gitlab/pages_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:pages' do
+RSpec.describe 'gitlab:pages', :silence_stdout do
   before(:context) do
     Rake.application.rake_require 'tasks/gitlab/pages'
   end

spec/tasks/gitlab/password_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:password rake tasks' do
+RSpec.describe 'gitlab:password rake tasks', :silence_stdout do
   let_it_be(:user_1) { create(:user, username: 'foobar', password: 'initial_password') }
 
   def stub_username(username)

spec/tasks/gitlab/praefect_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:praefect:replicas' do
+RSpec.describe 'gitlab:praefect:replicas', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/praefect'
   end

spec/tasks/gitlab/seed/group_seed_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:seed:group_seed rake task' do
+RSpec.describe 'gitlab:seed:group_seed rake task', :silence_stdout do
   let(:username) { 'group_seed' }
   let!(:user) { create(:user, username: username) }
   let(:task_params) { [2, username] }

spec/tasks/gitlab/shell_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:shell rake tasks' do
+RSpec.describe 'gitlab:shell rake tasks', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/shell'
 

spec/tasks/gitlab/sidekiq_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'sidekiq.rake', :aggregate_failures do
+RSpec.describe 'sidekiq.rake', :aggregate_failures, :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/sidekiq'
 

spec/tasks/gitlab/snippets_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:snippets namespace rake task' do
+RSpec.describe 'gitlab:snippets namespace rake task', :silence_stdout do
   let_it_be(:user) { create(:user)}
   let_it_be(:migrated) { create(:personal_snippet, :repository, author: user) }
   let(:non_migrated) { create_list(:personal_snippet, 3, author: user) }

spec/tasks/gitlab/storage_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'rake gitlab:storage:*' do
+RSpec.describe 'rake gitlab:storage:*', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/storage'
 

spec/tasks/gitlab/terraform/migrate_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:terraform_states' do
+RSpec.describe 'gitlab:terraform_states', :silence_stdout do
   let_it_be(:version) { create(:terraform_state_version) }
 
   let(:logger) { instance_double(Logger) }

spec/tasks/gitlab/update_templates_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:update_project_templates rake task' do
+RSpec.describe 'gitlab:update_project_templates rake task', :silence_stdout do
   let!(:tmpdir) { Dir.mktmpdir }
 
   before do

spec/tasks/gitlab/uploads/check_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:uploads rake tasks' do
+RSpec.describe 'gitlab:uploads rake tasks', :silence_stdout do
   describe 'check' do
     let!(:upload) { create(:upload, path: Rails.root.join('spec/fixtures/banana_sample.gif')) }
 

spec/tasks/gitlab/uploads/migrate_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:uploads:migrate and migrate_to_local rake tasks' do
+RSpec.describe 'gitlab:uploads:migrate and migrate_to_local rake tasks', :silence_stdout do
   let(:model_class) { nil }
   let(:uploader_class) { nil }
   let(:mounted_as) { nil }

spec/tasks/gitlab/usage_data_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:usage data take tasks' do
+RSpec.describe 'gitlab:usage data take tasks', :silence_stdout do
   include UsageDataHelpers
 
   before do

spec/tasks/gitlab/user_management_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:user_management tasks' do
+RSpec.describe 'gitlab:user_management tasks', :silence_stdout do
   before do
     Rake.application.rake_require 'tasks/gitlab/user_management'
   end

spec/tasks/gitlab/web_hook_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:web_hook namespace rake tasks' do
+RSpec.describe 'gitlab:web_hook namespace rake tasks', :silence_stdout do
   let_it_be(:group, refind: true) { create(:group) }
   let_it_be(:project1, reload: true) { create(:project, namespace: group) }
   let_it_be(:project2, reload: true) { create(:project, namespace: group) }

spec/tasks/gitlab/workhorse_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:workhorse namespace rake task' do
+RSpec.describe 'gitlab:workhorse namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'tasks/gitlab/workhorse'
   end

spec/tasks/gitlab/x509/update_rake_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'gitlab:x509 namespace rake task' do
+RSpec.describe 'gitlab:x509 namespace rake task', :silence_stdout do
   before :all do
     Rake.application.rake_require 'tasks/gitlab/x509/update'
   end

spec/tasks/migrate/schema_check_rake_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 require 'rake'
 
-RSpec.describe 'schema_version_check rake task' do
+RSpec.describe 'schema_version_check rake task', :silence_stdout do
   include StubENV
 
   before :all do

spec/tasks/tokens_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rake_helper'
 
-RSpec.describe 'tokens rake tasks' do
+RSpec.describe 'tokens rake tasks', :silence_stdout do
   let!(:user) { create(:user) }
 
   before do