Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a8d909c3
Commit
a8d909c3
authored
Nov 24, 2021
by
Dmitry Gruzd
Committed by
Terri Chu
Nov 24, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Advanced Search: Enable group level optimization
parent
f148847a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
42 deletions
+3
-42
ee/config/feature_flags/development/elasticsearch_use_group_level_optimization.yml
...evelopment/elasticsearch_use_group_level_optimization.yml
+0
-8
ee/lib/elastic/latest/issue_class_proxy.rb
ee/lib/elastic/latest/issue_class_proxy.rb
+0
-1
ee/spec/services/search/group_service_spec.rb
ee/spec/services/search/group_service_spec.rb
+3
-33
No files found.
ee/config/feature_flags/development/elasticsearch_use_group_level_optimization.yml
deleted
100644 → 0
View file @
f148847a
---
name
:
elasticsearch_use_group_level_optimization
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69741
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/340596
milestone
:
'
14.4'
type
:
development
group
:
group::global search
default_enabled
:
false
ee/lib/elastic/latest/issue_class_proxy.rb
View file @
a8d909c3
...
...
@@ -60,7 +60,6 @@ module Elastic
def
should_use_project_ids_filter?
(
options
)
options
[
:project_ids
]
==
:any
||
options
[
:group_ids
].
blank?
||
Feature
.
disabled?
(
:elasticsearch_use_group_level_optimization
)
||
!
Elastic
::
DataMigrationService
.
migration_has_finished?
(
:redo_backfill_namespace_ancestry_ids_for_issues
)
end
...
...
ee/spec/services/search/group_service_spec.rb
View file @
a8d909c3
...
...
@@ -206,24 +206,8 @@ RSpec.describe Search::GroupService do
permission_table_for_guest_feature_access
end
context
'elasticsearch_use_group_level_optimization is enabled'
do
before
do
stub_feature_flags
(
elasticsearch_use_group_level_optimization:
true
)
end
with_them
do
it_behaves_like
'search respects visibility'
end
end
context
'elasticsearch_use_group_level_optimization is disabled'
do
before
do
stub_feature_flags
(
elasticsearch_use_group_level_optimization:
false
)
end
with_them
do
it_behaves_like
'search respects visibility'
end
with_them
do
it_behaves_like
'search respects visibility'
end
end
...
...
@@ -319,21 +303,7 @@ RSpec.describe Search::GroupService do
ensure_elasticsearch_index!
end
context
'elasticsearch_use_group_level_optimization is enabled'
do
before
do
stub_feature_flags
(
elasticsearch_use_group_level_optimization:
true
)
end
include_examples
'search results sorted'
end
context
'elasticsearch_use_group_level_optimization is disabled'
do
before
do
stub_feature_flags
(
elasticsearch_use_group_level_optimization:
false
)
end
include_examples
'search results sorted'
end
include_examples
'search results sorted'
end
context
'merge requests'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment