Commit a8d909c3 authored by Dmitry Gruzd's avatar Dmitry Gruzd Committed by Terri Chu

Advanced Search: Enable group level optimization

parent f148847a
---
name: elasticsearch_use_group_level_optimization
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69741
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/340596
milestone: '14.4'
type: development
group: group::global search
default_enabled: false
...@@ -60,7 +60,6 @@ module Elastic ...@@ -60,7 +60,6 @@ module Elastic
def should_use_project_ids_filter?(options) def should_use_project_ids_filter?(options)
options[:project_ids] == :any || options[:project_ids] == :any ||
options[:group_ids].blank? || options[:group_ids].blank? ||
Feature.disabled?(:elasticsearch_use_group_level_optimization) ||
!Elastic::DataMigrationService.migration_has_finished?(:redo_backfill_namespace_ancestry_ids_for_issues) !Elastic::DataMigrationService.migration_has_finished?(:redo_backfill_namespace_ancestry_ids_for_issues)
end end
......
...@@ -206,24 +206,8 @@ RSpec.describe Search::GroupService do ...@@ -206,24 +206,8 @@ RSpec.describe Search::GroupService do
permission_table_for_guest_feature_access permission_table_for_guest_feature_access
end end
context 'elasticsearch_use_group_level_optimization is enabled' do with_them do
before do it_behaves_like 'search respects visibility'
stub_feature_flags(elasticsearch_use_group_level_optimization: true)
end
with_them do
it_behaves_like 'search respects visibility'
end
end
context 'elasticsearch_use_group_level_optimization is disabled' do
before do
stub_feature_flags(elasticsearch_use_group_level_optimization: false)
end
with_them do
it_behaves_like 'search respects visibility'
end
end end
end end
...@@ -319,21 +303,7 @@ RSpec.describe Search::GroupService do ...@@ -319,21 +303,7 @@ RSpec.describe Search::GroupService do
ensure_elasticsearch_index! ensure_elasticsearch_index!
end end
context 'elasticsearch_use_group_level_optimization is enabled' do include_examples 'search results sorted'
before do
stub_feature_flags(elasticsearch_use_group_level_optimization: true)
end
include_examples 'search results sorted'
end
context 'elasticsearch_use_group_level_optimization is disabled' do
before do
stub_feature_flags(elasticsearch_use_group_level_optimization: false)
end
include_examples 'search results sorted'
end
end end
context 'merge requests' do context 'merge requests' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment