Merge branch 'winh-eslint-promise/param-name' into 'master'

Enable promise/param-name ESLint rule

See merge request gitlab-org/gitlab!17632

.eslintrc.yml

@@ -46,7 +46,6 @@ rules:
   promise/always-return: off
   promise/no-callback-in-promise: off
   promise/no-nesting: off
-  promise/param-names: off
   promise/valid-params: off
 overrides:
   files:

ee/spec/javascripts/monitoring/alert_widget_spec.js

@@ -53,8 +53,8 @@ describe('AlertWidget', () => {
     let resolveReadAlert;
 
     spyOn(AlertsService.prototype, 'readAlert').and.returnValue(
-      new Promise(cb => {
-        resolveReadAlert = cb;
+      new Promise(resolve => {
+        resolveReadAlert = resolve;
       }),
     );
     vm = mountComponent(AlertWidgetComponent, propsWithAlert, '#alert-widget');

spec/frontend/ide/components/error_message_spec.js

@@ -95,18 +95,18 @@ describe('IDE error message component', () => {
     });
 
     it('shows loading icon when loading', () => {
-      let resolve;
+      let resolveAction;
       actionMock.mockImplementation(
         () =>
-          new Promise(ok => {
-            resolve = ok;
+          new Promise(resolve => {
+            resolveAction = resolve;
           }),
       );
       wrapper.find('button').trigger('click');
 
       return wrapper.vm.$nextTick(() => {
         expect(wrapper.find(GlLoadingIcon).isVisible()).toBe(true);
-        resolve();
+        resolveAction();
       });
     });