Commit cbeab67a authored by Marcia Ramos's avatar Marcia Ramos

Apply suggestion to doc/development/code_review.md

parent 6349a185
...@@ -205,7 +205,7 @@ first time. ...@@ -205,7 +205,7 @@ first time.
- Try to respond to every comment. - Try to respond to every comment.
- The merge request author resolves only the discussions they have fully - The merge request author resolves only the discussions they have fully
addressed. If there's an open reply, an open discussion, a suggestion, addressed. If there's an open reply, an open discussion, a suggestion,
a question, or anything else, the discussion must be left to be resolved a question, or anything else, the discussion should be left to be resolved
by the reviewer. by the reviewer.
- Push commits based on earlier rounds of feedback as isolated commits to the - Push commits based on earlier rounds of feedback as isolated commits to the
branch. Do not squash until the branch is ready to merge. Reviewers should be branch. Do not squash until the branch is ready to merge. Reviewers should be
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment