- 06 Jul, 2017 37 commits
-
-
Valery Sizov authored
-
Valery Sizov authored
-
Douwe Maan authored
Fix EE conflicts for 'Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login"' See merge request !2355
-
Marin Jankovski authored
Update alpha database documentation to reflect change in attribute See merge request !2252
-
Phil Hughes authored
Improve state management for deploy boards with realtime data Closes #2677 See merge request !2311
-
Filipa Lacerda authored
-
Sean McGivern authored
EE: Add foreign keys to various tables that point to the "projects" table See merge request !2223
-
Job van der Voort authored
Add overview and use cases for db load balancing docs See merge request !2342
-
Achilleas Pipinellis authored
-
Yorick Peterse authored
This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
-
Yorick Peterse authored
These are specific to EE and a whole bunch of these can be fixed by just removing the `dependent:` option since we now have more foreign keys in place.
-
Yorick Peterse authored
This adds various missing foreign keys (with cascading deletes) that either point directly or indirectly to the "projects" table.
-
Yorick Peterse authored
These IDs point to non-existing rows, causing the foreign key constraints to fail.
-
Yorick Peterse authored
This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk).
-
Yorick Peterse authored
This removes the need for relying on Rails' "dependent" option for data removal, which is _incredibly_ slow (even when using :delete_all) when deleting large amounts of data. This also ensures data consistency is enforced on DB level and not on application level (something Rails is really bad at). This commit also includes various migrations to add foreign keys to tables that eventually point to "projects" to ensure no rows get orphaned upon removing a project.
-
Valery Sizov authored
-
Job van der Voort authored
Add use cases for issues-related EE features Closes #2810 See merge request !2330
-
Marcia Ramos authored
-
Job van der Voort authored
Add docs for Pivotal tile installation See merge request !2341
-
Job van der Voort authored
Update Auditor users docs See merge request !2333
-
Achilleas Pipinellis authored
-
Grzegorz Bizon authored
-
Rémy Coutable authored
See https://gitlab.com/gitlab-org/gitlab-ce/issues/34698#note_34276286 for the thorough explanation. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Timothy Andrew authored
- This is causing autoload-related errors in the `migration:path` builds. We need to find a better way of testing this provider.
-
Timothy Andrew authored
-
Timothy Andrew authored
- Don't use `request.env['omniauth.params']` if it isn't present. - Remove the `saml` section from the `gitlab.yml` test section. Some tests depend on this section not being initially present, so it can be overridden in the test. This MR doesn't add any tests for SAML, so we didn't really need this in the first place anyway. - Clean up the test -> omniauth section of `gitlab.yml`
-
Timothy Andrew authored
- Disable an ESLint check rather than work around it (by converting `OAuthRememberMe` from a regular class to a static class. - Scope `$` calls inside `OAuthRememberMe`
-
Timothy Andrew authored
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
Timothy Andrew authored
- The test for `rake gitlab:env:info` executed the rake task, which mutated the list of omniauth providers, breaking subsequent tests relying on this list. - I've changed the rake task to duplicate the providers list before modifying it.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- I tried to get this to work by stubbing out portions of the config within the test. This didn't work as expected because Devise/Omniauth loaded before the stub could run, and the stubbed config was ignored. - I attempted to fix this by reloading Devise/Omniauth after stubbing the config. This successfully got Devise to load the stubbed providers, but failed while trying to access a route such as `user_gitlab_omniauth_authorize_path`. - I spent a while trying to figure this out (even trying `Rails.application.reload_routes!`), but nothing seemed to work. - I settled for adding this config directly to `gitlab.yml` rather than go down this path any further.
-
Timothy Andrew authored
- Added saml, authentiq, cas3, and auth0 - Crowd seems to be a special case that will be handled separately.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
Timothy Andrew authored
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']`. - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
- 05 Jul, 2017 3 commits
-
-
Sean McGivern authored
[EE] Create and use project path helpers that only need a project, no namespace See merge request !2336
-
Robert Speicher authored
[EE] Disable RSpec/BeforeAfterAll and enable RSpec/ImplicitExpect cops See merge request !2305
-
Douwe Maan authored
-