- 20 Dec, 2021 32 commits
-
-
Patrick Steinhardt authored
When pushing commits into a repository, then client and server negotiate a packfile containing all objects which are necessary to end up with a fully connected graph on the server-side. In general, this contains at least all objects which have been newly introduced between the set of all old and new references. But in some cases, it can be that Git will send packfiles which knowingly contain objects which existed on the server side already, e.g. when Git decides to reuse deltas from an existing packfile where the delta base is a preexisting commit. As a result, any well-formed packfile is a superset of objects required to satisfy the update. In v14.3 we have refactored access checks to use the quarantine directory to enumerate new commits directly. Because of above property, we may get too many objects from the object quarantine directory, which means that as a result we may perform access checks on commits which in fact aren't new in case the client decided to include these in the pack. While this is not a problem in most access checks (an object which is in the main repository but which we re-check is going to still pass the checks), other checks are more sensitive. Most importantly, push rules may require a commit to be created by the author who is currently performing the change. If we include preexisting commits of a different author in such a check, then it is totally expected that the access check will now fail. As a result, we must never include preexisting commits in push rule access checks. To determine new commits in push rules, we do an in-memory walk of commits returned from the quarantine directory, where we walk from the tip of each change until we are not able to satisfy the commit's parents anymore. And in this case, we happily traverse past commits which are known already inc ase those were returned from the quarantine directory. To fix this, we need to abort the walk as soon as we hit an already known object. The problem is though that we have no easy way to determine the already known object in the general case. But we can do so in limited cases: when the change we're processing has both an old and a new revision (that is, it is an "update"), then we simply skip adding oldrev to the result set. This doesn't work though for branch creations, where we ain't got no oldrev. We thus fall back to enumerating commits not via the quarantine directory in that case, but instead by using a revision walk with `--not --all`. This walk will not contain any objects which are referenced by any reference, and thus we can be sure that the in-memory walk will not traverse past any preexisting object. Implement this schema. Unfortunately this is going to be a lot less performant compared to using the quarantine directory in all cases. But better be less performant than wrong. Changelog: fixed
-
Patrick Steinhardt authored
We have multiple locations which check for a blank revision, which either is a blank value or the zero OID. We're about to add one more location, so let's prepare for this and create a helper function to deduplicate the logic.
-
Jan Provaznik authored
Update doc/administration/incoming_email.md See merge request gitlab-org/gitlab!76926
-
hesstobi authored
-
Ezekiel Kigbo authored
Group iterations by cadence on board add list form See merge request gitlab-org/gitlab!71623
-
Simon Knox authored
-
release-tools approver bot authored
Update Gitaly version See merge request gitlab-org/gitlab!77094
-
Achilleas Pipinellis authored
Fix wording in deprecation name See merge request gitlab-org/gitlab!77075
-
Ben Bodenmiller authored
-
Achilleas Pipinellis authored
Add missing properties to example compose files (#348888) See merge request gitlab-org/gitlab!77084
-
Bryant Finney authored
-
GitLab Release Tools Bot authored
-
Kati Paizee authored
Update Omniauth with git-over-https limitation See merge request gitlab-org/gitlab!77010
-
Łukasz Korbasiewicz authored
-
Vitaly Slobodin authored
Merge branch '344349-make-badges-in-app-views-projects-_new_project_fields-html-haml-pajamas-compliant' into 'master' Make badges in app/views/projects/_new_project_fields.html.haml Pajamas-compliant See merge request gitlab-org/gitlab!76969
-
Vitaly Slobodin authored
Migrate reduce visibility confirmation modal to gl-modal See merge request gitlab-org/gitlab!76417
-
Kushal Pandya authored
Update FF to include group in project boards controller See merge request gitlab-org/gitlab!76994
-
Scott Stern authored
-
Marcel Amirault authored
Restore old blocking access section and enhance See merge request gitlab-org/gitlab!76974
-
Tristan Williams authored
-
Simon Knox authored
Merge branch '344339-make-badges-in-app-views-projects-branches-_branch-html-haml-pajamas-compliant' into 'master' Make badges in app/views/projects/branches/_branch.html.haml Pajamas-compliant See merge request gitlab-org/gitlab!76946
-
Anna Vovchenko authored
-
Marcel Amirault authored
Deprecations may not always be planned for removal See merge request gitlab-org/gitlab!77055
-
Kevin Chu authored
-
Krasimir Angelov authored
Restore optimized newly expired artifacts removal See merge request gitlab-org/gitlab!76504
-
James Fargher authored
Monitor PostgreSQL flavor in usage ping See merge request gitlab-org/gitlab!75587
-
Ezekiel Kigbo authored
Removes the omitEmptyProperties method in favour of lodash pickBy
-
Ezekiel Kigbo authored
Add tests for the `omitEmptyProperties` method Minor refactor of the `omitEmptyProperties` method and adds some jest tests.
-
Ezekiel Kigbo authored
Minor fixes to the projects helper and qa specs.
-
Ezekiel Kigbo authored
-
Ezekiel Kigbo authored
Updates the confirm danger jest tests and the user changes project visibility rspec tests
-
Ezekiel Kigbo authored
Updates the confirmation modal dialog for the project visibility settings. Changelog: changed
-
- 18 Dec, 2021 8 commits
-
-
Phil Hughes authored
Fix display of icons for files with two extensions See merge request gitlab-org/gitlab!77016
-
Marcel van Remmerden authored
-
David O'Regan authored
Change the Agent documentation section title See merge request gitlab-org/gitlab!77023
-
Anna Vovchenko authored
-
David O'Regan authored
Allow dismissal of pipeline minutes quota warning See merge request gitlab-org/gitlab!76529
-
Sheldon Led authored
-
Ezekiel Kigbo authored
Sort filtered search tokens See merge request gitlab-org/gitlab!76788
-
Scott Stern authored
-