Commits · 6bd9cd76cd21800918e769628edf71f8bf57ea88 · nexedi / libloc

01 Dec, 2020 1 commit

database: Restart flatten algorithm from the top when a network was dropped · 6bd9cd76

Michael Tremer authored Dec 01, 2020

We used to simply take the first element from the stack after we have
split a network. That is wrong because it is not passing through any
filters and no further subnet checks. It could have therefore been
that the tree was not entirely flat.
Reported-by: Arne Fitzenreiter <arne_f@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

6bd9cd76

27 Nov, 2020 5 commits
- network-list: Exit find operation early when the list is empty · 92202e5a
  Michael Tremer authored Nov 27, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  92202e5a
- python: Do not check whether an integer is larger than 32 bit on 32 bit arches · 7c78416c
  Michael Tremer authored Nov 27, 2020
```
This cannot happen and generated a compiler warning
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  7c78416c
- python: PyList_Size returns ssize_t which is signed · fa9eb94e
  Michael Tremer authored Nov 27, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  fa9eb94e
- Silence compiler formatting warnings for size_t · 36b9fd75
  Michael Tremer authored Nov 27, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  36b9fd75
- configure: Adjust man-pages switch with documentation · 5b4bd18a
  Michael Tremer authored Nov 27, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  5b4bd18a
26 Nov, 2020 4 commits
- as-list/country-list: Set elements list to zero after freeing it · a6dc9324
  Michael Tremer authored Nov 26, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  a6dc9324
- network-list: Add greater elements after the current one · 775621e8
  Michael Tremer authored Nov 26, 2020
```
The list was otherwise not sorted
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  775621e8
- network-list: Add more networks to test · d3a5f691
  Michael Tremer authored Nov 26, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  d3a5f691
- network: Copy flags when split into subnets · 3e8d86ab
  Michael Tremer authored Nov 26, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  3e8d86ab
25 Nov, 2020 14 commits
- configure: Bump version to 0.9.5 · adbec5c0
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  adbec5c0
- network-list: Use clear function to tidy up · fff093b6
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  fff093b6
- network-list: Include network header · 8ebf1d39
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  8ebf1d39
- network: Remove deprecated sort call · 9caf6cf5
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  9caf6cf5
- network: Massively improve performance on exclude · 058e7800
  Michael Tremer authored Nov 25, 2020
```
When we check the result for any overlaps, we can cut this short
by walking through both lists from start to end and remember the
last network that we checked.

The next one will by definition be strictly greater and therefore
we do not need to check anything before this any more.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  058e7800
- network: Call subnet function with the correct order of arguments · 4de8ff8e
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  4de8ff8e
- network: Add more excluded networks straight to the to_check list · 4fc034e2
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  4fc034e2
- network: Do not execute with an error when the excluded result will be empty · abf55926
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  abf55926
- networks: Remove comparing family · 0a39d549
  Michael Tremer authored Nov 25, 2020
```
Everything is encoded in IPv6 anyways...
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  0a39d549
- networks: Add tests for overlaps function · 82fa4c92
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  82fa4c92
- network-list: Remove useless comment · dc31666b
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  dc31666b
- network-list: Show index when listing networks · 9446c753
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  9446c753
- network-list: Do not half list when popping the first element · 673e03f7
  Michael Tremer authored Nov 25, 2020
```
The list was unfortunately halved in size every time an element
was taken from it, which was great for performance, but shortened
the result substantially.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  673e03f7
- network-list: Set elements pointer to NULL so that we know it is empty · d42f34ce
  Michael Tremer authored Nov 25, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
  d42f34ce
24 Nov, 2020 11 commits

network-list: Check last element before doing binary search · 77e6d537

Michael Tremer authored Nov 24, 2020

This is helpful because very often we walk through a list in
order and are most interested in the last element.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

77e6d537

network-list: Use binary search to find if a network is a subnet · 06177d8c
Michael Tremer authored Nov 24, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
06177d8c
network: Adjust return codes of loc_network_match_address and add test · fc692a58
Michael Tremer authored Nov 24, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
fc692a58
Drop loc_network_gt which is now unused · 61a6f6e4
Michael Tremer authored Nov 24, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
61a6f6e4
Drop loc_network_eq in favour of loc_network_cmp · da101d55
Michael Tremer authored Nov 24, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
da101d55
test: Add more networks to list to see the algorithm work · 7c6983ad
Michael Tremer authored Nov 24, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
7c6983ad

network: Add excluded networks to to_check list · c650008e

Michael Tremer authored Nov 24, 2020

This is now being done immediately instead of creating a new
list which is being merged later.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

c650008e

database: Read the first element from the list · 04cbd2bf
Michael Tremer authored Nov 24, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
04cbd2bf

database: Avoid merging the same data twice · 5dacb45a

Michael Tremer authored Nov 24, 2020

When finish splitting networks into many parts, we have
a list of subnets with the excluded subnets and merge them
together first and put them on the stack again.

This is slower than pushing it all onto the stack first
and then popping the first element.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

5dacb45a

network-list: Drop sorting functions · 39cbbc63

Michael Tremer authored Nov 24, 2020

Since the list is always sorted, there is no point in
sorting it again...
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

39cbbc63

network-list: Make this a sorted list · af4689bf

Michael Tremer authored Nov 24, 2020

The list is now organised so that it is always ordered.

This allows us to find if a network is on the list a lot
quicker using binary search as well as inserting a new
network at the right place.

This will benefit loc_network_exclude with very large networks.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

af4689bf

20 Nov, 2020 5 commits

network: Remove deprecated loc_network_is_subnet_of function · d6a5092f
Michael Tremer authored Nov 20, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
d6a5092f

network: Speed up subnet check · cf8d3c64

Michael Tremer authored Nov 20, 2020

There is no point in checking different address families
with each other and we do not need to compare addresses
when the prefix of the subnet does not fit into the
network to check.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cf8d3c64

network: Add function to return the prefix · 7fe6a218
Michael Tremer authored Nov 20, 2020
```
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
```
7fe6a218

network: Optimise _subnet function · a5967330

Michael Tremer authored Nov 20, 2020

This function used to create a network list which always
had exactly two elements. Since splitting a network in half
always returns two parts, we can simply return them as a
pointer.

This improves returning the network tree by about 17%.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

a5967330

network-list: Implement merging in reverse in one step · a1024390

Michael Tremer authored Nov 20, 2020

This will save us some time because we do not need to
change the list in place first and then merge it.
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

a1024390