• Mathias Krause's avatar
    pktgen: fix out-of-bounds access in pgctrl_write() · 20b0c718
    Mathias Krause authored
    If a privileged user writes an empty string to /proc/net/pktgen/pgctrl
    the code for stripping the (then non-existent) '\n' actually writes the
    zero byte at index -1 of data[]. The then still uninitialized array will
    very likely fail the command matching tests and the pr_warning() at the
    end will therefore leak stack bytes to the kernel log.
    
    Fix those issues by simply ensuring we're passed a non-empty string as
    the user API apparently expects a trailing '\n' for all commands.
    
    Cc: "David S. Miller" <davem@davemloft.net>
    Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    20b0c718
pktgen.c 93.1 KB