Commit c8d755b5 authored by Jesper Juhl's avatar Jesper Juhl Committed by David S. Miller

net/wan/hdlc_ppp: use break in switch

We'll either hit one of the case labels or the default in the switch
and in all cases do we then 'goto out' and we also have a 'goto out'
after the switch that is redundant. Change to just use break in the
case statements and leave the 'goto out' after the lop for everyone to
hit.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ca1ba7ca
...@@ -515,37 +515,37 @@ static int ppp_rx(struct sk_buff *skb) ...@@ -515,37 +515,37 @@ static int ppp_rx(struct sk_buff *skb)
switch (cp->code) { switch (cp->code) {
case CP_CONF_REQ: case CP_CONF_REQ:
ppp_cp_parse_cr(dev, pid, cp->id, len, skb->data); ppp_cp_parse_cr(dev, pid, cp->id, len, skb->data);
goto out; break;
case CP_CONF_ACK: case CP_CONF_ACK:
if (cp->id == proto->cr_id) if (cp->id == proto->cr_id)
ppp_cp_event(dev, pid, RCA, 0, 0, 0, NULL); ppp_cp_event(dev, pid, RCA, 0, 0, 0, NULL);
goto out; break;
case CP_CONF_REJ: case CP_CONF_REJ:
case CP_CONF_NAK: case CP_CONF_NAK:
if (cp->id == proto->cr_id) if (cp->id == proto->cr_id)
ppp_cp_event(dev, pid, RCN, 0, 0, 0, NULL); ppp_cp_event(dev, pid, RCN, 0, 0, 0, NULL);
goto out; break;
case CP_TERM_REQ: case CP_TERM_REQ:
ppp_cp_event(dev, pid, RTR, 0, cp->id, 0, NULL); ppp_cp_event(dev, pid, RTR, 0, cp->id, 0, NULL);
goto out; break;
case CP_TERM_ACK: case CP_TERM_ACK:
ppp_cp_event(dev, pid, RTA, 0, 0, 0, NULL); ppp_cp_event(dev, pid, RTA, 0, 0, 0, NULL);
goto out; break;
case CP_CODE_REJ: case CP_CODE_REJ:
ppp_cp_event(dev, pid, RXJ_BAD, 0, 0, 0, NULL); ppp_cp_event(dev, pid, RXJ_BAD, 0, 0, 0, NULL);
goto out; break;
default: default:
len += sizeof(struct cp_header); len += sizeof(struct cp_header);
if (len > dev->mtu) if (len > dev->mtu)
len = dev->mtu; len = dev->mtu;
ppp_cp_event(dev, pid, RUC, 0, 0, len, cp); ppp_cp_event(dev, pid, RUC, 0, 0, len, cp);
goto out; break;
} }
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment