Commit de6f2a7f authored by Matthias Kaehlcke's avatar Matthias Kaehlcke Committed by Lee Jones

backlight: pwm_bl: Don't assign levels table repeatedly

pwm_backlight_probe() re-assigns pb->levels for every brightness
level. This is not needed and was likely not intended, since
neither side of the assignment changes during the loop. Assign
the field only once.
Signed-off-by: default avatarMatthias Kaehlcke <mka@chromium.org>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent cc2f2e10
...@@ -564,18 +564,17 @@ static int pwm_backlight_probe(struct platform_device *pdev) ...@@ -564,18 +564,17 @@ static int pwm_backlight_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(struct backlight_properties)); memset(&props, 0, sizeof(struct backlight_properties));
if (data->levels) { if (data->levels) {
pb->levels = data->levels;
/* /*
* For the DT case, only when brightness levels is defined * For the DT case, only when brightness levels is defined
* data->levels is filled. For the non-DT case, data->levels * data->levels is filled. For the non-DT case, data->levels
* can come from platform data, however is not usual. * can come from platform data, however is not usual.
*/ */
for (i = 0; i <= data->max_brightness; i++) { for (i = 0; i <= data->max_brightness; i++)
if (data->levels[i] > pb->scale) if (data->levels[i] > pb->scale)
pb->scale = data->levels[i]; pb->scale = data->levels[i];
pb->levels = data->levels;
}
if (pwm_backlight_is_linear(data)) if (pwm_backlight_is_linear(data))
props.scale = BACKLIGHT_SCALE_LINEAR; props.scale = BACKLIGHT_SCALE_LINEAR;
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment