An error occurred fetching the project authors.
  1. 14 Jun, 2002 1 commit
    • Martin Dalecki's avatar
      [PATCH] 2.5.21 IDE 90 · 3fb57bd6
      Martin Dalecki authored
       - Implement the assertion that the lock is already held, if we run
         ata_status_poll.
      
       - The usual host chip code load from Bartomiej onierkiewicz.  Fortunately
         I'm able to check the sis5513 fixes on a life system.
      
         More serious stuff... for IDE 88:
      
      	- implement ata_best_pio_mode() in ata-timing.c
      	  (play safer than driver's config_chipset_for_pio())
      
      	- replace config_chipset_for_pio() by ata_best_pio_mode()
      	  in host chips drivers
      	  (trivial for hpt34x.c, hpt366.c and serverworks.c,
      	   non-trivial for cmd64x.c and sis5513.c)
      
      	- set PIO also for (U)DMA modes in cmd64x_tune_chipset()
      	  (cmd64x.c)
      
      	- fix bug in setting PIO0-2 for devices also supporting PIO3/4
      	  (sis5513.c)
      
      	- misc cleanups
      
       - Rename XXX_do_request back do do_request. This was just tmporary tagging.
      
       - Move ata_taskfile() call down to the ide-disk request handler.c, which is the
         only place needing it. Rename ata_taskfile to ata_do_taskfile().  This
         allowed us to implement the assertion that ata_do_taskfile() will be only
         called with the channel lock already held.
      3fb57bd6
  2. 09 Jun, 2002 1 commit
    • Martin Dalecki's avatar
      [PATCH] 2.5.20 IDE 86 · 467b45ea
      Martin Dalecki authored
      Most importantly this makes ide-scsi work again, which I broke
      IDE 85. And we are starting to be serious about locking issues.
      However the locking issues will take some patches until they stabilize.
      
       - Add spin locks in ata_special_intr.
      
       - Add Server Works CSB6 handling by Matt Domsch.
      
       - Atari updates by Geert Uytterhoeven:
         * irq_lock is used in more than one file, so make it global and rename it
           to ide_irq_lock
         * `hwgroup' is dead, use `channel' instead
         * ide_irq_lock depends on ATA_ARCH_LOCK, not on m68k or APUS
      
       - Small janitorial tidbits by Angus Sawyer.
      
       - PIIX driver updates by Vojtech Pavlik:
      
         * Removes the CONFIG_BLK_DEV_PIIX_TRY133 option. I've got an official
           statement from Intel saying that the controller definitely isn't intended
           to operate at this speed and doing so may cause severe trouble.
      
         * Fixes a bug in ata-timing.c, where EIDE timing data was discarded by
           accident.
      
         * Fixed a couple bugs in the Artop driver (UDMA clocks, active/recovery
           timing), 8-bit timing merging.
      
         * Removes an unused variable from piix.c
      
       - Move locking out from ide_set_handler(). There are places where it incurred
         too frequent lock grab and release or where we did miss to lock against
         concurrent hardware access.
      
         Generally the locking appears to be too fine grained and inconsistent at many
         places. This is the first cut. We will deal with it step by step.
      
       - Make sure message string is initialized even if FANCY_STATUS_DUMPS is
         disabled.
      
       - Don't lock directly inside udma_init and implementations of this method.
      
       - Guard against REQ_SPECIAL issued by the SCSI layer on us. Use REQ_PC in
         ide-scsi.c instead.
      467b45ea
  3. 17 May, 2002 1 commit
    • Martin Dalecki's avatar
      [PATCH] 2.5.15 IDE 63 · d7e09f7e
      Martin Dalecki authored
      - Propagate the queue handling changes to pmac as well.
      
      - Move set_transfer to ide-taskfile.c this is the only place where it's used
         and it can be made static there. Same applies to ide_ata66_check().
      
      - Move ide_auto_reduce_xfer to ide.c.
      
      - Make ide_cmd() local to the only place where it's used. Rename it to
         drive_cmd(). Don't pass drive_cmd_intr() as parameter.
      
      - Remove ide_next command completion type. Nobody is using it.
      
      - Move ide_do_drive_cmd to ide-taskfile. It's used there and in sub-drivers.
         Not in ide.c. The usage inside the device type drivers is entirely bogus
         inconsistent and so on...
      
      - Kill bogus IRQ masking code. The kernel is supposed to handle this properly.
         We should not try to work against possible bugs in the overall irq handling
         code. Wow this is increasing the systems overall responsibility by a
         significant margin.
      
      - Remove disfunctional pdcadma code. It is only misleading to the user.
      d7e09f7e
  4. 13 Mar, 2002 1 commit
    • Martin Dalecki's avatar
      [PATCH] IDE 21 · 10cea35a
      Martin Dalecki authored
      If I was to give this patch a name it would be:
      
      "Vojtech Pavlik unleashed from the chains".
      
      So credit where credit is due :-).
      
      Anyway here follows the change log:
      
      Mon Mar 11 23:48:28 CET 2002 ide-clean-21
      
      - Swallow rewritten amd74xx host chip setup code from Vojtech Pavlik.  We can
         revert it easly if it turns out to be a bad thing. However the code looks
         quite sane to me. In esp. it doesn't containg that many magic numbers.
      
      - Clean stale white spaces in ide-timing.h tirvial fix.
      
      - Make ide_release_dma return void. It's value is never used anyway.
      
      - Swallow more timing setup code cleanup by Vojtech Pavlik. Apply some
         cosmetics to it. Port opti621 to the new setup code.
      
      - Kill abuse of ide_do_reset() on error return paths for atapi floppy tape and
         cd-rom devices. Just stop them. This gives better changes that defect
         removable media will not cause suddenly broken timings on hard discs
         containing system data! Even then comments in ide_do_reset() admit, that
         resetting the whole channel can have adverse effects on the second interface
         on this channel. And I have too frequently observed linux struggling on
         defect cd-rom for a far too long time to wish it to continue.
      
         Oh did I forget to say that the corresponding "how can I break my system fast
         and reliable" ioctl is gone as well?
      
         Removing it recovered the fact that the CONFIG_BLK_DEV_IDEDMA_TIMEOUT is
         completely bogous. I have removed this option therefore as well, because it's
         playing the same wrack havoc on the devices if enabled. This cat has been in
         an unfinished and *unfunctional* state anyway.
      
      - Actually add physical suspend code to the power handling code.  Still the
         resume code isn't finished just jet. This is all subject to change at the
         point in time when we get to proper command queueing.
         I think however that Pavel will be interrested in tidding this bit up...
      
      - Resync with 2.5.7-pre1.
      10cea35a