- 28 Mar, 2016 40 commits
-
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Parth Sane authored
Using comparison to false and true is error prone. Fixed multiple warnings as per checkpatch guidelines. Signed-off-by:
Parth Sane <laerdevstudios@gmail.com> Signed-off-by:
-
Anchal Jain authored
Remove a problem detect by checkpatch.pl CHECK: Avoid CamelCase: <srcAdd> Signed-off-by:
Anchal Jain <anchalj109@gmail.com> Signed-off-by:
-
Daeseok Youn authored
fix the checkpatch.pl warning about CamelCase. Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Svetlana Orlik authored
Lines with #define interlaced with comment lines making a mess. Separate groups of #define-comment with blank lines. Separate section title comments with blank lines. Signed-off-by:
Svetlana Orlik <sveta.orlik.code@gmail.com> Signed-off-by:
-
Svetlana Orlik authored
Lines with #define interlaced with comment lines making a mess. Separate groups of #define-comment with blank lines. Separate section title comments with blank lines. Signed-off-by:
-
Svetlana Orlik authored
Lines with #define interlaced with comment lines making a mess. Separate groups of #define-comment with blank lines. Separate section title comments with blank lines. Signed-off-by:
-
Svetlana Orlik authored
Many of the comments in the same lines with #define caused checkpatch warning 'line over 80 characters'. Move all such comments to line before #define. This style is already used in some other .h files in accel: Add blank lines after #define to improve readability. Signed-off-by:
-
Svetlana Orlik authored
Many of the comments in the same lines with #define caused checkpatch warning 'line over 80 characters'. Move all such comments to line before #define. This style is already used in some other .h files in accel: Add blank lines after #define to improve readability. Signed-off-by:
-
Svetlana Orlik authored
Many of the comments in the same lines with #define caused checkpatch warning 'line over 80 characters'. Move all such comments to line before #define. This style is already used in some other .h files in accel: Add blank lines after #define to improve readability. Signed-off-by:
-
Svetlana Orlik authored
Replace 'unsigned' with 'unsigned int' to avoid checkpatch warning. Signed-off-by:
-
Svetlana Orlik authored
Replace 'unsigned' with 'unsigned int' to avoid checkpatch.pl warning. Signed-off-by:
-
Bhaktipriya Shridhar authored
Convert macro GAT_CONFIG to static inline function as static inline functions are preferred over macros. This change is possible since the arguments at all call sites have the same type. This was done using Coccinelle: @r@ expression e; @@ - #define GAT_CONFIG(chan, src) e + static inline unsigned int pci230_gat_config(unsigned int chan, + unsigned int src) +{ + return ((chan & 3) << 3) | (src & 7); +} @r1@ expression dev,reg,chan,src; @@ -GAT_CONFIG(chan, src) +pci230_gat_config(chan, src) Also, the comment describing the macro has been removed manually. Signed-off-by: -
Chaehyun Lim authored
This patch replaces struct semaphore hif_sema_deinit with struct mutex hif_deinit_lock. It is better to use mutex because mutex gives better performance than semaphore. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Kathryn Hampton authored
This patch addresses line length errors reported by checkpatch.pl that could be fixed with simple line breaks. Signed-off-by:
Kathryn Hampton <kh353dev@gmail.com> Signed-off-by:
-
Samuel Thibault authored
Previously, speakup would see the hi-font bit in attributes. Since this bit has nothing to do with attributes, we need to clear it. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
Claudiu Beznea authored
This patch changes byVT3253InitTab_RFMD[] and byVT3253B0_RFMD[] arrays in const arrays since these are not changed anywhere in the code. Signed-off-by:
Claudiu Beznea <claudiu.beznea@gmail.com> Signed-off-by:
-
Leslie Klein authored
Fix checkpatch warning: Prefer 'unsigned int' to bare use of 'unsigned' in file comedi_fops.c Signed-off-by:
Leslie Klein <lesliebklein@gmail.com> Signed-off-by:
-
Leslie Klein authored
Fix checkpatch warning: Prefer 'unsigned int' to bare use of 'unsigned' in file comedi_buf.c Signed-off-by:
-
H Hartley Sweeten authored
Arnd Bergmann pointed out that gcc-6 warns about passing negative signed integer into swab16() due to the macro expansion of 'outw'. It appears that the register map constants are causing the warnings. Actually, it might just be the (1 << 15) ones... Convert all the constants as suggested by checkpatch.pl: CHECK: Prefer using the BIT macro The BIT() macro will make all the constants explicitly 'unsigned', which helps to avoid the warning. Fix the, unsused, DT2821_CHANCSR_PRESLA() macro. The "Present List Address" (PRESLA) bits in the CHANCSR register are read only. This define was meant to extract the bits from the read value. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reported-by:
Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Tested-by:
-
Sandhya Bankar authored
Use x instead of x != NULL.This issue is detected by checkpatch.pl script. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Claudiu Beznea authored
This patch defines oui_rfc1042[] and oui_8021h[] arrays from p80211conv.c as const arrays since these are not changed anywhere in code. Signed-off-by:
-
Sandhya Bankar authored
Use sizeof type *pointer instead of sizeof type. Signed-off-by:
-
Parth Sane authored
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by:
-
Parth Sane authored
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by:
-
Parth Sane authored
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by:
-
Parth Sane authored
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by:
-
Parth Sane authored
Fixed checkpatch warning after removing FSF address paragraph as per guidelines. Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Change null comparisons of the form x == NULL to !x. This was done using Coccinelle. @@ expression e; @@ - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Removed Unused macro IS_MAC_ADDRESS_BROADCAST. Grep'd to find occurences. Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary return statement. Signed-off-by:
-
Sandhya Bankar authored
Remove unnecessary semicolon. Coccinelle sementic patch as follows: @r_case@ position p; @@ switch (...) { case ...: ...;@p } @r_default@ position p; @@ switch (...) { default: ...;@p } @r1@ statement S; position p1; position p != {r_case.p, r_default.p}; identifier label; @@ ( label:; | S@p1;@p ) Signed-off-by:
-
