An error occurred fetching the project authors.
  1. 02 Apr, 2002 2 commits
    • Martin Dalecki's avatar
      [PATCH] 2.5.7 IDE 28a · 5be8243b
      Martin Dalecki authored
      - Apply Pavel Macheks suspend resume double resume fix.
      
      - Finally remove the busy field for ata_operations and replace it with
         MOD_INC_USE_COUNT and MOD_DEC_USE_COUNT.
      
      - Fix ali15xx chipset support by removing initialization differences,
         apparently caused by mislead interpretation of the specs or a mismatch
         between the specification and reality.
      
      - Guard calls to ide_set_handler with checks to see whatever the previously
         installed IRQ handler already served it's purpose.
      
      - Convert timeout checks on poll_timeout to the time_before() interface.
      
      - Consolidate the two different IRQ handlers for multi mode PIO writes into
         one. The problems remain the same but at least now we will only have to
         tangle one single problem.
      5be8243b
    • Martin Dalecki's avatar
      [PATCH] 2.5.7 IDE 26 · d1372f76
      Martin Dalecki authored
      - Mark all members of structures, which get jiffies assigned or involved in
         ugly timeout calculations with the prefix PADAM_  for easy spotting. This is
         Polish for "I'm falling down" or "This brings me to the knees" or slag
         comment for "What a sh..". Please be assured that it doesn't sound vulgar.
      
         Please grep for it to see immediately why this nomenclature is justified.
      
      - Rename hwifs_s to ata_channel and eliminate ide_hwifs_t as well as the HWIF
         macro. OK this step makes this patch rather big.
      d1372f76
  2. 13 Mar, 2002 1 commit
    • Martin Dalecki's avatar
      [PATCH] IDE 21 · 10cea35a
      Martin Dalecki authored
      If I was to give this patch a name it would be:
      
      "Vojtech Pavlik unleashed from the chains".
      
      So credit where credit is due :-).
      
      Anyway here follows the change log:
      
      Mon Mar 11 23:48:28 CET 2002 ide-clean-21
      
      - Swallow rewritten amd74xx host chip setup code from Vojtech Pavlik.  We can
         revert it easly if it turns out to be a bad thing. However the code looks
         quite sane to me. In esp. it doesn't containg that many magic numbers.
      
      - Clean stale white spaces in ide-timing.h tirvial fix.
      
      - Make ide_release_dma return void. It's value is never used anyway.
      
      - Swallow more timing setup code cleanup by Vojtech Pavlik. Apply some
         cosmetics to it. Port opti621 to the new setup code.
      
      - Kill abuse of ide_do_reset() on error return paths for atapi floppy tape and
         cd-rom devices. Just stop them. This gives better changes that defect
         removable media will not cause suddenly broken timings on hard discs
         containing system data! Even then comments in ide_do_reset() admit, that
         resetting the whole channel can have adverse effects on the second interface
         on this channel. And I have too frequently observed linux struggling on
         defect cd-rom for a far too long time to wish it to continue.
      
         Oh did I forget to say that the corresponding "how can I break my system fast
         and reliable" ioctl is gone as well?
      
         Removing it recovered the fact that the CONFIG_BLK_DEV_IDEDMA_TIMEOUT is
         completely bogous. I have removed this option therefore as well, because it's
         playing the same wrack havoc on the devices if enabled. This cat has been in
         an unfinished and *unfunctional* state anyway.
      
      - Actually add physical suspend code to the power handling code.  Still the
         resume code isn't finished just jet. This is all subject to change at the
         point in time when we get to proper command queueing.
         I think however that Pavel will be interrested in tidding this bit up...
      
      - Resync with 2.5.7-pre1.
      10cea35a
  3. 28 Feb, 2002 2 commits
    • Martin Dalecki's avatar
      [PATCH] 2.5.6-pre1 IDE clean 14 · 48ba6e98
      Martin Dalecki authored
      Most importantly this patch is making ide.c use the
      new automagic for module initialization lists and further
      preparing the rest of the code in question here for proper
      module separation. Despite this the CMOS probe has been removed
      as well... *Iff*, which I don't expect, this breaks anything
      it can be reintroduced easely. During this effort an actual bug
      in the initialization of the main module has been uncovered as well.
      a quite serious BUG has been tagged in ide-scsi.c as well, but
      as far as now I just didn't get along to actually fixing it.
      (The patch is big enough as it is).
      
      Details follow:
      
      - Kill *unused* ide_media_verbose() funciton.
      
      - Remove the unnecessary media and supports_dma fields from
          ide_driver_t.
      
      - Remove the global name field from ide_driver_t struct by pushing it
          down to the places where it's actually used.
      
      - Remove the unused hwif_data field from ide_hwif_t.
      
      - Push the supports_dsc_overlap condition up to the level where it
          belongs: disk type as well.
      
      - Make the initialization of ide main ide.c work with the new module
          initialization auto-magic instead of calling it explicitly in
          ll_rw_block.c This prevents the ide_init() from being called twice. We
          have BTW. renamed it to ata_module_init(), since  ata is more adequate
          then ide and xxx_module_init corresponds better to the naming
          conventions used elsewhere throughout the kernel.
      
          This BUG was there before any ide-clean.  It was worked around by a
          magic variable preventing the second call to succeed.  We have removed
          this variable in one of the previous patches and thus uncovered it.
      
      - Kill proc_ide_read_driver() and proc_ide_write_driver(). The drivers
          already report on syslog which drives they have taken care of.  (Or
          at least they should). In esp. the proc_ide_write_driver() was just
          too offending for me.  Beleve it or not the purpose of it was to
          *request a particular* driver for a device, by echoing some magic
          values to a magic file...
          More importantly this "back door" was getting in the way of a properly
          done modularization of the IDE stuff.
      
      - Made some not externally used functions static or not EXPORT-ed.
      
      - Provide the start of a proper modularization between the main module
          and drivers for particular device types. Changing the name-space
          polluting DRIVER() macro to ata_ops() showed how inconsistently the
          busy (read: module  busy!) field from ide_driver_t
          is currently used across the    different device type modules.
          This has to be fixed soon.
      
      - Make the ide code use the similar device type ID numbers as the SCSI
          code :-).  This is just tedious, but it will help in a distant
          feature. It helps reading the code anyway.
      
      - Mark repettitive code with /* ATA-PATTERN */ comments for later
          consolidation at places where we did came across it.
      
      - Various comments and notes added where some explanations was missing.
      48ba6e98
    • Martin Dalecki's avatar
      [PATCH] 2.5.5 IDE cleanup 12 · c0bf9449
      Martin Dalecki authored
      1. Add some notes to Documentation/driver-model.txt about how and
           and where to mount the driverfs.
      
      2. Reorganize and prepare the PCI scanning code for proper device
      dependant splitup. Basically tedious cleanup of macro games.
      
      3. Use struct pci_dev name field as the name of PCI host dapaters
      instead of invention ambigious IDE special names. This makes
      the kernel bootup messages look a bit shifted, since those names are bit
      longer, but makes up for consistance and should allow one later
      to rearage things to fit into the generic PCI device initialization
      mechanisms provided by the kernel.
      
      4. Set 3. Allowed us to make the host chip specific
      pci_init_xxx class functions have the proper signature of
      module initializers. This will make it possible to make true
      modules out of them later.
      
      5. Make some functions in cmd64x.c static which where not used
      elsewhere.
      
      6. rename ide_special_settings to trust_pci_irq - this is reflecting
      it's functionality better. And make it match the pci device vendor
      as well as the device ID. It was a BUG to match only the device id!.
      
      7. Make the chanell setup more tollerant for BIOS-es which don't
      report IO and MEM bases properly. The code found previously there
      tryed but was inconsistant.
      
      8. Start to use proper terminology in ide-pci.c: host chip, channel,
      drive instead of hwif, port, drive...
      
      9. Enlarge the name field from ide_hwif_t to 64 bytes. It was only 6
      previously and there where custom names there which where exceeding
      this!!! But since we use the proper pci devce name there now instead,
      we had to extend the size of this field anyway.
      
      10. Add some explanatory comments and fix misguiding comments here and
      there.
      
      11. Kill the proc_ide_write_config and proc_ide_read_config brain
      damage! Those where backdoors to the pci configuration registers on PCI
      devices and IO registers on directly connected ISA ATA controllers.
      They didn't discrement between them!
      
      Access to both of them *simply* doesn't belong into an operating system,
      which is supposed to abstract out the access to hardware! Did I mention
      that access to both can be done from user land without an IDE special
      interface! Any program which was using them (I hardly beleve there is
      one) just deserves to loose. The programmer responsible for it
      deserves to be fired immediately.
      
      12. Move ide_map_xx and ide_unmap_xx tinny bio level wrappers away
      from the "global" ide.h to where those are actually used and kill
      trivial wrappers for otherwise generic bio_ routines. Just fighting
      code obfuscation. The "rq->bio is used or is not there" brain
      damage in ide-taskfile.c has to be fixed later. Possibly by killing
      ide-taskfile.c alltogether, becouse this should be a driver for
      users and not a driver for ATA disk disaster recovery companys...
      
      13. Kill hwif->pci_devid and hwif->pci_venid. Just use the already
      present hwif->pci_dev field instead.
      
      14. Kill unused big switch ide_reinit_drive function. This silly
      functon was switching upon every possible device driver cathegory
      and calling the correspondng reinit function directly. This
      idiocy was fortunately not used.
      
      That's all... Most will be clear if one starts looking at the changes
      in ide.h of course...
      
      In contrast to the previous patches this one is actually fixing two
      serious bugs.
      
      
      The next direct step will be to kill the sigle place global PCI device
      type recognition list from ide-pci.c by pushing the entries to where
      they belong -> the host chips setup modules.
      c0bf9449
  4. 05 Feb, 2002 3 commits
    • Linus Torvalds's avatar
      v2.5.0.1 -> v2.5.0.2 · e1e2cfc3
      Linus Torvalds authored
      - Greg KH: USB update
      - Richard Gooch: refcounting for devfs
      - Jens Axboe: start of new block IO layer
      e1e2cfc3
    • Linus Torvalds's avatar
      v2.4.4.3 -> v2.4.4.4 · 923215ae
      Linus Torvalds authored
        - Russell King: ARM updates
        - Al Viro: more init cleanups
        - Cort Dougan: more PPC updates
        - David Miller: cleanups, pci mmap updates
        - Neil Brown: raid resync by sector
        - Alan Cox: more merging with -ac
        - Johannes Erdfelt: USB updates
        - Kai Germaschewski: ISDN updates
        - Tobias Ringstrom: dmfe.c network driver update
        - Trond Myklebust: NFS client updates and cleanups
      923215ae
    • Linus Torvalds's avatar
      Import changeset · 7a2deb32
      Linus Torvalds authored
      7a2deb32