1. 09 Jun, 2004 8 commits
    • Andrew Morton's avatar
      [PATCH] runtime selection of CONFIG_PARIDE_EPATC8 · 85aeb8a6
      Andrew Morton authored
      From: Christoph Hellwig <hch@lst.de>
      
      drivers/block/paride/epat.c support two slightly different protocol
      variants.  Currently it's compile-time selected by CONFIG_PARIDE_EPATC8,
      but this patch adds a epatc8 module option to allow runtime selection.
      CONFIG_PARIDE_EPATC8 stays for now but I'd like to kill it int 2.7.
      
      The basic patch is from the Debian kernel package (Author unknown) but I
      reworked it a bit.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      85aeb8a6
    • Andrew Morton's avatar
      [PATCH] unalign struct page_state · 03a61032
      Andrew Morton authored
      The ____cacheline_aligned in there is a leftover from before the existence of
      the percpu infrastructure.  It bloats struct page_state and structures which
      contain it enormously, and we use these things on the stack deep in page
      reclaim.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      03a61032
    • Andrew Morton's avatar
      [PATCH] writeback_inodes can race with unmount · 7052fc2b
      Andrew Morton authored
      From: Chris Mason <mason@suse.com>
      
      There's a small window where the filesystem can be unmounted during
      writeback_inodes.  The end result is the iput done by sync_sb_inodes could
      be done after the FS put_super and and the super has been removed from all
      lists.
      
      The fix is to hold the s_umount sem during sync_sb_inodes to make sure
      the FS doesn't get unmounted.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      7052fc2b
    • Andrew Morton's avatar
      [PATCH] ppc64: iSeries vio_dev cleanups · 9c6b3b51
      Andrew Morton authored
      From: Stephen Rothwell <sfr@canb.auug.org.au>
      
      This patch removes the archdata and driver_data members of struct vio_dev
      and uses the platform_data and driver_data members of the embedded struct
      device instead.  I also declared a couple of routines static.
      
      This is part of a work in progress.
      Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      9c6b3b51
    • Andrew Morton's avatar
      [PATCH] ppc32: fix missing option in binutils version check · 4db61881
      Andrew Morton authored
      From: Olaf Hering <olh@suse.de>
      
      The binutils check is bogus, it doesnt work with the just released
      binutils.  A space is needed in the error message.
      
      pomegranate:~# echo dssall | /usr/bin/as -o /tmp/x
      {standard input}: Assembler messages:
      {standard input}:1: Error: Unrecognized opcode: `dssall'
      pomegranate:~# /usr/bin/as -v
      GNU assembler version 2.15.91.0.1 (powerpc-suse-linux) using BFD version 2.15.91.0.1 20040527 (SuSE Linux)
      
      *** 2.6 kernels no longer buildcorrectly with old versions of binutils.
      *** Please upgrade your binutils to 2.12.1 or newer
      make: *** [checkbin] Error 1
      make: Target `all' not remade because of errors.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      4db61881
    • Andrew Morton's avatar
      [PATCH] speedup flush_workqueue for singlethread_workqueue · 499e2d44
      Andrew Morton authored
      From: "Anil" <anil.s.keshavamurthy@intel.com>
      
      In flush_workqueue() for a single_threaded_worqueue case the code flushes the
      same cpu_workqueue_struct for each online_cpu.
      
      Change things so that we only perform the flush once in this case.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      499e2d44
    • Andrew Morton's avatar
      [PATCH] jbd: descriptor buffer state fix · ace476bb
      Andrew Morton authored
      Fix a problem discovered by Jeff Mahoney <jeffm@suse.com>, based on an initial
      patch from Chris Mason <mason@suse.com>.
      
      journal_get_descriptor_buffer() is used to obtain a regular old buffer_head
      against the blockdev mapping.  The caller will populate that bh by hand and
      will then submit it for writing.
      
      But there are problems:
      
      a) The function sets bh->b_state nonatomically.  But this buffer is
         accessible to other CPUs via pagecache lookup.
      
      b) The function sets the buffer dirty and then the caller populates it and
         then it is submitted for I/O.  Wrong order: there's a window in which the
         VM could write the buffer before it is fully populated.
      
      c) The function fails to set the buffer uptodate after zeroing it.  And one
         caller forgot to mark it uptodate as well.  So if the VM happens to decide
         to write the containing page back __block_write_full_page() encounters a
         dirty, not uptodate buffer, which is an illegal state.  This was generating
         buffer_error() warnings before we removed buffer_error().
      
         Leaving the buffer not uptodate also means that a concurrent reader of
         /dev/hda1 could cause physical I/O against the buffer, scribbling on what
         we just put in it.
      
         So journal_get_descriptor_buffer() is changed to mark the buffer
         uptodate, under the buffer lock.
      
      I considered changing journal_get_descriptor_buffer() to return a locked
      buffer but there doesn't seem to be a need for this, and both callers end up
      using ll_rw_block() anyway, which requires that the buffer be unlocked again.
      
      Note that the journal_get_descriptor_buffer() callers dirty these buffers with
      set_buffer_dirty().  That's a bit naughty, because it could create dirty
      buffers against a clean page - an illegal state.  They really should use
      mark_buffer_dirty() to dirty the page and inode as well.  But all callers will
      immediately write and clean the buffer anyway, so we can safely leave this
      optimising cheat in place.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      ace476bb
    • Andrew Morton's avatar
      [PATCH] wake_up_forked_thread() fix · 669be61f
      Andrew Morton authored
      Spotted by Randy Dunlap - don't try to return something from a void-returning
      function.
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      669be61f
  2. 08 Jun, 2004 1 commit
  3. 09 Jun, 2004 1 commit
  4. 08 Jun, 2004 1 commit
  5. 09 Jun, 2004 3 commits
  6. 08 Jun, 2004 19 commits
  7. 07 Jun, 2004 7 commits