1. 25 Sep, 2019 1 commit
    • Juliet Kim's avatar
      net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run · b27507bb
      Juliet Kim authored
      Commit a5681e20 ("net/ibmnvic: Fix deadlock problem in reset")
      made the change to hold the RTNL lock during a reset to avoid deadlock
      but linkwatch_event is fired during the reset and needs the RTNL lock.
      That keeps linkwatch_event process from proceeding until the reset
      is complete. The reset process cannot tolerate the linkwatch_event
      processing after reset completes, so release the RTNL lock during the
      process to allow a chance for linkwatch_event to run during reset.
      This does not guarantee that the linkwatch_event will be processed as
      soon as link state changes, but is an improvement over the current code
      where linkwatch_event processing is always delayed, which prevents
      transmissions on the device from being deactivated leading transmit
      watchdog timer to time-out.
      
      Release the RTNL lock before link state change and re-acquire after
      the link state change to allow linkwatch_event to grab the RTNL lock
      and run during the reset.
      
      Fixes: a5681e20 ("net/ibmnvic: Fix deadlock problem in reset")
      Signed-off-by: default avatarJuliet Kim <julietk@linux.vnet.ibm.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b27507bb
  2. 24 Sep, 2019 9 commits
  3. 22 Sep, 2019 12 commits
  4. 21 Sep, 2019 10 commits
  5. 20 Sep, 2019 4 commits
  6. 19 Sep, 2019 4 commits
    • Nathan Chancellor's avatar
      ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident · b47bea2b
      Nathan Chancellor authored
      clang warns:
      
      ../drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:60:37: warning:
      expression result unused [-Wunused-value]
                                  ionic, &identity_fops) ? 0 : -EOPNOTSUPP;
                                                               ^~~~~~~~~~~
      1 warning generated.
      
      The return value of debugfs_create_file does not need to be checked [1]
      and the function returns void so get rid of the ternary operator, it is
      unnecessary.
      
      [1]: https://lore.kernel.org/linux-mm/20150815160730.GB25186@kroah.com/
      
      Fixes: fbfb8031 ("ionic: Add hardware init and device commands")
      Link: https://github.com/ClangBuiltLinux/linux/issues/658Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
      Acked-by: default avatarShannon Nelson <snelson@pensando.io>
      Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b47bea2b
    • Oliver Neukum's avatar
      usbnet: sanity checking of packet sizes and device mtu · 280ceaed
      Oliver Neukum authored
      After a reset packet sizes and device mtu can change and need
      to be reevaluated to calculate queue sizes.
      Malicious devices can set this to zero and we divide by it.
      Introduce sanity checking.
      
      Reported-and-tested-by:  syzbot+6102c120be558c885f04@syzkaller.appspotmail.com
      Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      280ceaed
    • Linus Torvalds's avatar
      Merge tag 'xfs-5.4-merge-7' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux · b41dae06
      Linus Torvalds authored
      Pull xfs updates from Darrick Wong:
       "For this cycle we have the usual pile of cleanups and bug fixes, some
        performance improvements for online metadata scrubbing, massive
        speedups in the directory entry creation code, some performance
        improvement in the file ACL lookup code, a fix for a logging stall
        during mount, and fixes for concurrency problems.
      
        It has survived a couple of weeks of xfstests runs and merges cleanly.
      
        Summary:
      
         - Remove KM_SLEEP/KM_NOSLEEP.
      
         - Ensure that memory buffers for IO are properly sector-aligned to
           avoid problems that the block layer doesn't check.
      
         - Make the bmap scrubber more efficient in its record checking.
      
         - Don't crash xfs_db when superblock inode geometry is corrupt.
      
         - Fix btree key helper functions.
      
         - Remove unneeded error returns for things that can't fail.
      
         - Fix buffer logging bugs in repair.
      
         - Clean up iterator return values.
      
         - Speed up directory entry creation.
      
         - Enable allocation of xattr value memory buffer during lookup.
      
         - Fix readahead racing with truncate/punch hole.
      
         - Other minor cleanups.
      
         - Fix one AGI/AGF deadlock with RENAME_WHITEOUT.
      
         - More BUG -> WARN whackamole.
      
         - Fix various problems with the log failing to advance under certain
           circumstances, which results in stalls during mount"
      
      * tag 'xfs-5.4-merge-7' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux: (45 commits)
        xfs: push the grant head when the log head moves forward
        xfs: push iclog state cleaning into xlog_state_clean_log
        xfs: factor iclog state processing out of xlog_state_do_callback()
        xfs: factor callbacks out of xlog_state_do_callback()
        xfs: factor debug code out of xlog_state_do_callback()
        xfs: prevent CIL push holdoff in log recovery
        xfs: fix missed wakeup on l_flush_wait
        xfs: push the AIL in xlog_grant_head_wake
        xfs: Use WARN_ON_ONCE for bailout mount-operation
        xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT
        xfs: define a flags field for the AG geometry ioctl structure
        xfs: add a xfs_valid_startblock helper
        xfs: remove the unused XFS_ALLOC_USERDATA flag
        xfs: cleanup xfs_fsb_to_db
        xfs: fix the dax supported check in xfs_ioctl_setattr_dax_invalidate
        xfs: Fix stale data exposure when readahead races with hole punch
        fs: Export generic_fadvise()
        mm: Handle MADV_WILLNEED through vfs_fadvise()
        xfs: allocate xattr buffer on demand
        xfs: consolidate attribute value copying
        ...
      b41dae06
    • Linus Torvalds's avatar
      Merge tag 'vfs-5.4-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux · e6bc9de7
      Linus Torvalds authored
      Pull swap access updates from Darrick Wong:
       "Prohibit writing to active swap files and swap partitions.
      
        There's no non-malicious use case for allowing userspace to scribble
        on storage that the kernel thinks it owns"
      
      * tag 'vfs-5.4-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
        vfs: don't allow writes to swap files
        mm: set S_SWAPFILE on blockdev swap devices
      e6bc9de7