- 30 Apr, 2016 23 commits
-
-
Claudiu Beznea authored
This patch frees memory allocated inside mkimage() in case mkimage() or any other subsequent calls inside prism2_fwapply() from prism2fw.c file fails. To fix this I introduces goto labels where the free operation is done in case some operations fails. After the introduction of goto labels has been done, in order to use the same return path, "return x" instuctions were replaced with "goto" instuctions. Signed-off-by:
Claudiu Beznea <claudiu.beznea@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Nicholas Sim authored
It is not necessary to compare explicitly to NULL. Rewrite if condition as (!dev) or (dev) as suggested in Documentation/CodingStyle Signed-off-by:
Nicholas Sim <nicholassimws@gmail.com> Signed-off-by:
-
Sudip Mukherjee authored
ion_device_create() can fail and if it fails then it returns the error value in ERR_PTR. Signed-off-by:
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Reviewed-by:
Laura Abbott <labbott@redhat.com> Signed-off-by:
-
Ben Marsh authored
Modify memory allocation style in order to silence a checkpatch.pl warning. Signed-off-by:
Ben Marsh <bmarsh94@gmail.com> Signed-off-by:
-
Ben Marsh authored
Modifies the memory allocation style ion_test.c in order to remove a checkpatch.pl warning Signed-off-by:
-
Markus Böhme authored
Functions ion_handle_put and ion_handle_get_by_id are only used locally in ion.c, so they should be made static as they used to be before 9590232b ("staging/android/ion : fix a race condition in the ion driver"). Signed-off-by:
Markus Böhme <markus.boehme@mailbox.org> Reviewed-by:
Sumit Semwal <sumit.semwal@linaro.org> Reviewed-by:
-
Gustavo Padovan authored
Add sync_file documentation on dma-buf-sync_file.txt Reviewed-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by:
-
Gustavo Padovan authored
Add entry in device-drivers.tmpl for sync_file documentation. Signed-off-by:
Gustavo Padovan <gustavo.padovan@collabora.co.uk> Reviewed-by:
-
Gustavo Padovan authored
sync_file is useful to connect one or more fences to the file. The file is used by userspace to track fences between drivers that share DMA bufs. Signed-off-by:
-
Gustavo Padovan authored
Move sync_file headers file to include/ dir. Signed-off-by:
-
Gustavo Padovan authored
Fix checks reported by checkpatch.pl. Signed-off-by:
-
Gustavo Padovan authored
num_fences was missing a colon mark and sync_file_create() now have better description. Signed-off-by:
-
Gustavo Padovan authored
Move its functions and structs to their own file. Also moves function's docs to the .c file. Signed-off-by:
-
Gustavo Padovan authored
Simplifies the API to only receive the fence it needs to add to the sync and create a name for the sync_file based on the fence context and seqno. Signed-off-by:
-
Gustavo Padovan authored
There is no plan in the near future to use this function outside of this file so keep it as static. Signed-off-by:
-
Gustavo Padovan authored
There is no plan in the near future to use this function outside of this file so keep it as static. Signed-off-by:
-
Gustavo Padovan authored
To keep comments in line with drivers/dma-buf/ move all sync_file comments to sync.c. Signed-off-by:
-
Gustavo Padovan authored
These two functions are just wrappers for one line functions, they call fd_install() and fput() respectively, so just get rid of them and use fd_install() and fput() directly for more simplicity. Signed-off-by:
-
Gustavo Padovan authored
struct sync_merge_data already have documentation on top of the struct definition. No need to duplicate it. Signed-off-by:
Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Reviewed-by:
-
Gustavo Padovan authored
Change SYNC_IOC_FILE_INFO (former SYNC_IOC_FENCE_INFO) behaviour to avoid future API breaks and optimize buffer allocation. Now num_fences can be filled by the caller to inform how many fences it wants to retrieve from the kernel. If the num_fences passed is greater than zero info->sync_fence_info should point to a buffer with enough space to fit all fences. However if num_fences passed to the kernel is 0, the kernel will reply with number of fences of the sync_file. Sending first an ioctl with num_fences = 0 can optimize buffer allocation, in a first call with num_fences = 0 userspace will receive the actual number of fences in the num_fences filed. Then it can allocate a buffer with the correct size on sync_fence_info and call SYNC_IOC_FILE_INFO again, but now with the actual value of num_fences in the sync_file. info->sync_fence_info was converted to __u64 pointer to prevent 32bit compatibility issues. And a flags member was added. An example userspace code for the later would be: struct sync_file_info *info; int err, size, num_fences; info = malloc(sizeof(*info)); info.flags = 0; err = ioctl(fd, SYNC_IOC_FILE_INFO, info); num_fences = info->num_fences; if (num_fences) { info.flags = 0; size = sizeof(struct sync_fence_info) * num_fences; info->num_fences = num_fences; info->sync_fence_info = (uint64_t) calloc(num_fences, sizeof(struct sync_fence_info)); err = ioctl(fd, SYNC_IOC_FILE_INFO, info); } Finally the IOCTLs numbers were changed to avoid any potential old userspace running the old API to get weird errors. Changing the opcodes will make them fail right away. This is just a precaution, there no upstream users of these interfaces yet and the only user is Android, but we don't expect anyone trying to run android userspace and all it dependencies on top of upstream kernels. Signed-off-by:Greg Hackmann <ghackmann@google.com> Acked-by:
Rob Clark <robdclark@gmail.com> Acked-by:
-
Gustavo Padovan authored
This function had copies in 3 different files. Unify them in kernel.h. Cc: Joe Perches <joe@perches.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Rob Clark <robdclark@gmail.com> Signed-off-by:
-
Leo Sperling authored
Remove the "s" from kills so that the help message is easier to understand Signed-off-by:
Leo Sperling <leosperling97@gmx.de> Signed-off-by:
-
Laura Abbott authored
The android drivers have a few other people reviewing patches. Add a separate entry to ensure patches go to the right people. Signed-off-by:
-
- 29 Apr, 2016 17 commits
-
-
Jes Sorensen authored
This driver is deprecated and superseded by rtl8xxxu. It will be removed in a future kernel release. Add a warning to Kconfig and at device init time to notify users and allow them time to switch over. Signed-off-by:
Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by:
-
H Hartley Sweeten authored
These bit defines are only used in the mite driver. Move them so they are not needlessly exposed. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
Currently this function returns the value read from the mite channel status register. None of the callers use, or need, the returned value. For aesthetics, change the return to void. Signed-off-by:
-
H Hartley Sweeten authored
The mite dma is always synced on a LINKC status. Some of the mite users sync the dma regadless of the status. Add a 'sync' parameter to mite_ack_linkc() to force a dma sync. Then do the dma sync as needed. Signed-off-by:
-
H Hartley Sweeten authored
This function only handles the analog input interrupts, the dma was already handled. Remove the unecessary parameter and fix ni_E_interrupts() so that the comedi events are properly handled. Signed-off-by:
-
H Hartley Sweeten authored
Simplfy the LINKC handing for the analog input dma by moving it into the main interrupt handler. This function already hold the spinlock mite_channel_lock so call mite_sync_dma() directly instead of using the helper function. Signed-off-by:
-
H Hartley Sweeten authored
There may not be a dev->read_subdev, i.e. an analog input subdevice, that supports async commands. If it doesn't exist the interrupt/dma will never be enabled. Fix ni_E_interrupt() so that the analog input subdevice is only handled if it exists. This also fixes minor NULL dereference issue in handle_a_interrupt(). If the dev->read_subdev is NULL the comedi_async pointer (s->async) will not be allocated by the device postconfig so there is no way to get a valid comedi_cmd (&s->async->cmd). Signed-off-by:
-
H Hartley Sweeten authored
This function only handles the analog input interrupts, the dma was already handled. Remove the unecessary parameter and fix ni_E_interrupts() so that the comedi events are properly handled. Signed-off-by:
-
H Hartley Sweeten authored
There may not be a dev->write_subdev, i.e. an analog output subdevice, that supports async commands. If it doesn't exist the interrupt/dma will never be enabled. Fix ni_E_interrupt() so that the analog output subdevice is only handled if it exists. Signed-off-by:
-
H Hartley Sweeten authored
Simplfy the LINKC handing by removing the helper function and moving the mite_sync_dma() into the main interrupt handler. Signed-off-by:
-
H Hartley Sweeten authored
Currently only some of the users of mite dma check for transfer errors. The ni_mio_common code does the check for the analog input and analog output subdevices. The m-series digital I/O subdevice and the counter subdevices (handled by ni_tiocmd) do not check. The ni_pcidio driver checks for the digital input subdevice. The ni_660x driver counter subdevices (handled by ni_tiocmd) also do not check. Move the transfer error checking into mite_ack_linkc() so that the drivers that use mite don't have to deal with it. This also makes sure that all the subdevices that use mite for dma will cancel the async command if a transfer error is detected. Simplfy the transfer error check by just checking the CHSR_XFERR bit. This bit will be set if one or more transfer processes terminated with an error. The actual error is determined by the LERR, MERR, and DERR bits. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetics, convert the register/bit enums into defines and use the BIT() macro to define the bits. Signed-off-by:
-
H Hartley Sweeten authored
Prior to calling this function pci_ioremap_bar() is called. If the pci_resource_len(), i.e. the 'size', was 0 the ioremap would fail so this function would never be called. So the first BUG_ON() can never occur. The 'order' returned by ilog2() will always be > 0 so the second BUG_ON() will also never occur. Remove the unnecessary BUG_ON() checks and tidy up the function. Signed-off-by:
-
H Hartley Sweeten authored
Add a comment to fix the checkpatch.pl issue: CHECK: spinlock_t definition without comment Signed-off-by:
-
H Hartley Sweeten authored
Rename the CamelCase symbols to fix the checkpatch.pl issues. Signed-off-by:
-
H Hartley Sweeten authored
The struct mite_channel 'dir' member specifies if the dma is input or output. Wrap the mite_sync_input_dma() and mite_sync_output_dma() functions with a single mite_sync_dma() so that the drivers don't have to worry about the sync direction. The functions that actually sync the input/output dma currently return -1 if an overflow/underrun is detected otherwise they return 0. If an overflow/underrun is detected the async->event COMEDI_CB_OVERFLOW is also set. The callers never check the return value anyway so just make the functions return void. The async->event can be checked if necessary to detect any errors. Signed-off-by:
-
H Hartley Sweeten authored
Most of the mite registers are only accessed by the mite driver. There is no reason to expose the register/bit info. Remove this info from the header. For aesthetics, convert the bit info enums into defines and use the BIT() macro to define them. Tidy up the inline functions for the retry limit and drq reqs bits in the config registers. Signed-off-by:
-
