• Konstantin Osipov's avatar
    WL#5419 "LOCK_open scalability: make tdc_refresh_version · 33c57e2f
    Konstantin Osipov authored
    an atomic counter"
    
    Split the large LOCK_open section in open_table(). 
    Do not call open_table_from_share() under LOCK_open.
    Remove thd->version.
    
    This fixes
    Bug#50589 "Server hang on a query evaluated using a temporary 
    table"
    Bug#51557 "LOCK_open and kernel_mutex are not happy together"
    Bug#49463 "LOCK_table and innodb are not nice when handler 
    instances are created".
    
    This patch has effect on storage engines that rely on
    ha_open() PSEA method being called under LOCK_open.
    In particular:
    
    1) NDB is broken and left unfixed. NDB relies on LOCK_open
    being kept as part of ha_open(), since it uses auto-discovery.
    While previously the NDB open code was race-prone, now
    it simply fails on asserts.
    
    2) HEAP engine had a race in ha_heap::open() when
    a share for the same table could be added twice
    to the list of shares, or a dangling reference to a share
    stored in HEAP handler. This patch aims to address this
    problem by 'pinning' the newly created share in the 
    internal HEAP engine share list until at least one
    handler instance is created using that share.
    
    
    include/heap.h:
      Add members to HP_CREATE_INFO.
      Declare heap_release_share().
    sql/lock.cc:
      Remove thd->version, use thd->open_tables->s->version instead.
    sql/repl_failsafe.cc:
      Remove thd->version.
    sql/sql_base.cc:
      - close_thread_table(): move handler cleanup code outside the critical section protected by LOCK_open.
      - remove thd->version
      - split the large critical section in open_table() that
      opens a new table from share and is protected by LOCK_open
      into 2 critical sections, thus reducing the critical path.
      - make check_if_table_exists() acquire LOCK_open internally.
      - use thd->open_tables->s->version instead of thd->refresh_version to make sure that all tables in
      thd->open_tables are in the same refresh series.
    sql/sql_base.h:
      Add declaration for check_if_table_exists().
    sql/sql_class.cc:
      Remove init_open_tables_state(), it's now equal to
      reset_open_tables_state().
    sql/sql_class.h:
      Remove thd->version, THD::init_open_tables_state().
    sql/sql_plugin.cc:
      Use table->m_needs_reopen to mark the table as stale
      rather than manipulate with thd->version, which is no more.
    sql/sql_udf.cc:
      Use table->m_needs_reopen to mark the table as stale
      rather than manipulate with thd->version, which is no more.
    sql/table.h:
      Remove an unused variable.
    sql/tztime.cc:
      Use table->m_needs_reopen to mark the table as stale
      rather than manipulate with thd->version, which is no more.
    storage/heap/CMakeLists.txt:
      Add heap tests to cmake build files.
    storage/heap/ha_heap.cc:
      Fix a race when ha_heap::ha_open() could insert two 
      HP_SHARE objects into the internal share list or store
      a dangling reference to a share in ha_heap instance,
      or wrongly set implicit_emptied.
    storage/heap/hp_create.c:
      Optionally pin a newly created share in the list of shares
      by increasing its open_count. This is necessary to 
      make sure that a newly created share doesn't disappear while
      a HP_INFO object is being created to reference it.
    storage/heap/hp_open.c:
      When adding a new HP_INFO object to the list of objects
      in the heap share, make sure the open_count is not increased
      twice.
    storage/heap/hp_test1.c:
      Adjust the test to new function signatures.
    storage/heap/hp_test2.c:
      Adjust the test to new function signatures.
    33c57e2f
heap.h 8.86 KB