Commit d74ce24d authored by Joerg Bruehe's avatar Joerg Bruehe

Upmerge the second fix for bug#40546 from 5.0 to 5.1

and fix a defect specific to 5.1 (wrong quoting).

support-files/mysql.spec.sh:
  Merge the general flag handling (embedding in blanks) from 5.0 to 5.1,
  add the 5.1 specific part (do not escape unquoted quote marks).
  Still part of the fix for bug#40546.
parents 3080e061 e6f397a1
...@@ -326,13 +326,17 @@ CXXFLAGS=${MYSQL_BUILD_CXXFLAGS:-$RPM_OPT_FLAGS -felide-constructors -fno-except ...@@ -326,13 +326,17 @@ CXXFLAGS=${MYSQL_BUILD_CXXFLAGS:-$RPM_OPT_FLAGS -felide-constructors -fno-except
( (
# We are in a subshell, so we can modify variables just for one run. # We are in a subshell, so we can modify variables just for one run.
CFLAGS=`echo $CFLAGS | sed -e 's/-O[0-9]* //' -e 's/-unroll2 //' -e 's/-ip //' -e 's/$/ -g/'` CFLAGS=`echo " $CFLAGS " | \
CXXFLAGS=`echo $CXXFLAGS | sed -e 's/-O[0-9]* //' -e 's/-unroll2 //' -e 's/-ip //' -e 's/$/ -g/'` sed -e 's/ -O[0-9]* / /' -e 's/ -unroll2 / /' -e 's/ -ip / /' \
-e 's/^ //' -e 's/ $//'`
CXXFLAGS=`echo " $CXXFLAGS " | \
sed -e 's/ -O[0-9]* / /' -e 's/ -unroll2 / /' -e 's/ -ip / /' \
-e 's/^ //' -e 's/ $//'`
# Add -g and --with-debug. # Add -g and --with-debug.
cd mysql-debug-%{mysql_version} && cd mysql-debug-%{mysql_version} &&
CFLAGS=\"$CFLAGS\" \ CFLAGS="$CFLAGS" \
CXXFLAGS=\"$CXXFLAGS\" \ CXXFLAGS="$CXXFLAGS" \
BuildMySQL "--enable-shared \ BuildMySQL "--enable-shared \
--with-debug \ --with-debug \
--with-innodb \ --with-innodb \
...@@ -364,8 +368,8 @@ fi ...@@ -364,8 +368,8 @@ fi
############################################################################## ##############################################################################
(cd mysql-release-%{mysql_version} && (cd mysql-release-%{mysql_version} &&
CFLAGS=\"$CFLAGS\" \ CFLAGS="$CFLAGS" \
CXXFLAGS=\"$CXXFLAGS\" \ CXXFLAGS="$CXXFLAGS" \
BuildMySQL "--enable-shared \ BuildMySQL "--enable-shared \
--with-innodb \ --with-innodb \
%if %{CLUSTER_BUILD} %if %{CLUSTER_BUILD}
...@@ -840,6 +844,11 @@ fi ...@@ -840,6 +844,11 @@ fi
# itself - note that they must be ordered by date (important when # itself - note that they must be ordered by date (important when
# merging BK trees) # merging BK trees)
%changelog %changelog
* Fri Nov 07 2008 Joerg Bruehe <joerg@mysql.com>
- Correct yesterday's fix, so that it also works for the last flag,
and fix a wrong quoting: un-quoted quote marks must not be escaped.
* Thu Nov 06 2008 Joerg Bruehe <joerg@mysql.com> * Thu Nov 06 2008 Joerg Bruehe <joerg@mysql.com>
- Modify CFLAGS and CXXFLAGS such that a debug build is not optimized. - Modify CFLAGS and CXXFLAGS such that a debug build is not optimized.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment