An error occurred fetching the project authors.
  1. 14 Sep, 2005 1 commit
    • dlenev@mysql.com's avatar
      Fix for bug #12704 "Server crashes during trigger execution". · e231ebe5
      dlenev@mysql.com authored
      This bug occurs when some trigger for table used by DML statement is created
      or changed while statement was waiting in lock_tables(). In this situation
      prelocking set which we have calculated becames invalid which can easily lead
      to errors and even in some cases to crashes.
      
      With proposed patch we no longer silently reopen tables in lock_tables(),
      instead caller of lock_tables() becomes responsible for reopening tables and
      recalculation of prelocking set.
      e231ebe5
  2. 13 Sep, 2005 2 commits
    • gluh@eagle.intranet.mysql.r18.ru's avatar
      Bug#9683 INFORMATION_SCH: Creation of temporary table allowed in · cc395fc0
      gluh@eagle.intranet.mysql.r18.ru authored
               Information_schema DB 
      Bug#9846 Inappropriate error displayed while
               dropping table from 'INFORMATION_SCHEMA'
      Bug#10734 Grant of privileges other than 'select' and 
               'create view' should fail on schema 
      Bug#10708 SP's can use INFORMATION_SCHEMA as ROUTINE_SCHEMA
      
       cumulative fix for bugs above(after review, 2nd version)
       added privilege check for information schema db & tables
      cc395fc0
    • kent@mysql.com's avatar
      sql_prepare.cc: · ffc213a1
      kent@mysql.com authored
        VC6 can't handle initializing const in declaration
      ffc213a1
  3. 02 Sep, 2005 2 commits
    • konstantin@mysql.com's avatar
      Implement WL#2661 "Prepared Statements: Dynamic SQL in Stored Procedures". · 38486e83
      konstantin@mysql.com authored
      The idea of the patch is to separate statement processing logic,
      such as parsing, validation of the parsed tree, execution and cleanup, 
      from global query processing logic, such as logging, resetting
      priorities of a thread, resetting stored procedure cache, resetting
      thread count of errors and warnings.
      This makes PREPARE and EXECUTE behave similarly to the rest of SQL
      statements and allows their use in stored procedures.
      This patch contains a change in behaviour:
      until recently for each SQL prepared statement command, 2 queries
      were written to the general log, e.g.
      [Query]   prepare stmt from @stmt_text;
      [Prepare] select * from t1 <-- contents of @stmt_text
      The chagne was necessary to prevent [Prepare] commands from being written
      to the general log when executing a stored procedure with Dynamic SQL.
      We should consider whether the old behavior is preferrable and probably
      restore it.
      This patch refixes Bug#7115, Bug#10975 (partially), Bug#10605 (various bugs
      in Dynamic SQL reported before it was disabled).
      38486e83
    • konstantin@mysql.com's avatar
      Rename: · a3ddcdf8
      konstantin@mysql.com authored
      - current_arena to stmt_arena: the thread may have more than one
      'current' arenas: one for runtime data, and one for the parsed 
      tree of a statement. Only one of them is active at any moment.
      - set_item_arena -> set_query_arena, because Item_arena was renamed to 
      Query_arena a while ago
      - set_n_backup_item_arena -> set_n_backup_active_arena;
      the active arena is the arena thd->mem_root and thd->free_list
      are currently pointing at.
      - restore_backup_item_arena -> restore_active_arena (with the same
      rationale)
      - change_arena_if_needed -> activate_stmt_arena_if_needed; this
      method sets thd->stmt_arena active if it's not done yet.
      a3ddcdf8
  4. 19 Aug, 2005 1 commit
  5. 17 Aug, 2005 1 commit
    • elliot@mysql.com's avatar
      BUG#11338 (logging of prepared statement w/ blob type) · 19778260
      elliot@mysql.com authored
      In cp932, '\' character can be the second byte in a 
      multi-byte character stream. This makes it difficult to use
      mysql_escape_string. Added flag to indicate which languages allow
      '\' as second byte of multibyte sequence so that when putting a prepared
      statement into the binlog we can decide at runtime whether hex encoding
      is really needed.
      19778260
  6. 10 Aug, 2005 1 commit
  7. 09 Aug, 2005 1 commit
  8. 08 Aug, 2005 3 commits
    • sergefp@mysql.com's avatar
      Fix for BUG#12228: SP cache code: · c6db76b0
      sergefp@mysql.com authored
      * Cleanup SP Cache code, now SP Cache only deletes sp_head objects in 
        sp_cache_flush_obsolete() invalidates all pointers to routines in the cache.
      * Use new SP Cache use contract in the code.
      
      There is no test case because it doesn't seem to be possible to cause thread races to end
      the same way they end in heavy-load test. This patch removes the crash in heavy test.
      c6db76b0
    • konstantin@mysql.com's avatar
      A fix and a test case for Bug#11909 "mysql_stmt_attr_set · 043f77cc
      konstantin@mysql.com authored
      CURSOR_TYPE_READ_ONLY nested queries corrupt result"
      043f77cc
    • dlenev@mysql.com's avatar
      Fix for bug #10055 "Using stored function with information_schema causes empty · 615baa9f
      dlenev@mysql.com authored
      result set".
      
      To enable full access to contents of I_S tables from stored functions
      or statements that use them, we manipulate with thread's open tables
      state and ensure that we won't cause deadlock when we open tables by
      ignoring flushes and name-locks.
      Building of contents of I_S.TABLES no longer requires locking of tables
      since we use use handler::info() method with HA_STATUS_AUTO flag instead
      of handler::update_auto_increment() for obtaining information about
      auto-increment values. But this also means that handlers have to implement
      support for HA_STATUS_AUTO flag (particularly InnoDB needs it).
      615baa9f
  9. 29 Jul, 2005 1 commit
  10. 27 Jul, 2005 1 commit
  11. 19 Jul, 2005 2 commits
  12. 18 Jul, 2005 1 commit
    • monty@mishka.local's avatar
      Cleanups during review · 78c65b5a
      monty@mishka.local authored
      Changed defaults option --instance to --defaults-group-suffix
      Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
      Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX
      mysql_print_defaults now understands --defaults-group-suffix
      Remove usage of my_tempnam() (not safe function)
      if( -> if ( and while( to while (
      78c65b5a
  13. 15 Jul, 2005 1 commit
  14. 14 Jul, 2005 1 commit
  15. 13 Jul, 2005 1 commit
    • konstantin@mysql.com's avatar
      - a fix for Bug#11458 "Prepared statement with subselects return random · bef558b7
      konstantin@mysql.com authored
      data": remove the fix for another bug (8807) that
      added OUTER_REF_TABLE_BIT to all subqueries that used a placeholder
      to prevent their evaluation at prepare. As this bit hanged in 
      Item_subselect::used_tables_cache for ever, a constant subquery with
      a placeholder was never evaluated as such, which caused wrong 
      choice of the execution plan for the statement.
      - to fix Bug#8807 backport a better fix from 5.0
      - post-review fixes.
      bef558b7
  16. 04 Jul, 2005 1 commit
  17. 01 Jul, 2005 4 commits
  18. 27 Jun, 2005 1 commit
    • monty@mishka.local's avatar
      Better bug fix for: · 83f90e06
      monty@mishka.local authored
      #9728  'Decreased functionality in "on duplicate key update
      #8147  'a column proclaimed ambigous in INSERT ... SELECT .. ON DUPLICATE'
      
      This ensures fields are uniquely qualified and also that one can't update other tables in the ON DUPLICATE KEY UPDATE part
      83f90e06
  19. 23 Jun, 2005 1 commit
    • konstantin@mysql.com's avatar
      - implement inheritance of sp_instr: public Query_arena. · 4c407943
      konstantin@mysql.com authored
        We need every instruction to have its own arena, because we want to
        track instruction's state (INITIALIZED_FOR_SP -> EXECUTED). Because of 
        `if' statements and other conditional instructions used in stored 
        procedures, not every instruction of a stored procedure gets executed 
        during the first (or even subsequent) execution of the procedure. 
        So it's better if we track the execution state of every instruction 
        independently.
        All instructions of a given procedure now also share sp_head's 
        mem_root, but keep their own free_list.
        This simplifies juggling with free Item lists in sp_head::execute.
      - free_items() moved to be a member of Query_arena. 
      - logic of 'backup_arena' debug member of Query_arena has been
        changed to support
        multi-backups. Until now, TRUE 'backup_arena' meant that there is
        exactly one active backup of the THD arena. Now it means simply that
        the arena is used for backup, so that we can't accidentally overwrite an 
        existing backup. This allows doing multiple backups, e.g. in
        sp_head::execute and Cursor::fetch, when THD arena is already backed up
        but we want to set yet another arena (usually the 'permanent' arena,
        to save permanent transformations/optimizations of a parsed tree).
      4c407943
  20. 22 Jun, 2005 2 commits
  21. 20 Jun, 2005 1 commit
  22. 17 Jun, 2005 1 commit
  23. 16 Jun, 2005 2 commits
  24. 15 Jun, 2005 1 commit
    • serg@serg.mylan's avatar
      renamed: · 01b3c709
      serg@serg.mylan authored
        Item_buff -> Cached_item
        Item_arena -> Query_arena
        TEST_ASSERT -> YYERROR_UNLESS
      01b3c709
  25. 09 Jun, 2005 1 commit
  26. 08 Jun, 2005 3 commits
  27. 07 Jun, 2005 1 commit
  28. 16 May, 2005 1 commit