- 19 Sep, 2019 1 commit
-
-
Marko Mäkelä authored
Define the function in the same compilation unit as its only callers page_cur_insert_rec_low() and page_cur_insert_rec_zip().
-
- 18 Sep, 2019 3 commits
-
-
Marko Mäkelä authored
page_mem_free(): Define in the same file with the only caller page_cur_delete_rec(). page_dir_slot_set_rec(): Add const qualifier to a parameter. page_dir_delete_slot(): Merge with the only caller page_dir_balance_slot(). page_dir_add_slot(): Merge with the only caller page_dir_split_slot(). page_dir_split_slot(), page_dir_balance_slot(): Define in the same compilation unit with the callers, and simplify the code.
-
Sachin authored
-
Sachin authored
-
- 17 Sep, 2019 3 commits
-
-
Marko Mäkelä authored
-
Alexander Barkov authored
Hiding the definitions inside Type_handler_xxx::name(). This is needed to avoid exporting members with MYSQL_PLUGIN_IMPORT, which would be needed to compile data type plugins on Windows.
-
Alexander Barkov authored
Introducing methods instead: const Name version_mysql56() const; const Name version_mariadb53() const; This is needed to avoid exporting members with MYSQL_PLUGIN_IMPORT, which would be needed to compile data type plugins on Windows.
-
- 16 Sep, 2019 2 commits
-
-
Jan Lindström authored
-
Jan Lindström authored
-
- 15 Sep, 2019 1 commit
-
-
Teemu Ollakka authored
Command COM_SHUTDOWN was rejected in non-Primary because server_command_flags[COM_SHUTDOWN] had value CF_NO_COM_MULTI instead of CF_SKIP_WSREP_CHECK. As a fix removed assignment server_command_flags[CF_NO_COM_MULTI]= CF_NO_COM_MULTI which overwrote server_command_flags[COM_SHUTDOWN].
-
- 14 Sep, 2019 4 commits
-
-
Jan Lindström authored
-
Jan Lindström authored
-
Jan Lindström authored
-
Jan Lindström authored
-
- 13 Sep, 2019 4 commits
-
-
Alexander Barkov authored
MDEV-20228 `mysql_upgrade` fails on every version upgrade: "ERROR 1267 (HY000) at line 7: Illegal mix of collations (utf8mb4_unicode_ci,COERCIBLE) and (utf8mb4_general_ci,COERCIBLE) for operation 'like'"
-
Alexander Barkov authored
MDEV-18153 Assertion `0' or Assertion `btr_validate_index(index, 0)' failed in row_upd_sec_index_entry or error code 126: Index is corrupted upon UPDATE with TIME_ROUND_FRACTIONAL Conversion to a temporal data type resulting into a lower precision depends on TIME_ROUND_FRACTIONAL. Taking into account this dependency in: - indexed generated virtual column expressions - persistent virtual column expressions A warning is now issued if conversion from the generation expression to the column data type depends on TIME_ROUND_FRACTIONAL. The warning will be changed to error in 10.5
-
Marko Mäkelä authored
-
Igor Babaev authored
-
- 12 Sep, 2019 12 commits
-
-
Sergei Petrunia authored
Followup patch: fix typos
-
Marko Mäkelä authored
Follow-up to 9d26f3da: do not declare a never-overloaded function as virtual.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Ian Gilfillan authored
Closes PR #1385
-
Marko Mäkelä authored
-
Marko Mäkelä authored
innobase_rename_or_enlarge_column_try(): Relax a debug assertion. The DATA_VERSIONED bits in dict_col_t::prtype do not affect the storage format.
-
Alexey Botchkov authored
Fixed 4-byte length characters handled incorrectly.
-
Sachin authored
Rerecord sysvars_server_notembedded
-
Jan Lindström authored
Problem was that if user used bad wsrep configuration we call unireg_abort and in wsrep case there is check to wsrep_server_state that might not yet be initialized. Fixed by checking that wsrep_server_state is initialized before checking it's state. Changes to be committed: modified: sql/mysqld.cc modified: sql/wsrep_server_state.h
-
- 11 Sep, 2019 10 commits
-
-
Marko Mäkelä authored
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
Marko Mäkelä authored
In mysql-server/commit@f46329044f8618212923bdf52e15d5b464201edc the InnoDB function btr_cur_open_at_rnd_pos() was corrected so that it would return a status that indicates whether the cursor was successfully positioned. But this change was not correctly merged to MariaDB in 2e814d47. btr_cur_open_at_rnd_pos(): In the code path that was introduced in MDEV-8588, properly return failure status. No deterministic test case was found for this failure. It was caught after removing the function page_copy_rec_list_end_to_created_page() in a development branch. As a result, the fill factor of index trees would improve, and supposedly, so would the probability of btr_cur_open_at_rnd_pos() reaching the intentionally corrupted page in the test innodb.leaf_page_corrupted_during_recovery. The wrong return value would cause btr_estimate_number_of_different_key_vals() to wrongly invoke btr_rec_get_externally_stored_len() on a non-leaf page and trigger an assertion failure at the start of that function.
-
Thirunarayanan Balathandayuthapani authored
- During trx_undo_report_rename(), InnoDB can fail to write undo log for it if undo log doesn't fit in the undo page. In that case, InnoDB adds one more undo log page and retry to write the rename undo log. But the assert is wrong and it doesn't allow to fail even for one time.
-
Alexander Barkov authored
Revert "Part3: MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH" This reverts commit 5a9e2b77 in 10.5, so it produces an error on "bad" generated columns. Note, 10.2, 10.3, 10.4 produce only warnings, for backward compatibility.
-
Sachin authored
Cherry-pick the commits the mysql and some changes. WL#4618 RBR: extended table metadata in the binary log This patch extends Table Map Event. It appends some new fields for more metadata. The new metadata includes: - Signedness of Numberic Columns - Character Set of Character Columns and Binary Columns - Column Name - String Value of SET Columns - String Value of ENUM Columns - Primary Key - Character Set of SET Columns and ENUM Columns - Geometry Type Some of them are optional, the patch introduces a GLOBAL system variable to control it. It is binlog_row_metadata. - Scope: GLOBAL - Dynamic: Yes - Type: ENUM - Values: {NO_LOG, MINIMAL, FULL} - Default: NO_LOG Only Signedness, character set and geometry type are logged if it is MINIMAL. Otherwise all of them are logged. Also add a binlog_type_info() to field, So that we can have extract relevant binlog info from field.
-
Alexander Barkov authored
-
Marko Mäkelä authored
-