1. 14 Jul, 2020 4 commits
  2. 13 Jul, 2020 1 commit
    • Marko Mäkelä's avatar
      MDEV-22988 Corrupted table after DROP INDEX · de208723
      Marko Mäkelä authored
      This form of corruption was only reproduced on MariaDB 10.5.4
      after the MDEV-22867 fix was applied in
      commit 43120009.
      
      While we do not know how to reproduce this corruption in
      MariaDB 10.4, we are applying the code fix without a test case.
      
      btr_cur_pessimistic_update(): Invoke btr_set_instant() if needed.
      de208723
  3. 11 Jul, 2020 1 commit
  4. 10 Jul, 2020 1 commit
    • Alexey Botchkov's avatar
      MDEV-21385 PAM v2 plugin produces lots of zombie processes. · 873eb4a3
      Alexey Botchkov authored
      The auth_pam_tool that is executed from pam_auth() can be still
      not finished by the time we do the waitpid() there.
      As we use WNOHANG option for the waitpid(), it didn't wait and
      left the zombie process. So let's do the loop of waitpid() with the
      limited number of sleeps.
      873eb4a3
  5. 08 Jul, 2020 2 commits
  6. 04 Jul, 2020 2 commits
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · b99fa1e7
      Marko Mäkelä authored
      b99fa1e7
    • Marko Mäkelä's avatar
      Fixup the parent commit for MSAN and Valgrind · 453dc4b3
      Marko Mäkelä authored
      commit 48493132 was a necessary
      fix for the buffer pool resizing tests in 10.5 in
      AddressSanitizer. However, that change would break the tests
      innodb.innodb_buffer_pool_resize and
      innodb.innodb_buffer_pool_resize_with_chunks
      when run in MemorySanitizer, or presumably in Valgrind as well.
      (Those tests run "forever" in Valgrind.)
      
      buf_pool_resize(): Cancel the effect of MEM_NOACCESS() in Valgrind
      and ASAN. In MSAN, MEM_NOACCESS() is a no-op, and hence we must do
      nothing special here.
      
      MEM_MAKE_ADDRESSABLE() would declare the memory contents undefined.
      In this particular case, we must actually declare the contents
      defined for Valgrind.
      453dc4b3
  7. 03 Jul, 2020 3 commits
  8. 02 Jul, 2020 15 commits
  9. 01 Jul, 2020 11 commits
    • Oleksandr Byelkin's avatar
      MDEV-22983: Mariabackup's --help option disappeared · b0f83605
      Oleksandr Byelkin authored
      return --help option
      b0f83605
    • Marko Mäkelä's avatar
      MDEV-20377: Fix -Wunused-but-set-variable · 69df4f83
      Marko Mäkelä authored
      69df4f83
    • Vladislav Vaintroub's avatar
      MDEV-23067 Windows : manually registered services rejected mysql_upgrade_service · 41b0d98e
      Vladislav Vaintroub authored
      - service not using "--defaults-file" can have any name not just "MySQL"
      - service with "--defaults-file", without datadir in them
      use default datadir (install_root\data)
      41b0d98e
    • Marko Mäkelä's avatar
      be517384
    • Marko Mäkelä's avatar
      MDEV-20377: Make WITH_MSAN more usable · c36834c8
      Marko Mäkelä authored
      MemorySanitizer (clang -fsanitize=memory) requires that all code
      be compiled with instrumentation enabled. The only exception is the
      C runtime library. Failure to use instrumented libraries will cause
      bogus messages about memory being uninitialized.
      
      In WITH_MSAN builds, we must avoid calling getservbyname(),
      because even though it is a standard library function, it is
      not instrumented, not even in clang 10.
      
      Note: Before MariaDB Server 10.5, ./mtr will typically fail
      due to the old PCRE library, which was updated in MDEV-14024.
      
      The following cmake options were tested on 10.5
      in commit 94d0bb4d:
      
      cmake \
      -DCMAKE_C_FLAGS='-march=native -O2' \
      -DCMAKE_CXX_FLAGS='-stdlib=libc++ -march=native -O2' \
      -DWITH_EMBEDDED_SERVER=OFF -DWITH_UNIT_TESTS=OFF -DCMAKE_BUILD_TYPE=Debug \
      -DWITH_INNODB_{BZIP2,LZ4,LZMA,LZO,SNAPPY}=OFF \
      -DPLUGIN_{ARCHIVE,TOKUDB,MROONGA,OQGRAPH,ROCKSDB,CONNECT,SPIDER}=NO \
      -DWITH_SAFEMALLOC=OFF \
      -DWITH_{ZLIB,SSL,PCRE}=bundled \
      -DHAVE_LIBAIO_H=0 \
      -DWITH_MSAN=ON
      
      MEM_MAKE_DEFINED(): An alias for VALGRIND_MAKE_MEM_DEFINED()
      and __msan_unpoison().
      
      MEM_GET_VBITS(), MEM_SET_VBITS(): Aliases for
      VALGRIND_GET_VBITS(), VALGRIND_SET_VBITS(), __msan_copy_shadow().
      
      InnoDB: Replace the UNIV_MEM_ macros with corresponding MEM_ macros.
      
      ut_crc32_8_hw(), ut_crc32_64_low_hw(): Use the compiler built-in
      functions instead of inline assembler when building WITH_MSAN.
      This will require at least -msse4.2 when building for IA-32 or AMD64.
      The inline assembler would not be instrumented, and would thus cause
      bogus failures.
      c36834c8
    • Sergei Golubchik's avatar
      MDEV-21222 mariabackup.incremental_backup failed with memory allocation failure · 5a097c55
      Sergei Golubchik authored
      mariabackup tries to allocate a buffer of page_size*page_size/4 size.
      for 64k page it means 1Gb, which doesn't work very well on 32-bit builders.
      
      Skip the 64k page test on 32bit.
      5a097c55
    • Marko Mäkelä's avatar
      9ed50ece
    • Vladislav Vaintroub's avatar
      MDEV-23052 mysql_install_db.exe can run on existing non-empty directory, · fe05c16c
      Vladislav Vaintroub authored
      and remove it on error
      
      Disable existing non-empty datadir for mysql_install_db.exe
      fe05c16c
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · ea2bc974
      Marko Mäkelä authored
      ea2bc974
    • Sergei Golubchik's avatar
      make rocksdb cmake checks less verbose on repeat · 6d3747a2
      Sergei Golubchik authored
      * fix FindLZ4 to follow convention (LIBRARIES, not LIBRARY)
      * remove redundant checks from rocksdb/CMakeLists.txt
      * put all checks through the same macro that uniformly
        checks for a package, prints the message, adds definition
      6d3747a2
    • Otto Kekäläinen's avatar
      Fix RocksDB detection of ZSTD · 2ed41576
      Otto Kekäläinen authored
      The library finder needs to have capitals in its name so that FIND_PACKAGE
      will load the correct finder and actually detect that libzstd is available.
      
      Without this change the CMake would just always silently skip ZSTD since
      it would never find it.
      
      Simplify Debian autopkgtest RocksDB part and make it more verbose so that
      future regressions like this are easier to debug.
      
      Also remove QUIET from the RocksDB FIND_PACKAGE call so that it is easier
      to read in build logs what libraries were detected. Also add missing
      underscores to error messages.
      2ed41576