• Ebru Akagunduz's avatar
    mm: incorporate read-only pages into transparent huge pages · 10359213
    Ebru Akagunduz authored
    This patch aims to improve THP collapse rates, by allowing THP collapse in
    the presence of read-only ptes, like those left in place by do_swap_page
    after a read fault.
    
    Currently THP can collapse 4kB pages into a THP when there are up to
    khugepaged_max_ptes_none pte_none ptes in a 2MB range.  This patch applies
    the same limit for read-only ptes.
    
    The patch was tested with a test program that allocates 800MB of memory,
    writes to it, and then sleeps.  I force the system to swap out all but
    190MB of the program by touching other memory.  Afterwards, the test
    program does a mix of reads and writes to its memory, and the memory gets
    swapped back in.
    
    Without the patch, only the memory that did not get swapped out remained
    in THPs, which corresponds to 24% of the memory of the program.  The
    percentage did not increase over time.
    
    With this patch, after 5 minutes of waiting khugepaged had collapsed 50%
    of the program's memory back into THPs.
    
    Test results:
    
    With the patch:
    After swapped out:
    cat /proc/pid/smaps:
    Anonymous:      100464 kB
    AnonHugePages:  100352 kB
    Swap:           699540 kB
    Fraction:       99,88
    
    cat /proc/meminfo:
    AnonPages:      1754448 kB
    AnonHugePages:  1716224 kB
    Fraction:       97,82
    
    After swapped in:
    In a few seconds:
    cat /proc/pid/smaps:
    Anonymous:      800004 kB
    AnonHugePages:  145408 kB
    Swap:           0 kB
    Fraction:       18,17
    
    cat /proc/meminfo:
    AnonPages:      2455016 kB
    AnonHugePages:  1761280 kB
    Fraction:       71,74
    
    In 5 minutes:
    cat /proc/pid/smaps
    Anonymous:      800004 kB
    AnonHugePages:  407552 kB
    Swap:           0 kB
    Fraction:       50,94
    
    cat /proc/meminfo:
    AnonPages:      2456872 kB
    AnonHugePages:  2023424 kB
    Fraction:       82,35
    
    Without the patch:
    After swapped out:
    cat /proc/pid/smaps:
    Anonymous:      190660 kB
    AnonHugePages:  190464 kB
    Swap:           609344 kB
    Fraction:       99,89
    
    cat /proc/meminfo:
    AnonPages:      1740456 kB
    AnonHugePages:  1667072 kB
    Fraction:       95,78
    
    After swapped in:
    cat /proc/pid/smaps:
    Anonymous:      800004 kB
    AnonHugePages:  190464 kB
    Swap:           0 kB
    Fraction:       23,80
    
    cat /proc/meminfo:
    AnonPages:      2350032 kB
    AnonHugePages:  1667072 kB
    Fraction:       70,93
    
    I waited 10 minutes the fractions did not change without the patch.
    Signed-off-by: default avatarEbru Akagunduz <ebru.akagunduz@gmail.com>
    Reviewed-by: default avatarRik van Riel <riel@redhat.com>
    Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Acked-by: default avatarZhang Yanfei <zhangyanfei@cn.fujitsu.com>
    Acked-by: default avatarAndrea Arcangeli <aarcange@redhat.com>
    Acked-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Michal Hocko <mhocko@suse.cz>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Sasha Levin <sasha.levin@oracle.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    10359213
huge_memory.c 78.1 KB