• Rafael J. Wysocki's avatar
    rtc: rtc-cmos: Do not check ACPI_FADT_LOW_POWER_S0 · 6492fed7
    Rafael J. Wysocki authored
    The ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to
    use low-power S0 idle on the given platform than S3 (provided that
    the latter is supported) and it doesn't preclude using either of
    them (which of them will be used depends on the choices made by user
    space).
    
    For this reason, there is no benefit from checking that flag in
    use_acpi_alarm_quirks().
    
    First off, it cannot be a bug to do S3 with use_acpi_alarm set,
    because S3 can be used on systems with ACPI_FADT_LOW_POWER_S0 and it
    must work if really supported, so the ACPI_FADT_LOW_POWER_S0 check is
    not needed to protect the S3-capable systems from failing.
    
    Second, suspend-to-idle can be carried out on a system with
    ACPI_FADT_LOW_POWER_S0 unset and it is expected to work, so if setting
    use_acpi_alarm is needed to handle that case correctly, it should be
    set regardless of the ACPI_FADT_LOW_POWER_S0 value.
    
    Accordingly, drop the ACPI_FADT_LOW_POWER_S0 check from
    use_acpi_alarm_quirks().
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
    Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/12054246.O9o76ZdvQC@kreacher
    6492fed7
rtc-cmos.c 38.1 KB