• Thomas Gleixner's avatar
    perf/x86/intel/uncore: Clean up hotplug conversion fallout · bebb9d75
    Thomas Gleixner authored
    commit 1aa6cfd3 upstream.
    
    The recent conversion to the hotplug state machine kept two mechanisms from
    the original code:
    
     1) The first_init logic which adds the number of online CPUs in a package
        to the refcount. That's wrong because the callbacks are executed for
        all online CPUs.
    
        Remove it so the refcounting is correct.
    
     2) The on_each_cpu() call to undo box->init() in the error handling
        path. That's bogus because when the prepare callback fails no box has
        been initialized yet.
    
        Remove it.
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sebastian Siewior <bigeasy@linutronix.de>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Cc: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
    Fixes: 1a246b9f ("perf/x86/intel/uncore: Convert to hotplug state machine")
    Link: http://lkml.kernel.org/r/20170131230141.298032324@linutronix.deSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    bebb9d75
uncore.c 33.6 KB