Commit 17f3df8f authored by kernel test robot's avatar kernel test robot Committed by Martin K. Petersen

scsi: qla2xxx: edif: Fix returnvar.cocci warnings

drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0"
on line 264

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Link: https://lore.kernel.org/r/20210817051315.2477-12-njavali@marvell.com
Fixes: 7ebb336e ("scsi: qla2xxx: edif: Add start + stop bsgs")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7a8ff7d9
...@@ -628,7 +628,6 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job) ...@@ -628,7 +628,6 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
static int static int
qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job) qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
{ {
int32_t rval = 0;
struct app_stop appstop; struct app_stop appstop;
struct fc_bsg_reply *bsg_reply = bsg_job->reply; struct fc_bsg_reply *bsg_reply = bsg_job->reply;
struct fc_port *fcport, *tf; struct fc_port *fcport, *tf;
...@@ -679,7 +678,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job) ...@@ -679,7 +678,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
/* no return interface to app - it assumes we cleaned up ok */ /* no return interface to app - it assumes we cleaned up ok */
return rval; return 0;
} }
static int static int
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment