Commit 2bbd00ae authored by Johannes Weiner's avatar Johannes Weiner Committed by Linus Torvalds

mm: vmstat: fix NOHZ wakeups for node stat changes

On NOHZ, the periodic vmstat flushers on each CPU can go to sleep and
won't wake up until stat changes are detected in the per-cpu deltas of the
zone vmstat counters.

In commit 75ef7184 ("mm, vmstat: add infrastructure for per-node
vmstats") per-node counters were introduced, and subsequently most stats
were moved from the zone to the node level.  However, the node counters
weren't added to the NOHZ wakeup detection.

In theory this can cause per-cpu errors to remain in the user-reported
stats indefinitely.  In practice this only affects a handful of sub
counters (file_mapped, dirty and writeback e.g.) because other page state
changes at the node level likely involve a change at the zone level as
well (alloc and free, lru ops).  Also, nobody has complained.

Fix it up for completeness: wake up vmstat refreshing on node changes.
Also remove the BUILD_BUG_ONs that assert counter size; we haven't relied
on it since we added sizeof() to the range calculation in commit
13c9aaf7 ("mm/vmstat.c: fix NUMA statistics updates").

Link: https://lkml.kernel.org/r/20210202184342.118513-1-hannes@cmpxchg.orgSigned-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a052d4d1
...@@ -1894,16 +1894,12 @@ static void vmstat_update(struct work_struct *w) ...@@ -1894,16 +1894,12 @@ static void vmstat_update(struct work_struct *w)
*/ */
static bool need_update(int cpu) static bool need_update(int cpu)
{ {
pg_data_t *last_pgdat = NULL;
struct zone *zone; struct zone *zone;
for_each_populated_zone(zone) { for_each_populated_zone(zone) {
struct per_cpu_pageset *p = per_cpu_ptr(zone->pageset, cpu); struct per_cpu_pageset *p = per_cpu_ptr(zone->pageset, cpu);
struct per_cpu_nodestat *n;
BUILD_BUG_ON(sizeof(p->vm_stat_diff[0]) != 1);
#ifdef CONFIG_NUMA
BUILD_BUG_ON(sizeof(p->vm_numa_stat_diff[0]) != 2);
#endif
/* /*
* The fast way of checking if there are any vmstat diffs. * The fast way of checking if there are any vmstat diffs.
*/ */
...@@ -1915,6 +1911,13 @@ static bool need_update(int cpu) ...@@ -1915,6 +1911,13 @@ static bool need_update(int cpu)
sizeof(p->vm_numa_stat_diff[0]))) sizeof(p->vm_numa_stat_diff[0])))
return true; return true;
#endif #endif
if (last_pgdat == zone->zone_pgdat)
continue;
last_pgdat = zone->zone_pgdat;
n = per_cpu_ptr(zone->zone_pgdat->per_cpu_nodestats, cpu);
if (memchr_inv(n->vm_node_stat_diff, 0, NR_VM_NODE_STAT_ITEMS *
sizeof(n->vm_node_stat_diff[0])))
return true;
} }
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment