Commit 42f61295 authored by Alexander Viro's avatar Alexander Viro Committed by Linus Torvalds

[PATCH] (4/4) eicon iomem annotations and fixes

 * s_4bri.c has a nasty typo - bogus & in qBri_cpu_trapped().

   We have
	void *base;
   followed by
	regs[0] = READ_DWORD((&base + offset) + 0x70);

   which is *NOT* what is meant there - instead of access to memory
   pointed to by base we get access to _stack_ at some offset from the
   place where the local variable base lives.
Signed-off-by: default avatarArmin Schindler <armin@melware.de>
Signed-off-by: default avatarAl Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent b9454566
......@@ -66,10 +66,10 @@ static void qBri_cpu_trapped (PISDN_ADAPTER IoAdapter) {
IoAdapter->trapped = 1 ;
}
regs[0] = READ_DWORD((&base + offset) + 0x70);
regs[1] = READ_DWORD((&base + offset) + 0x74);
regs[2] = READ_DWORD((&base + offset) + 0x78);
regs[3] = READ_DWORD((&base + offset) + 0x7c);
regs[0] = READ_DWORD((base + offset) + 0x70);
regs[1] = READ_DWORD((base + offset) + 0x74);
regs[2] = READ_DWORD((base + offset) + 0x78);
regs[3] = READ_DWORD((base + offset) + 0x7c);
regs[0] &= IoAdapter->MemorySize - 1 ;
if ( (regs[0] >= offset)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment