Commit a7c0d6db authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

OF: properties: add missing of_node_put

commit 28b170e8 upstream.

Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
    when != true e == NULL
    when != of_node_put(e)
    when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a06d94d9
...@@ -810,6 +810,7 @@ struct device_node *of_graph_get_remote_node(const struct device_node *node, ...@@ -810,6 +810,7 @@ struct device_node *of_graph_get_remote_node(const struct device_node *node,
if (!of_device_is_available(remote)) { if (!of_device_is_available(remote)) {
pr_debug("not available for remote node\n"); pr_debug("not available for remote node\n");
of_node_put(remote);
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment